From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
osandov@fb.com, stable@vger.kernel.org, peterz@infradead.org,
torvalds@linux-foundation.org, tglx@linutronix.de,
kernel-team@fb.com
Subject: Re: sched/wait: Fix add_wait_queue() behavioral change
Date: Tue, 13 Feb 2018 16:42:20 +0100 [thread overview]
Message-ID: <20180213154220.GD5919@kroah.com> (raw)
In-Reply-To: <20180211103203.tt3w3dhlu2bn5bom@gmail.com>
On Sun, Feb 11, 2018 at 11:32:03AM +0100, Ingo Molnar wrote:
>
> * Jens Axboe <axboe@kernel.dk> wrote:
>
> > On 2/10/18 7:14 AM, Tetsuo Handa wrote:
> > > Recently, we are seeing I/O hungup reports.
> > >
> > > I don't know whether a regression introduced by commit 50816c48997af857
> > > ("sched/wait: Standardize internal naming of wait-queue entries") is relevant.
> > > But shouldn't we backport commit c6b9d9a330290144 ("sched/wait: Fix
> > > add_wait_queue() behavioral change") to 4.13+ kernels anyway?
> >
> > Yes, it most certainly should!
>
> Indeed, the bug was introduced in v4.13 and the fix was included in v4.15, but
> it's missing from v4.13 and v4.14 - not sure how I missed that.
>
> The fix (also attached below) applies cleanly to both v4.13 and v4.14:
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2018-02-13 15:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-10 14:14 sched/wait: Fix add_wait_queue() behavioral change Tetsuo Handa
2018-02-10 17:37 ` Jens Axboe
2018-02-11 10:32 ` Ingo Molnar
2018-02-11 18:28 ` Linus Torvalds
2018-02-13 16:15 ` Jens Axboe
2018-02-13 15:42 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213154220.GD5919@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=axboe@kernel.dk \
--cc=kernel-team@fb.com \
--cc=mingo@kernel.org \
--cc=osandov@fb.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.