From: Cornelia Huck <cohuck@redhat.com>
To: no-reply@patchew.org
Cc: qemu-devel@nongnu.org, david@redhat.com, famz@redhat.com,
qemu-s390x@nongnu.org, agraf@suse.de, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v1] s390x/tcg: fix disabling/enabling DAT
Date: Tue, 13 Feb 2018 18:47:59 +0100 [thread overview]
Message-ID: <20180213184759.4225abbe.cohuck@redhat.com> (raw)
In-Reply-To: <151853948001.582.10146832003778705101@bdbb90650ae5>
On Tue, 13 Feb 2018 08:31:21 -0800 (PST)
no-reply@patchew.org wrote:
> Checking PATCH 1/1: s390x/tcg: fix disabling/enabling DAT...
> WARNING: line over 80 characters
> #32: FILE: target/s390x/cpu.h:320:
> +#define FLAG_MASK_PSW (FLAG_MASK_PER | FLAG_MASK_DAT | FLAG_MASK_PSTATE \
I'll ignore this...
>
> ERROR: code indent should never use tabs
> #32: FILE: target/s390x/cpu.h:320:
> +#define FLAG_MASK_PSW^I^I(FLAG_MASK_PER | FLAG_MASK_DAT | FLAG_MASK_PSTATE \$
...and just get rid of the pre-existing tabs here while merging, no
need to resend.
>
> total: 1 errors, 1 warnings, 51 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> === OUTPUT END ===
>
> Test command exited with code: 1
>
>
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to patchew-devel@freelists.org
next prev parent reply other threads:[~2018-02-13 17:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 16:12 [Qemu-devel] [PATCH v1] s390x/tcg: fix disabling/enabling DAT David Hildenbrand
2018-02-13 16:24 ` Richard Henderson
2018-02-13 16:31 ` no-reply
2018-02-13 17:47 ` Cornelia Huck [this message]
2018-02-13 17:57 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213184759.4225abbe.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=david@redhat.com \
--cc=famz@redhat.com \
--cc=no-reply@patchew.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.