All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] cmake: bump version to 3.10.2 and add license hash
Date: Tue, 13 Feb 2018 23:25:38 +0100	[thread overview]
Message-ID: <20180213232538.0441c65a@windsurf.lan> (raw)
In-Reply-To: <20180213195729.33644-1-markhirota@gmail.com>

Hello,

On Tue, 13 Feb 2018 11:57:29 -0800, Mark Hirota wrote:
> Signed-off-by: Mark Hirota <markhirota@gmail.com>
> ---
>  package/cmake/cmake.hash | 5 +++--
>  package/cmake/cmake.mk   | 2 +-
>  2 files changed, 4 insertions(+), 3 deletions(-)

Thanks for this contribution. However, I'm a little bit worried by this
bump: it was already submitted before, and we had to revert because it
was causing gazillions of build failures.

See https://patchwork.ozlabs.org/patch/846757/. Basically, unless CMake
fixed the problem, CMake now requires C++11 to build, which is
annoying, as not all environments where Buildroot is used have a C++11
capable host compiler.

Could you check the status of the emplace_hint() method usage? Has it
been made conditional?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com

  reply	other threads:[~2018-02-13 22:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-13 19:57 [Buildroot] [PATCH 1/1] cmake: bump version to 3.10.2 and add license hash Mark Hirota
2018-02-13 22:25 ` Thomas Petazzoni [this message]
2018-02-14 14:48   ` Mark Hirota
2018-02-14 15:04     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180213232538.0441c65a@windsurf.lan \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.