From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tuomas Tynkkynen <tuomas@tuxera.com>
Date: Tue, 13 Feb 2018 23:50:08 +0200
Subject: [U-Boot] [PATCH 1/1] fs: fat: avoid useless conversion when
 calling getcluster
In-Reply-To: <20180213181858.10063-1-xypron.glpk@gmx.de>
References: <20180213181858.10063-1-xypron.glpk@gmx.de>
Message-ID: <20180213235008.047f4552@duuni>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi,

On Tue, 13 Feb 2018 19:18:58 +0100
Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:

> Parameter size of function get_cluster() is of type unsigned long. It makes
> no sense to convert actsize to int before passing it to get_cluster as
> size.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  fs/fat/fat.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/fat/fat.c b/fs/fat/fat.c
> index dd7888cd6d4..a3c7bf604eb 100644
> --- a/fs/fat/fat.c
> +++ b/fs/fat/fat.c
> @@ -353,7 +353,7 @@ static int get_contents(fsdata *mydata, dir_entry *dentptr, loff_t pos,
>  	if (pos) {
>  		actsize = min(filesize, (loff_t)bytesperclust);
>  		if (get_cluster(mydata, curclust, get_contents_vfatname_block,
> -				(int)actsize) != 0) {
> +				(unsigned long)actsize) != 0) {
>  			printf("Error reading cluster\n");

If the type is unsigned long, the explicit cast here seems redundant.