From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Date: Wed, 14 Feb 2018 07:52:42 +0000 Subject: Re: [PATCH] rtc: ds1302: remove redundant initializations of pointer bp Message-Id: <20180214075242.GA8219@piout.net> List-Id: References: <20180123101727.31028-1-colin.king@canonical.com> In-Reply-To: <20180123101727.31028-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Alessandro Zummo , linux-rtc@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On 23/01/2018 at 10:17:27 +0000, Colin King wrote: > From: Colin Ian King > > Pointe bp is being initialized and this value is never read, it > is being updated to the same value later just before it is going to > be used. Remove the initialization as it is never read and keep > the setting of bp closer to the use of bp. > > Cleans up clang warnings: > drivers/rtc/rtc-ds1302.c:115:7: warning: Value stored to 'bp' during > its initialization is never read > drivers/rtc/rtc-ds1302.c:46:7: warning: Value stored to 'bp' during > its initialization is never read > > Signed-off-by: Colin Ian King > --- > drivers/rtc/rtc-ds1302.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com ([62.4.15.54]:44363 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754489AbeBNHwo (ORCPT ); Wed, 14 Feb 2018 02:52:44 -0500 Date: Wed, 14 Feb 2018 08:52:42 +0100 From: Alexandre Belloni To: Colin King Cc: Alessandro Zummo , linux-rtc@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: ds1302: remove redundant initializations of pointer bp Message-ID: <20180214075242.GA8219@piout.net> References: <20180123101727.31028-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180123101727.31028-1-colin.king@canonical.com> Sender: linux-rtc-owner@vger.kernel.org List-ID: On 23/01/2018 at 10:17:27 +0000, Colin King wrote: > From: Colin Ian King > > Pointe bp is being initialized and this value is never read, it > is being updated to the same value later just before it is going to > be used. Remove the initialization as it is never read and keep > the setting of bp closer to the use of bp. > > Cleans up clang warnings: > drivers/rtc/rtc-ds1302.c:115:7: warning: Value stored to 'bp' during > its initialization is never read > drivers/rtc/rtc-ds1302.c:46:7: warning: Value stored to 'bp' during > its initialization is never read > > Signed-off-by: Colin Ian King > --- > drivers/rtc/rtc-ds1302.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com