From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
RDMA mailing list
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Noa Osherovich <noaos-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: [PATCH rdma-next 00/14] Refactor ib_uverbs_write path
Date: Wed, 14 Feb 2018 14:38:30 +0200 [thread overview]
Message-ID: <20180214123844.30321-1-leon@kernel.org> (raw)
Hi,
This series comes as an outcome of [1] which was sent to rdma-rc
and it should be applied on top of that patch.
During review process of that patch, we realized that the
ib_uverbs_write() has number of flaws and this series
tries to fix them:
1. Localize all processing and verification code in specific functions.
2. Fix the command mask insufficient checks.
3. Simplify code to allow drop uverbs_ex_mask and in the future we
will drop uverbs_mask too.
4. Fix differences in error codes.
Thanks
[1] https://marc.info/?l=linux-rdma&m=151851719021404&w=2
Leon Romanovsky (14):
RDMA/uverbs: Convert command mask validity check function to be bool
RDMA/uverbs: Update sizeof users
RDMA/uverbs: Refactor flags checks and update return value
RDMA/uverbs: Fail as early as possible if not enough header data was
provided
RDMA/uverbs: Return not supported error code for unsupported commands
RDMA/uverbs: Unify return values of not supported command
RDMA/uverbs: Refactor command header processing
RDMA/uverbs: Properly check command supported mask
RDMA/uverbs: Move uncontext check before SRCU read lock
RDMa/uverbs: Copy ex_hdr outside of SRCU read lock
RDMA/uverbs: Refactor the header validation logic
RDMA/verbs: Return proper error code for not supported system call
RDMA/verbs: Check existence of function prior to accessing it
RDMA/verbs: Drop uverbs_ex_mask
drivers/infiniband/core/core_priv.h | 3 +
drivers/infiniband/core/uverbs_cmd.c | 21 ++++
drivers/infiniband/core/uverbs_main.c | 219 ++++++++++++++++------------------
drivers/infiniband/core/verbs.c | 46 +++----
drivers/infiniband/hw/mlx4/main.c | 18 ---
drivers/infiniband/hw/mlx5/main.c | 15 ---
include/rdma/ib_verbs.h | 1 -
7 files changed, 150 insertions(+), 173 deletions(-)
--
2.16.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2018-02-14 12:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 12:38 Leon Romanovsky [this message]
[not found] ` <20180214123844.30321-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-02-14 12:38 ` [PATCH rdma-next 01/14] RDMA/uverbs: Convert command mask validity check function to be bool Leon Romanovsky
[not found] ` <20180214123844.30321-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-02-14 16:26 ` Dennis Dalessandro
2018-02-14 23:41 ` Jason Gunthorpe
[not found] ` <20180214234141.GC1718-uk2M96/98Pc@public.gmane.org>
2018-02-15 14:27 ` Leon Romanovsky
2018-02-14 12:38 ` [PATCH rdma-next 02/14] RDMA/uverbs: Update sizeof users Leon Romanovsky
[not found] ` <20180214123844.30321-3-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-02-14 16:27 ` Dennis Dalessandro
2018-02-14 12:38 ` [PATCH rdma-next 03/14] RDMA/uverbs: Refactor flags checks and update return value Leon Romanovsky
[not found] ` <20180214123844.30321-4-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-02-14 23:40 ` Jason Gunthorpe
2018-02-14 12:38 ` [PATCH rdma-next 04/14] RDMA/uverbs: Fail as early as possible if not enough header data was provided Leon Romanovsky
2018-02-14 12:38 ` [PATCH rdma-next 05/14] RDMA/uverbs: Return not supported error code for unsupported commands Leon Romanovsky
2018-02-14 12:38 ` [PATCH rdma-next 06/14] RDMA/uverbs: Unify return values of not supported command Leon Romanovsky
2018-02-14 12:38 ` [PATCH rdma-next 07/14] RDMA/uverbs: Refactor command header processing Leon Romanovsky
[not found] ` <20180214123844.30321-8-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-02-14 23:49 ` Jason Gunthorpe
[not found] ` <20180214234951.GF1718-uk2M96/98Pc@public.gmane.org>
2018-02-15 13:51 ` Leon Romanovsky
[not found] ` <20180215135120.GG2197-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2018-02-15 16:23 ` Jason Gunthorpe
2018-02-14 12:38 ` [PATCH rdma-next 08/14] RDMA/uverbs: Properly check command supported mask Leon Romanovsky
[not found] ` <20180214123844.30321-9-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-02-14 23:47 ` Jason Gunthorpe
[not found] ` <20180214234714.GE1718-uk2M96/98Pc@public.gmane.org>
2018-02-15 13:56 ` Leon Romanovsky
[not found] ` <20180215135628.GH2197-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2018-02-15 16:26 ` Jason Gunthorpe
[not found] ` <20180215162603.GB18416-uk2M96/98Pc@public.gmane.org>
2018-02-16 7:31 ` Leon Romanovsky
[not found] ` <20180216073147.GL2197-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2018-02-16 15:50 ` Jason Gunthorpe
2018-02-14 12:38 ` [PATCH rdma-next 09/14] RDMA/uverbs: Move uncontext check before SRCU read lock Leon Romanovsky
2018-02-14 12:38 ` [PATCH rdma-next 10/14] RDMa/uverbs: Copy ex_hdr outside of " Leon Romanovsky
2018-02-14 12:38 ` [PATCH rdma-next 11/14] RDMA/uverbs: Refactor the header validation logic Leon Romanovsky
[not found] ` <20180214123844.30321-12-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-02-14 23:46 ` Jason Gunthorpe
[not found] ` <20180214234635.GD1718-uk2M96/98Pc@public.gmane.org>
2018-02-15 14:26 ` Leon Romanovsky
2018-02-14 12:38 ` [PATCH rdma-next 12/14] RDMA/verbs: Return proper error code for not supported system call Leon Romanovsky
2018-02-14 12:38 ` [PATCH rdma-next 13/14] RDMA/verbs: Check existence of function prior to accessing it Leon Romanovsky
[not found] ` <20180214123844.30321-14-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-02-16 16:19 ` Jason Gunthorpe
[not found] ` <20180216161956.GA29023-uk2M96/98Pc@public.gmane.org>
2018-02-16 17:09 ` Leon Romanovsky
2018-02-14 12:38 ` [PATCH rdma-next 14/14] RDMA/verbs: Drop uverbs_ex_mask Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214123844.30321-1-leon@kernel.org \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=noaos-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.