From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-next 01/14] RDMA/uverbs: Convert command mask validity check function to be bool Date: Wed, 14 Feb 2018 16:41:41 -0700 Message-ID: <20180214234141.GC1718@ziepe.ca> References: <20180214123844.30321-1-leon@kernel.org> <20180214123844.30321-2-leon@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180214123844.30321-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky Cc: Doug Ledford , RDMA mailing list , Matan Barak , Noa Osherovich , Leon Romanovsky List-Id: linux-rdma@vger.kernel.org On Wed, Feb 14, 2018 at 02:38:31PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > The function validate_command_mask() returns only two results: success > or failure, so convert it to return bool instead of 0 and -1. > > Reported-by: Noa Osherovich > Reviewed-by: Matan Barak > Signed-off-by: Leon Romanovsky > drivers/infiniband/core/uverbs_main.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/infiniband/core/uverbs_main.c b/drivers/infiniband/core/uverbs_main.c > index b36cb12b3f38..1be9a93f628c 100644 > +++ b/drivers/infiniband/core/uverbs_main.c > @@ -635,7 +635,7 @@ struct file *ib_uverbs_alloc_async_event_file(struct ib_uverbs_file *uverbs_file > return filp; > } > > -static int verify_command_mask(struct ib_device *ib_dev, __u32 command) > +static bool verify_command_mask(struct ib_device *ib_dev, __u32 command) Shouldn't be __u32, just u32 for in-kernel stuff Same comment for all patches Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html