From: Linu Cherian <linuc.decode@gmail.com>
To: alex.williamson@redhat.com
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linu.cherian@cavium.com, Sunil.Goutham@cavium.com
Subject: Handling active DMA during a VFIO application crash
Date: Thu, 15 Feb 2018 16:34:06 +0530 [thread overview]
Message-ID: <20180215110406.GA15219@virtx40> (raw)
Hi,
Was exploring the implications of an application crash while DMA
is active from a vfio PCI device; the DMA being configured and
started by the application using vfio APIs.
The expectation is that, DMA is stopped/reset before we tear down the IOMMU mappings
and finally free the mmapped pages(on which DMA is happening).
>From the below stack trace(with dump_stack in vfio_pci_release),
[ 201.564273] [<ffffff8008798b50>] vfio_pci_release+0x80/0x458
[ 201.564276] [<ffffff8008792b74>] vfio_device_fops_release+0x2c/0x50
[ 201.564279] [<ffffff8008269ef4>] __fput+0x9c/0x218
[ 201.564283] [<ffffff800826a0e8>] ____fput+0x20/0x30
[ 201.564286] [<ffffff80080e7fe0>] task_work_run+0xa0/0xc8
[ 201.564289] [<ffffff80080cbc7c>] do_exit+0x2bc/0x9c8
[ 201.564293] [<ffffff80080cd0ec>] do_group_exit+0x3c/0xa8
[ 201.564296] [<ffffff80080d94c4>] get_signal+0x3e4/0x538
[ 201.564299] [<ffffff80080892f0>] do_signal+0x70/0x660
[ 201.564302] [<ffffff8008089ce8>] do_notify_resume+0xe0/0x120
PCI device is disabled/reset from vfio_pci_release invoked as part of
device fd release. The fd releases are in turn invoked from exit_files
and exit_task_work.
But exit_mm, gets called before exit_files/exit_task_work in do_exit.
Assuming all pages allocated/mmaped to a process gets freed in exit_mm,
is there is a possibility that user pages configured for DMA can get freed
to kernel before the vfio device is stopped/reset ?
Thanks.
--
Linu cherian
next reply other threads:[~2018-02-15 11:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 11:04 Linu Cherian [this message]
2018-02-15 16:21 ` Handling active DMA during a VFIO application crash Alex Williamson
2018-02-16 4:04 ` Linu Cherian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215110406.GA15219@virtx40 \
--to=linuc.decode@gmail.com \
--cc=Sunil.Goutham@cavium.com \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linu.cherian@cavium.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.