From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Nicolas Iooss <nicolas.iooss@m4x.org>
Cc: Stephen Smalley <sds@tycho.nsa.gov>, selinux <selinux@tycho.nsa.gov>
Subject: Re: Rework of makefiles v5
Date: Thu, 15 Feb 2018 14:04:55 +0100 [thread overview]
Message-ID: <20180215130455.GA20477@gmail.com> (raw)
In-Reply-To: <CAJfZ7=kT4VRgWzoQMyehL=a4qGNGGcNPqiUcw6523zVH9R+JHA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1910 bytes --]
Hi Nicolas,
First of all, thank you for your review.
On Wed, Feb 14, 2018 at 08:19:44PM +0100, Nicolas Iooss wrote:
> On Wed, Feb 14, 2018 at 10:57 AM, Marcus Folkesson
> <marcus.folkesson@gmail.com> wrote:
> > I have updated the patchset.
> >
> > The biggest change is that $(DESTDIR) is now used in the
> > install stage only.
> >
> > Also some overidden CFLAGS/LDFLAGS has been removed since we now have
> > explicit build rules.
> >
> > I have moved the changelog into patches.
> >
> > Please test to compile with:
> > make DESTDIR=/tmp/myroot PREFIX=/myusr install
> > or
> > make DESTDIR=/tmp/myroot install
> >
> > Thanks for all feedback.
> >
> > Best regards
> > Marcus Folkesson
> >
>
> Hi,
> Thanks for this update! Here are three comments on this patchset:
>
> * you forgot a $(DESTDIR) occurrence in patch 7.
Good catch!
> * .travis.yml needs a simple patch to fix the value of PYSITEDIR. I
> will send it later.
Please do.
> * While reading the Makefile after patch 15, I have been surprised by
> "LIBDIR ?= $(DESTDIR)$(PREFIX)/lib", with DESTDIR. As this variable is
> not exported, it works fine as it is, but it might be cleaner to
> define it as "LIBDIR ?= $(PREFIX)/lib" and to use $(DESTDIR) in the
> following lines. This point may be addressed in a follow-up commit
> after the patchset has been merged.
I agree.
I also think it could be part of a follow-up commit. I will take a note.
>
> As the patchset looks almost ready to be merged, I have created
> https://github.com/SELinuxProject/selinux/pull/79 with a modified
> patch 7 and my patch for .travis.yml. This pull request holds the
> commits I plan to apply in a few days if no other maintainer disagrees
> with this.
Ok, then I will not come up with a v6 that fixes your feedback for patch
#7.
>
> Best,
> Nicolas
>
Best regards
Marcus Folkesson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-15 13:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 9:57 Rework of makefiles v5 Marcus Folkesson
2018-02-14 9:57 ` [PATCH v5 01/15] libsepol: build: follow standard semantics for DESTDIR and PREFIX Marcus Folkesson
2018-02-14 9:57 ` [PATCH v5 02/15] libselinux: " Marcus Folkesson
2018-02-14 9:57 ` [PATCH v5 03/15] libsemanage: " Marcus Folkesson
2018-02-14 9:57 ` [PATCH v5 04/15] checkpolicy: " Marcus Folkesson
2018-02-14 9:57 ` [PATCH v5 05/15] gui: " Marcus Folkesson
2018-02-14 9:57 ` [PATCH v5 06/15] mcstrans: " Marcus Folkesson
2018-02-14 9:57 ` [PATCH v5 07/15] policycoreutils: " Marcus Folkesson
2018-02-14 19:00 ` Nicolas Iooss
2018-02-14 9:57 ` [PATCH v5 08/15] python: " Marcus Folkesson
2018-02-14 9:57 ` [PATCH v5 09/15] python: build: move modules from platform-specific to platform-shared Marcus Folkesson
2018-02-14 9:57 ` [PATCH v5 10/15] restorecond: build: follow standard semantics for DESTDIR and PREFIX Marcus Folkesson
2018-02-14 9:57 ` [PATCH v5 11/15] sandbox: " Marcus Folkesson
2018-02-14 9:57 ` [PATCH v5 12/15] secilc: " Marcus Folkesson
2018-02-14 9:57 ` [PATCH v5 13/15] semodule-utils: " Marcus Folkesson
2018-02-14 9:57 ` [PATCH v5 14/15] dbus: " Marcus Folkesson
2018-02-14 9:57 ` [PATCH v5 15/15] build: setup buildpaths if DESTDIR is specified Marcus Folkesson
2018-02-14 19:19 ` Rework of makefiles v5 Nicolas Iooss
2018-02-15 13:04 ` Marcus Folkesson [this message]
2018-02-21 21:46 ` Nicolas Iooss
2018-02-22 19:19 ` Marcus Folkesson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215130455.GA20477@gmail.com \
--to=marcus.folkesson@gmail.com \
--cc=nicolas.iooss@m4x.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.