From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Thu, 15 Feb 2018 15:58:49 +0100 Subject: [U-Boot] [PATCH v2] Revert "spl: eMMC/SD: Provide one __weak spl_boot_mode() function" In-Reply-To: <20180215144403.GJ10592@bill-the-cat> References: <1518696884-15642-1-git-send-email-fabio.estevam@nxp.com> <20180215153329.466691e3@jawa> <20180215144403.GJ10592@bill-the-cat> Message-ID: <20180215155849.362fa7b6@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, > On Thu, Feb 15, 2018 at 03:33:29PM +0100, Lukasz Majewski wrote: > > Hi Fabio, > > > > > This reverts commit d695d6627803dbb78a226e04b0436a01633a9936. > > > > > > Commit d695d6627803 ("spl: eMMC/SD: Provide one __weak > > > spl_boot_mode() function") breaks the boot on several i.MX6 > > > boards, such as cuboxi and wandboard: > > > > > > U-Boot SPL 2018.03-rc1-00212-g48914fc119 (Feb 10 2018 - 11:04:33 > > > +1300) Trying to boot from MMC1 > > > Failed to mount ext2 filesystem... > > > spl_load_image_ext: ext4fs mount err - 0 > > > > > > Revert it so that we can boot U-Boot again. > > > > This is IMHO throwing the baby with the batch.... > > I kind of feel we need to revert this too, sorry. I'm also worried > that we've broken some of the other platforms that also have funky > if-else expected logic, and we'll be at the point soon where we have > enough platforms that need to override the spl_boot_mode func with > what they had before that it's not a huge win. > Just my 2 cents. 1. IMHO 2 months release cycle is too short, regarding the peace of development; we move Kconfig, perform DM conversion, and deal with legacy code 2. As we removed the obsolete / not maitained archs. We also need to scrutinize the "core" u-boot code (which is often 10+ years old). As this patch showed - spotting some "implicit" errors - which cannot be found with travis CI build tests consumes some time. What is even more strange - this code from the very beginnig was developmed on iMX6 board .... We JUST need MORE time to stabilize thing...... Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: