From: "Emilio G. Cota" <cota@braap.org>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>,
Alexander Graf <agraf@suse.de>,
qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] translator: add retcode to translator_loop_temp_check
Date: Thu, 15 Feb 2018 11:24:02 -0500 [thread overview]
Message-ID: <20180215162402.GA2308@flamenco> (raw)
In-Reply-To: <6a46ae1c-0d64-48b6-c567-5e72b1ad009c@twiddle.net>
On Thu, Feb 15, 2018 at 07:09:56 -0800, Richard Henderson wrote:
> On 02/14/2018 07:14 PM, Emilio G. Cota wrote:
> > -void translator_loop_temp_check(DisasContextBase *db);
> > +int translator_loop_temp_check(DisasContextBase *db);
>
> bool.
>
> Although I don't see how this is helpful. If you want to customize the output,
> surely you just use tcg_check_temp_count directly?
The only advantage is that we get to keep the same warning on
all targets [that support the temps' check]. Admittedly
not a huge benefit; I can drop this if you want.
Thanks,
E.
next prev parent reply other threads:[~2018-02-15 16:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 3:14 [Qemu-devel] [PATCH 0/3] target/ppc: convert to generic translation loop Emilio G. Cota
2018-02-15 3:14 ` [Qemu-devel] [PATCH 1/3] translator: add retcode to translator_loop_temp_check Emilio G. Cota
2018-02-15 15:09 ` Richard Henderson
2018-02-15 16:24 ` Emilio G. Cota [this message]
2018-02-15 3:14 ` [Qemu-devel] [PATCH 2/3] target/ppc: convert to DisasContextBase Emilio G. Cota
2018-02-15 15:13 ` Richard Henderson
2018-02-15 3:14 ` [Qemu-devel] [PATCH 3/3] target/ppc: convert to TranslatorOps Emilio G. Cota
2018-02-15 15:20 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215162402.GA2308@flamenco \
--to=cota@braap.org \
--cc=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.