From: Sergei Trofimovich <slyfox@gentoo.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Mike Frysinger" <vapier@gentoo.org>,
"Zoltán Mizsei" <miqlas@gmail.com>,
"Daniel P . Berrange" <berrange@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alexey Kardashevskiy" <aik@ozlabs.ru>,
"Thomas Huth" <thuth@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH] capstone: fix building using system package
Date: Thu, 15 Feb 2018 18:21:53 +0000 [thread overview]
Message-ID: <20180215182153.3696ad5f@sf> (raw)
In-Reply-To: <20180215173539.11033-1-f4bug@amsat.org>
On Thu, 15 Feb 2018 14:35:39 -0300
Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> #else
> +#include <capstone/capstone.h>
I think it's incorrect. 'pkg-config' already reports 'capstone/' path:
$ pkg-config --cflags capstone
-I/usr/include/capstone
$ ls /usr/include/capstone/capstone.h
/usr/include/capstone/capstone.h
Thus I would guess
#include <capstone.h>
is still correct for system include path as well (contradicts the example).
qemu just needs to use 'pkg-config' to discover the include path and
libs. Maybe new capstone release has different pkgconfig setup?
--
Sergei
next prev parent reply other threads:[~2018-02-15 18:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 17:35 [Qemu-devel] [RFC PATCH] capstone: fix building using system package Philippe Mathieu-Daudé
2018-02-15 18:21 ` Sergei Trofimovich [this message]
2018-02-15 18:39 ` Philippe Mathieu-Daudé
2018-02-15 18:45 ` miqlas
2018-02-16 3:01 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215182153.3696ad5f@sf \
--to=slyfox@gentoo.org \
--cc=aik@ozlabs.ru \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=marcandre.lureau@redhat.com \
--cc=miqlas@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.