From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 15 Feb 2018 22:41:58 +0100 (CET) Received: from mail.linuxfoundation.org ([140.211.169.12]:57656 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23990656AbeBOVluA06MO (ORCPT ); Thu, 15 Feb 2018 22:41:50 +0100 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 6340BF09; Thu, 15 Feb 2018 21:41:42 +0000 (UTC) Date: Thu, 15 Feb 2018 22:41:42 +0100 From: Greg Kroah-Hartman To: James Hogan Cc: "David S. Miller" , linux-mips@linux-mips.org, Paul Burton , Ralf Baechle , Corentin Labbe , linux-usb@vger.kernel.org Subject: Re: [PATCH 1/2] usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT Message-ID: <20180215214142.GA31227@kroah.com> References: <05aec8b194d01871c2e9f62ce38d68b56dff59ca.1517437177.git-series.jhogan@kernel.org> <20180215174203.GA21337@kroah.com> <20180215213847.GK3986@saruman> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180215213847.GK3986@saruman> User-Agent: Mutt/1.9.3 (2018-01-21) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 62564 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: gregkh@linuxfoundation.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Thu, Feb 15, 2018 at 09:38:48PM +0000, James Hogan wrote: > On Thu, Feb 15, 2018 at 06:42:03PM +0100, Greg Kroah-Hartman wrote: > > On Wed, Jan 31, 2018 at 10:24:45PM +0000, James Hogan wrote: > > > Move the Kconfig symbols USB_UHCI_BIG_ENDIAN_MMIO and > > > USB_UHCI_BIG_ENDIAN_DESC out of drivers/usb/host/Kconfig, which is > > > conditional upon USB && USB_SUPPORT, so that it can be freely selected > > > by platform Kconfig symbols in architecture code. > > > > > > For example once the MIPS_GENERIC platform selects are fixed in the > > > patch "MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN", the MIPS > > > 32r6_defconfig warns like so: > > > > > > warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB) > > > warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_DESC which has unmet direct dependencies (USB_SUPPORT && USB) > > > > > > Signed-off-by: James Hogan > > > Cc: Greg Kroah-Hartman > > > Cc: Corentin Labbe > > > Cc: linux-usb@vger.kernel.org > > > > Acked-by: Greg Kroah-Hartman > > Thanks, I'll apply this as a MIPS fix for 4.16. > > Okay to leave patch 2 for you to deal with Greg since it doesn't really > directly affect MIPS nor is it important for 4.16? Just take both of them and be done with it :) thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/2] usb: Move USB_UHCI_BIG_ENDIAN_* out of USB_SUPPORT From: Greg Kroah-Hartman Message-Id: <20180215214142.GA31227@kroah.com> Date: Thu, 15 Feb 2018 22:41:42 +0100 To: James Hogan Cc: "David S. Miller" , linux-mips@linux-mips.org, Paul Burton , Ralf Baechle , Corentin Labbe , linux-usb@vger.kernel.org List-ID: T24gVGh1LCBGZWIgMTUsIDIwMTggYXQgMDk6Mzg6NDhQTSArMDAwMCwgSmFtZXMgSG9nYW4gd3Jv dGU6Cj4gT24gVGh1LCBGZWIgMTUsIDIwMTggYXQgMDY6NDI6MDNQTSArMDEwMCwgR3JlZyBLcm9h aC1IYXJ0bWFuIHdyb3RlOgo+ID4gT24gV2VkLCBKYW4gMzEsIDIwMTggYXQgMTA6MjQ6NDVQTSAr MDAwMCwgSmFtZXMgSG9nYW4gd3JvdGU6Cj4gPiA+IE1vdmUgdGhlIEtjb25maWcgc3ltYm9scyBV U0JfVUhDSV9CSUdfRU5ESUFOX01NSU8gYW5kCj4gPiA+IFVTQl9VSENJX0JJR19FTkRJQU5fREVT QyBvdXQgb2YgZHJpdmVycy91c2IvaG9zdC9LY29uZmlnLCB3aGljaCBpcwo+ID4gPiBjb25kaXRp b25hbCB1cG9uIFVTQiAmJiBVU0JfU1VQUE9SVCwgc28gdGhhdCBpdCBjYW4gYmUgZnJlZWx5IHNl bGVjdGVkCj4gPiA+IGJ5IHBsYXRmb3JtIEtjb25maWcgc3ltYm9scyBpbiBhcmNoaXRlY3R1cmUg Y29kZS4KPiA+ID4gCj4gPiA+IEZvciBleGFtcGxlIG9uY2UgdGhlIE1JUFNfR0VORVJJQyBwbGF0 Zm9ybSBzZWxlY3RzIGFyZSBmaXhlZCBpbiB0aGUKPiA+ID4gcGF0Y2ggIk1JUFM6IEZpeCB0eXBv IEJJR19FTkRJQU4gdG8gQ1BVX0JJR19FTkRJQU4iLCB0aGUgTUlQUwo+ID4gPiAzMnI2X2RlZmNv bmZpZyB3YXJucyBsaWtlIHNvOgo+ID4gPiAKPiA+ID4gd2FybmluZzogKE1JUFNfR0VORVJJQykg c2VsZWN0cyBVU0JfVUhDSV9CSUdfRU5ESUFOX01NSU8gd2hpY2ggaGFzIHVubWV0IGRpcmVjdCBk ZXBlbmRlbmNpZXMgKFVTQl9TVVBQT1JUICYmIFVTQikKPiA+ID4gd2FybmluZzogKE1JUFNfR0VO RVJJQykgc2VsZWN0cyBVU0JfVUhDSV9CSUdfRU5ESUFOX0RFU0Mgd2hpY2ggaGFzIHVubWV0IGRp cmVjdCBkZXBlbmRlbmNpZXMgKFVTQl9TVVBQT1JUICYmIFVTQikKPiA+ID4gCj4gPiA+IFNpZ25l ZC1vZmYtYnk6IEphbWVzIEhvZ2FuIDxqaG9nYW5Aa2VybmVsLm9yZz4KPiA+ID4gQ2M6IEdyZWcg S3JvYWgtSGFydG1hbiA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+Cj4gPiA+IENjOiBDb3Jl bnRpbiBMYWJiZSA8Y2xhYmJlLm1vbnRqb2llQGdtYWlsLmNvbT4KPiA+ID4gQ2M6IGxpbnV4LXVz YkB2Z2VyLmtlcm5lbC5vcmcKPiA+IAo+ID4gQWNrZWQtYnk6IEdyZWcgS3JvYWgtSGFydG1hbiA8 Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+Cj4gCj4gVGhhbmtzLCBJJ2xsIGFwcGx5IHRoaXMg YXMgYSBNSVBTIGZpeCBmb3IgNC4xNi4KPiAKPiBPa2F5IHRvIGxlYXZlIHBhdGNoIDIgZm9yIHlv dSB0byBkZWFsIHdpdGggR3JlZyBzaW5jZSBpdCBkb2Vzbid0IHJlYWxseQo+IGRpcmVjdGx5IGFm ZmVjdCBNSVBTIG5vciBpcyBpdCBpbXBvcnRhbnQgZm9yIDQuMTY/CgpKdXN0IHRha2UgYm90aCBv ZiB0aGVtIGFuZCBiZSBkb25lIHdpdGggaXQgOikKCnRoYW5rcywKCmdyZWcgay1oCi0tLQpUbyB1 bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGlu dXgtdXNiIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVs Lm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9y ZG9tby1pbmZvLmh0bWwK