From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-rc] RDMA/restrack: don't use uaccess_kernel() Date: Thu, 15 Feb 2018 14:58:54 -0700 Message-ID: <20180215215854.GA16973@ziepe.ca> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Steve Wise Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Thu, Feb 08, 2018 at 12:09:43PM -0800, Steve Wise wrote: > + case RDMA_RESTRACK_QP: > + qp = container_of(res, struct ib_qp, res); > + if (qp->pd) > + is_user = qp->pd->uobject; ?? Why is this like this? struct ib_qp has a uboject, why do we need to look at the PD? Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html