From: Johan Hedberg <johan.hedberg@gmail.com>
To: Szymon Janc <szymon.janc@codecoup.pl>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v3] adapter: Add ConnectDevice method
Date: Fri, 16 Feb 2018 20:02:11 +0200 [thread overview]
Message-ID: <20180216180211.GA29745@x1c> (raw)
In-Reply-To: <20180212215946.30909-1-szymon.janc@codecoup.pl>
Hi Szymon,
On Mon, Feb 12, 2018, Szymon Janc wrote:
> + } else {
> + dev->pending = create_pending_list(dev, NULL);
>
> - dev->pending = g_slist_append(dev->pending, service);
> + DBG("BLAH %d", g_slist_length(dev->pending));
Seems like something you forgot to remove? :)
Otherwise the patch seems fine to me.
Johan
next prev parent reply other threads:[~2018-02-16 18:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 21:59 [PATCH v3] adapter: Add ConnectDevice method Szymon Janc
2018-02-16 18:02 ` Johan Hedberg [this message]
2018-02-19 12:04 ` Szymon Janc
2018-02-16 18:03 ` Marcel Holtmann
2018-02-19 13:29 ` Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180216180211.GA29745@x1c \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=szymon.janc@codecoup.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.