From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ishita Tripathi <sakurakhadag@gmail.com>
Cc: --to: Ian Abbott <abbotti@mev.co.uk>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] Fix checkpatch issue
Date: Fri, 16 Feb 2018 21:51:05 +0100 [thread overview]
Message-ID: <20180216205105.GB2375@kroah.com> (raw)
In-Reply-To: <20180216204100.GA76452@ubuntu>
On Fri, Feb 16, 2018 at 12:41:00PM -0800, Ishita Tripathi wrote:
> Deleted line break after dereference operator (->)
Your subject is a bit "odd" :)
Please look at other patches for this directory to see the proper prefix
to use.
>
> Signed-off-by: Ishita Tripathi <sakurakhadag@gmail.com>
>
> ---
> drivers/staging/comedi/drivers/rtd520.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/rtd520.c b/drivers/staging/comedi/drivers/rtd520.c
> index bb400e0..47b7093 100644
> --- a/drivers/staging/comedi/drivers/rtd520.c
> +++ b/drivers/staging/comedi/drivers/rtd520.c
> @@ -815,9 +815,8 @@ static int rtd_ai_cmdtest(struct comedi_device *dev,
>
> if (cmd->scan_begin_src == TRIG_TIMER) {
> arg = cmd->convert_arg * cmd->scan_end_arg;
> - err |= comedi_check_trigger_arg_min(&cmd->
> - scan_begin_arg,
> - arg);
> + err |= comedi_check_trigger_arg_min(&cmd->scan_begin_arg,
> + arg);
No need to move the last line here, right? Please keep it as-is.
thanks,
greg k-h
next prev parent reply other threads:[~2018-02-16 20:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 20:41 [PATCH] Fix checkpatch issue Ishita Tripathi
2018-02-16 20:51 ` Greg Kroah-Hartman [this message]
2018-02-16 20:54 ` [Outreachy kernel] " Julia Lawall
2018-02-16 21:26 ` Ishita Tripathi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180216205105.GB2375@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=hsweeten@visionengravers.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=sakurakhadag@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.