All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ishita Tripathi <sakurakhadag@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	H Hartley Sweeten <hsweeten@visionengravers.com>,
	Ian Abbott <abbotti@mev.co.uk>
Cc: outreachy-kernel@googlegroups.com
Subject: [PATCH v2] staging: rtd520.c: Fix new line after dereference operator
Date: Fri, 16 Feb 2018 14:16:03 -0800	[thread overview]
Message-ID: <20180216221603.GA77503@ubuntu> (raw)

Delete new line after the dereference operator (->).
According to https://kernelnewbies.org/CheckpatchTips, it is better to
have longer lines than break at this operator.

Signed-off-by: Ishita Tripathi <sakurakhadag@gmail.com>
---
 drivers/staging/comedi/drivers/rtd520.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/comedi/drivers/rtd520.c b/drivers/staging/comedi/drivers/rtd520.c
index bb400e0..47b7093 100644
--- a/drivers/staging/comedi/drivers/rtd520.c
+++ b/drivers/staging/comedi/drivers/rtd520.c
@@ -815,9 +815,8 @@ static int rtd_ai_cmdtest(struct comedi_device *dev,
 
 		if (cmd->scan_begin_src == TRIG_TIMER) {
 			arg = cmd->convert_arg * cmd->scan_end_arg;
-			err |= comedi_check_trigger_arg_min(&cmd->
-							    scan_begin_arg,
-							    arg);
+			err |= comedi_check_trigger_arg_min(&cmd->scan_begin_arg,
+					arg);
 		}
 	}
 
-- 
changes in v2:
-changed subject line
-improved description
2.7.4



             reply	other threads:[~2018-02-16 22:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-16 22:16 Ishita Tripathi [this message]
2018-02-16 23:01 ` [Outreachy kernel] [PATCH v2] staging: rtd520.c: Fix new line after dereference operator Gargi Sharma
2018-02-17  7:31 ` Julia Lawall
2018-02-19 10:24   ` Ian Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180216221603.GA77503@ubuntu \
    --to=sakurakhadag@gmail.com \
    --cc=abbotti@mev.co.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.