From: Jonathan Cameron <jic23@kernel.org>
To: Richard Lai <richard@richardman.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Narcisa Ana Maria Vasile <narcisaanamaria12@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: chemical: ccs811: Typo correction in HW_ID_VALUE constant define naming
Date: Sat, 17 Feb 2018 14:12:16 +0000 [thread overview]
Message-ID: <20180217141148.78246adc@archlinux> (raw)
In-Reply-To: <1518561421-11736-1-git-send-email-richard@richardman.com>
On Tue, 13 Feb 2018 22:36:57 +0000
Richard Lai <richard@richardman.com> wrote:
> This particular constant was named with prefix "CCS881", which should be
> "CCS811" instead, just like the rest of constant names in the file, as this
> driver implementation is for AMS CCS811 sensor. "CCS881" could literally be
> referring to another sensor product unrelated to AMS CCS811 sensor.
>
> Signed-off-by: Richard Lai <richard@richardman.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/chemical/ccs811.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/chemical/ccs811.c b/drivers/iio/chemical/ccs811.c
> index 840a6cb..8e8beb7 100644
> --- a/drivers/iio/chemical/ccs811.c
> +++ b/drivers/iio/chemical/ccs811.c
> @@ -31,7 +31,7 @@
> #define CCS811_ALG_RESULT_DATA 0x02
> #define CCS811_RAW_DATA 0x03
> #define CCS811_HW_ID 0x20
> -#define CCS881_HW_ID_VALUE 0x81
> +#define CCS811_HW_ID_VALUE 0x81
> #define CCS811_HW_VERSION 0x21
> #define CCS811_HW_VERSION_VALUE 0x10
> #define CCS811_HW_VERSION_MASK 0xF0
> @@ -315,7 +315,7 @@ static int ccs811_probe(struct i2c_client *client,
> if (ret < 0)
> return ret;
>
> - if (ret != CCS881_HW_ID_VALUE) {
> + if (ret != CCS811_HW_ID_VALUE) {
> dev_err(&client->dev, "hardware id doesn't match CCS81x\n");
> return -ENODEV;
> }
prev parent reply other threads:[~2018-02-17 14:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 22:36 [PATCH] iio: chemical: ccs811: Typo correction in HW_ID_VALUE constant define naming Richard Lai
2018-02-17 14:12 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180217141148.78246adc@archlinux \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narcisaanamaria12@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=richard@richardman.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.