From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-path: Received: from mail-pf0-f194.google.com ([209.85.192.194]:35356 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751010AbeBQQKS (ORCPT ); Sat, 17 Feb 2018 11:10:18 -0500 Date: Sat, 17 Feb 2018 08:10:15 -0800 From: Guenter Roeck To: Jerry Hoemann Cc: wim@linux-watchdog.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, rwright@hpe.com, maurice.a.saldivar@hpe.com, mingo@kernel.org, marcus.folkesson@gmail.com Subject: Re: [v3,02/11] watchdog/hpwdt: remove include files no longer needed. Message-ID: <20180217161015.GA6155@roeck-us.net> References: <20180215234400.5022-3-jerry.hoemann@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180215234400.5022-3-jerry.hoemann@hpe.com> Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On Thu, Feb 15, 2018 at 04:43:51PM -0700, Jerry Hoemann wrote: > Remove header files used by NMI sourcing and DMI decoding. > > Signed-off-by: Jerry Hoemann This patch should have been merged with the 1st patch of the series, since it is logically the same change. However, that does not raise to the level of objection. Reviewed-by: Guenter Roeck > --- > drivers/watchdog/hpwdt.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c > index 113058644fc3..20a13c5d0285 100644 > --- a/drivers/watchdog/hpwdt.c > +++ b/drivers/watchdog/hpwdt.c > @@ -28,16 +28,7 @@ > #include > #include > #include > -#ifdef CONFIG_HPWDT_NMI_DECODING > -#include > -#include > -#include > -#include > -#include > -#include > -#endif /* CONFIG_HPWDT_NMI_DECODING */ > #include > -#include > > #define HPWDT_VERSION "1.4.0" > #define SECS_TO_TICKS(secs) ((secs) * 1000 / 128)