All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eugeniu Rosca <roscaeugeniu@gmail.com>
To: Ulf Magnusson <ulfalizer@gmail.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Nicolas Pitre <nicolas.pitre@linaro.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	Petr Vorel <petr.vorel@gmail.com>,
	Paul Bolle <pebolle@tiscali.nl>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	Eugeniu Rosca <rosca.eugeniu@gmail.com>,
	Eugeniu Rosca <erosca@de.adit-jv.com>
Subject: Re: [PATCH 2/2] kconfig: Print the value of each reverse dependency
Date: Sun, 18 Feb 2018 12:34:30 +0100	[thread overview]
Message-ID: <20180218113430.GA28114@example.com> (raw)
In-Reply-To: <CAFkk2KTmPEC-CxO2u0qXBKkRvpScGFD3C6LHdgL+LCBWKf7Dig@mail.gmail.com>

On Sat, Feb 17, 2018 at 06:31:48PM +0100, Ulf Magnusson wrote:
> On Sat, Feb 17, 2018 at 6:20 PM, Eugeniu Rosca <roscaeugeniu@gmail.com> wrote:
> > Hi Ulf,
> >
> > On Wed, Feb 14, 2018 at 05:09:50AM +0100, Ulf Magnusson wrote:
> >> IMO, we could take this as is (after addressing other people's
> >> comments), since it's already a big improvement, and then add sorting
> >> later if we feel like it.
> >>
> >> Don't have to do everything at once. :)
> >
> > I agree that it's not possible to do everything perfect right from the
> > start. But since we are changing the user experience, I just thought
> > that we would first like to see how both implementations (prefixed
> > vs grouped tokens) look like, then make a decision (I'm still open
> > minded about it), then affect the users.
> 
> Isn't the latest patchset doing both? That seems like the best of both worlds.

Well, I call "prefixed tokens" solution [1] and "grouped tokens"
solution [2]. Assuming we share the same view, [1] has definitely less
of an impact on Kconfig (see [3]). That's the main argument to prefer it
over [2]. My personal choice is still [2]. However if it happens
that other reviewers prefer [1], I won't object on it.

[1] Selected by:
    - [y] EXPR_Y
    - [m] EXPR_M
    - [ ] EXPR_N

[2] Selected by [y]:
    - EXPR_Y
    Selected by [m]:
    - EXPR_M
    Selected by [n]:
    - EXPR_N

[3] https://marc.info/?l=linux-kbuild&m=151848343313335&w=4

> And yeah, I just get some personal restlessness when good stuff floats
> around for a long time without getting in. :)
> 
> Cheers,
> Ulf

Thanks,
Eugeniu.

  reply	other threads:[~2018-02-18 11:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-13  0:56 [PATCH 1/2] kconfig: Print reverse dependencies on new line consistently Eugeniu Rosca
2018-02-13  0:56 ` [PATCH 2/2] kconfig: Print the value of each reverse dependency Eugeniu Rosca
2018-02-13  6:18   ` Ulf Magnusson
2018-02-13 23:54     ` Eugeniu Rosca
2018-02-14  0:41       ` Petr Vorel
2018-02-17 17:26         ` Eugeniu Rosca
2018-02-14  4:09       ` Ulf Magnusson
2018-02-17 17:20         ` Eugeniu Rosca
2018-02-17 17:31           ` Ulf Magnusson
2018-02-18 11:34             ` Eugeniu Rosca [this message]
2018-02-14  0:46   ` Petr Vorel
2018-02-13  6:11 ` [PATCH 1/2] kconfig: Print reverse dependencies on new line consistently Ulf Magnusson
2018-02-13  6:40   ` Petr Vorel
2018-02-14  0:32     ` Eugeniu Rosca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180218113430.GA28114@example.com \
    --to=roscaeugeniu@gmail.com \
    --cc=erosca@de.adit-jv.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=nicolas.pitre@linaro.org \
    --cc=pebolle@tiscali.nl \
    --cc=petr.vorel@gmail.com \
    --cc=rdunlap@infradead.org \
    --cc=rosca.eugeniu@gmail.com \
    --cc=ulfalizer@gmail.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.