All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, agraf@suse.de, ehabkost@redhat.com,
	armbru@redhat.com, david@redhat.com, dgilbert@redhat.com,
	borntraeger@de.ibm.com, qemu-s390x@nongnu.org,
	pbonzini@redhat.com, rth@twiddle.net, eblake@redhat.com
Subject: Re: [Qemu-devel] [PATCHv5 5/5] hmp: change hmp_info_cpus to use query-cpus-fast
Date: Mon, 19 Feb 2018 15:59:07 +0100	[thread overview]
Message-ID: <20180219155907.55ea1fc6.cohuck@redhat.com> (raw)
In-Reply-To: <1518797321-28356-6-git-send-email-mihajlov@linux.vnet.ibm.com>

On Fri, 16 Feb 2018 17:08:41 +0100
Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com> wrote:

> Changing the implementation of hmp_info_cpus() to call

s/Changing/Change/

> qmp_query_cpus_fast() instead of qmp_query_cpus. This has the
> following consequences:
> 
>   o No further code change required for qmp_query_cpus deprecation
> 
>   o HMP profits from the less disruptive cpu information retrieval
> 
>   o HMP 'info cpus' won't display architecture specific data anymore,
>     which should be tolerable in the light of the deprecation of
>     query-cpus.
> 
> In order to allow 'info cpus' to be executed completely on the
> fast path, monitor_get_cpu_index() has been adapted to not synchronize
> the cpu state.
> 
> Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
> ---
>  hmp.c     | 41 +++++++----------------------------------
>  monitor.c | 13 ++++++++++---
>  2 files changed, 17 insertions(+), 37 deletions(-)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>

  reply	other threads:[~2018-02-19 14:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-16 16:08 [Qemu-devel] [PATCHv5 0/5] add query-cpu-fast and related s390 changes Viktor Mihajlovski
2018-02-16 16:08 ` [Qemu-devel] [PATCHv5 1/5] qmp: expose s390-specific CPU info Viktor Mihajlovski
2018-02-19 14:54   ` Cornelia Huck
2018-02-16 16:08 ` [Qemu-devel] [PATCHv5 2/5] qmp: add query-cpus-fast Viktor Mihajlovski
2018-02-19 14:56   ` Cornelia Huck
2018-02-19 16:54   ` Eric Blake
2018-02-16 16:08 ` [Qemu-devel] [PATCHv5 3/5] qmp: add architecture specific cpu data for query-cpus-fast Viktor Mihajlovski
2018-02-16 16:08 ` [Qemu-devel] [PATCHv5 4/5] qemu-doc: deprecate query-cpus Viktor Mihajlovski
2018-02-19 14:57   ` Cornelia Huck
2018-02-27 13:41     ` Viktor Mihajlovski
2018-02-27 19:06       ` Cornelia Huck
2018-03-02 10:36         ` Cornelia Huck
2018-02-16 16:08 ` [Qemu-devel] [PATCHv5 5/5] hmp: change hmp_info_cpus to use query-cpus-fast Viktor Mihajlovski
2018-02-19 14:59   ` Cornelia Huck [this message]
2018-02-19 16:57   ` Eric Blake
2018-02-27 19:40   ` Dr. David Alan Gilbert
2018-02-19 15:01 ` [Qemu-devel] [PATCHv5 0/5] add query-cpu-fast and related s390 changes Cornelia Huck
2018-02-20 12:23 ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180219155907.55ea1fc6.cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=agraf@suse.de \
    --cc=armbru@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=david@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=mihajlov@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.