From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: core: introduce per-port over-current counters From: Greg Kroah-Hartman Message-Id: <20180219155914.GA23577@kroah.com> Date: Mon, 19 Feb 2018 16:59:14 +0100 To: Richard Leitner Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stern@rowland.harvard.edu, linux@roeck-us.net, mathias.nyman@linux.intel.com, johan@kernel.org, felipe.balbi@linux.intel.com, ekorenevsky@gmail.com, peter.chen@nxp.com, drake@endlessm.com, joe@perches.com, Richard Leitner List-ID: T24gTW9uLCBGZWIgMTksIDIwMTggYXQgMDE6MDE6MDdQTSArMDEwMCwgUmljaGFyZCBMZWl0bmVy IHdyb3RlOgo+IEZyb206IFJpY2hhcmQgTGVpdG5lciA8cmljaGFyZC5sZWl0bmVyQHNraWRhdGEu Y29tPgo+IAo+IEZvciBzb21lIHVzZXJzcGFjZSBhcHBsaWNhdGlvbnMgaW5mb3JtYXRpb24gb24g dGhlIG51bWJlciBvZgo+IG92ZXItY3VycmVudCBjb25kaXRpb25zIGF0IHNwZWNpZmljIFVTQiBo dWIgcG9ydHMgaXMgcmVsZXZhbnQuIFRoZXJlZm9yZQo+IGludHJvZHVjZSBhIG9jX2NvdW50ZXIg aW4gdGhlIHVzYiBwb3J0IHN0cnVjdCB3aGljaCBpcyBleHBvcnRlZCB2aWEKPiBzeXNmcy4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBSaWNoYXJkIExlaXRuZXIgPHJpY2hhcmQubGVpdG5lckBza2lkYXRh LmNvbT4KPiAtLS0KPiBUZXN0ZWQgb24gYW4gaS5NWDZETCBiYXNlZCBib2FyZC4KPiAtLS0KPiAg ZHJpdmVycy91c2IvY29yZS9odWIuYyAgfCAgNCArKystCj4gIGRyaXZlcnMvdXNiL2NvcmUvaHVi LmggIHwgIDEgKwo+ICBkcml2ZXJzL3VzYi9jb3JlL3BvcnQuYyB8IDEwICsrKysrKysrKysKPiAg MyBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpXaGVuIHlv dSBhZGQvcmVtb3ZlL21vZGlmeSBhIHN5c2ZzIGF0dHJpYnV0ZSwgeW91IGFsd2F5cyBoYXZlIHRv CmRvY3VtZW50IGluIERvY3VtZW50YXRpb24vQUJJLwoKCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvdXNiL2NvcmUvaHViLmMgYi9kcml2ZXJzL3VzYi9jb3JlL2h1Yi5jCj4gaW5kZXggYzVjMWY2 Y2YzMjI4Li40NDhmYmExZTE4MjcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy91c2IvY29yZS9odWIu Ywo+ICsrKyBiL2RyaXZlcnMvdXNiL2NvcmUvaHViLmMKPiBAQCAtNTEwNCw4ICs1MTA0LDEwIEBA IHN0YXRpYyB2b2lkIHBvcnRfZXZlbnQoc3RydWN0IHVzYl9odWIgKmh1YiwgaW50IHBvcnQxKQo+ ICAKPiAgCWlmIChwb3J0Y2hhbmdlICYgVVNCX1BPUlRfU1RBVF9DX09WRVJDVVJSRU5UKSB7Cj4g IAkJdTE2IHN0YXR1cyA9IDAsIHVudXNlZDsKPiArCQlwb3J0X2Rldi0+b2NfY291bnQrKzsKPiAg Cj4gLQkJZGV2X2RiZygmcG9ydF9kZXYtPmRldiwgIm92ZXItY3VycmVudCBjaGFuZ2VcbiIpOwo+ ICsJCWRldl9kYmcoJnBvcnRfZGV2LT5kZXYsICJvdmVyLWN1cnJlbnQgY2hhbmdlICMldVxuIiwK PiArCQkJcG9ydF9kZXYtPm9jX2NvdW50KTsKPiAgCQl1c2JfY2xlYXJfcG9ydF9mZWF0dXJlKGhk ZXYsIHBvcnQxLAo+ICAJCQkJVVNCX1BPUlRfRkVBVF9DX09WRVJfQ1VSUkVOVCk7Cj4gIAkJbXNs ZWVwKDEwMCk7CS8qIENvb2wgZG93biAqLwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9jb3Jl L2h1Yi5oIGIvZHJpdmVycy91c2IvY29yZS9odWIuaAo+IGluZGV4IDJhNzAwY2NjODY4Yy4uYjVj ZjU2N2JmOWUyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdXNiL2NvcmUvaHViLmgKPiArKysgYi9k cml2ZXJzL3VzYi9jb3JlL2h1Yi5oCj4gQEAgLTEwMCw2ICsxMDAsNyBAQCBzdHJ1Y3QgdXNiX3Bv cnQgewo+ICAJdW5zaWduZWQgaW50IGlzX3N1cGVyc3BlZWQ6MTsKPiAgCXVuc2lnbmVkIGludCB1 c2IzX2xwbV91MV9wZXJtaXQ6MTsKPiAgCXVuc2lnbmVkIGludCB1c2IzX2xwbV91Ml9wZXJtaXQ6 MTsKPiArCXVuc2lnbmVkIGludCBvY19jb3VudDsKPiAgfTsKPiAgCj4gICNkZWZpbmUgdG9fdXNi X3BvcnQoX2RldikgXAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9jb3JlL3BvcnQuYyBiL2Ry aXZlcnMvdXNiL2NvcmUvcG9ydC5jCj4gaW5kZXggMWEwMWU5YWQzODA0Li4wYmZlNDEwZWI4YTcg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy91c2IvY29yZS9wb3J0LmMKPiArKysgYi9kcml2ZXJzL3Vz Yi9jb3JlL3BvcnQuYwo+IEBAIC00MSw2ICs0MSwxNSBAQCBzdGF0aWMgc3NpemVfdCBjb25uZWN0 X3R5cGVfc2hvdyhzdHJ1Y3QgZGV2aWNlICpkZXYsCj4gIH0KPiAgc3RhdGljIERFVklDRV9BVFRS X1JPKGNvbm5lY3RfdHlwZSk7Cj4gIAo+ICtzdGF0aWMgc3NpemVfdCBvY19jb3VudF9zaG93KHN0 cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmljZV9hdHRyaWJ1dGUgKmF0dHIsCj4gKwkJCSAg ICAgY2hhciAqYnVmKQo+ICt7Cj4gKwlzdHJ1Y3QgdXNiX3BvcnQgKnBvcnRfZGV2ID0gdG9fdXNi X3BvcnQoZGV2KTsKPiArCj4gKwlyZXR1cm4gc3ByaW50ZihidWYsICIldVxuIiwgcG9ydF9kZXYt Pm9jX2NvdW50KTsKPiArfQo+ICtzdGF0aWMgREVWSUNFX0FUVFJfUk8ob2NfY291bnQpOwoKSSBk b24ndCBzZWUgd2hhdCB1c2Vyc3BhY2UgY2FuIGRvIHdpdGggdGhpcyBudW1iZXIsIGFzIHRoZXJl J3Mgbm90IG11Y2gKaXQgY2FuIGRvIHdpdGggaXQuCgp0aGFua3MsCgpncmVnIGstaAotLS0KVG8g dW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxp bnV4LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5l bC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpv cmRvbW8taW5mby5odG1sCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-389044-1519055973-2-2074705152406870987 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1519055972; b=MowV572k6tYecqqAZoFnAHZRbsz7s//A6X7CDLme4L06RWN 5Qcbc10EpZbmF+32viXjyHKMweSjIyCH3VQtvg7ZBX80CMsqVslZDcJ9Ymwxv9N1 qY5vXqHKl7upUADmy4py0+6XgwcV69uU0Nrpk0aqqEqfn9HQs/VQxbifq9kPDe3/ gdxD4VVJCqAF9TjsSltvQyID3Ye4UGZjJEKYk4GZPabvnAVRdMpxOs0hAaswgHQP 3HAUTmiuGjgRwHcUZc6Av+XeRZd3bs5GeM2cqx8V9lh2pqd9bSHBBAhMuhbomOJJ UkIWMyJ4sFiYSAwTniXaZcGwrhJhrU7H5dWm2DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=arctest; t=1519055972; bh=ccQOfmvFcuo65UeTR0sAFn8gbU yfJSzGOLlhpmXgLv0=; b=C+glIqE+2uVlRU7ExAZF/H27oMLdbp6KsbTagrB03b /sZ8BstWARbe5hajGCks8T2QBmztyOeZq2ag1zl0kZ0Sc9WwOy5pAb24IBbP366m GwtH5KNp7FcJXhwgVzoIM3nC4FlEx7pMni4GKr4y9Co6N1KJWow0HoYgrbaBLD3L XbDgZra4xo67whuDBzOUNS9c4Kx+8+xx/MF7dxTVmzAmPreZHnLH0V9YGV7cOJ9I LQMxfele4bSHKkjtcJxnFTAAp8alp2p3fvHDzXaWYfZTxs4yxgrbKTlY4/YNVLyQ Chh5nF6I9no/agSFXYHyF2a+ljw6CgX+A79CGUQPszoQ== ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753142AbeBSP7S (ORCPT ); Mon, 19 Feb 2018 10:59:18 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:47768 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752645AbeBSP7R (ORCPT ); Mon, 19 Feb 2018 10:59:17 -0500 Date: Mon, 19 Feb 2018 16:59:14 +0100 From: Greg KH To: Richard Leitner Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stern@rowland.harvard.edu, linux@roeck-us.net, mathias.nyman@linux.intel.com, johan@kernel.org, felipe.balbi@linux.intel.com, ekorenevsky@gmail.com, peter.chen@nxp.com, drake@endlessm.com, joe@perches.com, Richard Leitner Subject: Re: [PATCH] usb: core: introduce per-port over-current counters Message-ID: <20180219155914.GA23577@kroah.com> References: <20180219120107.20434-1-dev@g0hl1n.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180219120107.20434-1-dev@g0hl1n.net> User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, Feb 19, 2018 at 01:01:07PM +0100, Richard Leitner wrote: > From: Richard Leitner > > For some userspace applications information on the number of > over-current conditions at specific USB hub ports is relevant. Therefore > introduce a oc_counter in the usb port struct which is exported via > sysfs. > > Signed-off-by: Richard Leitner > --- > Tested on an i.MX6DL based board. > --- > drivers/usb/core/hub.c | 4 +++- > drivers/usb/core/hub.h | 1 + > drivers/usb/core/port.c | 10 ++++++++++ > 3 files changed, 14 insertions(+), 1 deletion(-) When you add/remove/modify a sysfs attribute, you always have to document in Documentation/ABI/ > > diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c > index c5c1f6cf3228..448fba1e1827 100644 > --- a/drivers/usb/core/hub.c > +++ b/drivers/usb/core/hub.c > @@ -5104,8 +5104,10 @@ static void port_event(struct usb_hub *hub, int port1) > > if (portchange & USB_PORT_STAT_C_OVERCURRENT) { > u16 status = 0, unused; > + port_dev->oc_count++; > > - dev_dbg(&port_dev->dev, "over-current change\n"); > + dev_dbg(&port_dev->dev, "over-current change #%u\n", > + port_dev->oc_count); > usb_clear_port_feature(hdev, port1, > USB_PORT_FEAT_C_OVER_CURRENT); > msleep(100); /* Cool down */ > diff --git a/drivers/usb/core/hub.h b/drivers/usb/core/hub.h > index 2a700ccc868c..b5cf567bf9e2 100644 > --- a/drivers/usb/core/hub.h > +++ b/drivers/usb/core/hub.h > @@ -100,6 +100,7 @@ struct usb_port { > unsigned int is_superspeed:1; > unsigned int usb3_lpm_u1_permit:1; > unsigned int usb3_lpm_u2_permit:1; > + unsigned int oc_count; > }; > > #define to_usb_port(_dev) \ > diff --git a/drivers/usb/core/port.c b/drivers/usb/core/port.c > index 1a01e9ad3804..0bfe410eb8a7 100644 > --- a/drivers/usb/core/port.c > +++ b/drivers/usb/core/port.c > @@ -41,6 +41,15 @@ static ssize_t connect_type_show(struct device *dev, > } > static DEVICE_ATTR_RO(connect_type); > > +static ssize_t oc_count_show(struct device *dev, struct device_attribute *attr, > + char *buf) > +{ > + struct usb_port *port_dev = to_usb_port(dev); > + > + return sprintf(buf, "%u\n", port_dev->oc_count); > +} > +static DEVICE_ATTR_RO(oc_count); I don't see what userspace can do with this number, as there's not much it can do with it. thanks, greg k-h