From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:58030 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752775AbeBSQ0u (ORCPT ); Mon, 19 Feb 2018 11:26:50 -0500 Date: Mon, 19 Feb 2018 17:26:51 +0100 From: Greg KH To: "Naveen N. Rao" Cc: Benjamin Herrenschmidt , Michael Ellerman , stable@vger.kernel.org Subject: Re: [PATCH v4.14 stable] powerpc: Fix DABR match on hash based Message-ID: <20180219162651.GA26692@kroah.com> References: <20180216095453.22636-1-naveen.n.rao@linux.vnet.ibm.com> <1518776444.nn0lqj1fi6.naveen@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1518776444.nn0lqj1fi6.naveen@linux.ibm.com> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Feb 16, 2018 at 03:51:40PM +0530, Naveen N. Rao wrote: > Naveen N. Rao wrote: > > From: Benjamin Herrenschmidt > > > > Commit 398a719d34a1 ("powerpc/mm: Update bits used to skip hash_page") > > mistakenly dropped the DSISR_DABRMATCH bit from the mask of bit tested > > to skip trying to hash a page. > > > > As a result, the DABR matches would no longer be detected. > > > > This adds it back. We open code it in the 2 places where it matters > > rather than fold it into DSISR_BAD_FAULT_32S/64S because this isn't > > technically a bad fault and while we would never hit it with the > > current code, I prefer if page_fault_is_bad() didn't trigger on these. > > > > Fixes: 398a719d34a1 ("powerpc/mm: Update bits used to skip hash_page") > > Cc: stable@vger.kernel.org # v4.14 > > Tested-by: Pedro Miraglia Franco de Carvalho > > Signed-off-by: Benjamin Herrenschmidt > > Not quite sure if this is required, but: > Signed-off-by: Naveen N. Rao Thanks, now queued up. greg k-h