From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:38874 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753142AbeBSQsy (ORCPT ); Mon, 19 Feb 2018 11:48:54 -0500 Date: Mon, 19 Feb 2018 17:44:38 +0100 From: Greg Kroah-Hartman To: Takashi Iwai Cc: Andres Bertens , ben@decadent.org.uk, stable@vger.kernel.org Subject: Re: [PATCH v4.4.x] ALSA: seq: Fix regression by incorrect ioctl_mutex usages Message-ID: <20180219164438.GA25145@kroah.com> References: <20180219161601.24110-1-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180219161601.24110-1-tiwai@suse.de> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Feb 19, 2018 at 05:16:01PM +0100, Takashi Iwai wrote: > This is the revised backport of the upstream commit > b3defb791b26ea0683a93a4f49c77ec45ec96f10 > > We had another backport (e.g. 623e5c8ae32b in 4.4.115), but it applies > the new mutex also to the code paths that are invoked via faked > kernel-to-kernel ioctls. As reported recently, this leads to a > deadlock at suspend (or other scenarios triggering the kernel > sequencer client). > > This patch addresses the issue by taking the mutex only in the code > paths invoked by user-space, just like the original fix patch does. > > Reported-and-tested-by: Andres Bertens > Signed-off-by: Takashi Iwai > --- > > Tagged as 4.4.x, but should be applied to other older kernels, too. > > sound/core/seq/seq_clientmgr.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) Thanks for this, now queued up. greg k-h