All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: [PATCH 1/2] arm64: dts: rockchip: move rk3399-sapphire i2s2 to daughterboard
Date: Tue, 20 Feb 2018 00:11:01 +0100	[thread overview]
Message-ID: <20180219231102.9090-1-vicencb@gmail.com> (raw)
In-Reply-To: <3840224.sEPfbROKII@phil>

The i2s2 drives the HDMI audio, which has the connector on the daughterboard.

Signed-off-by: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
Hi Heiko,

I have tested your patches on stable Linux 4.15.4 and worked fine.
There are only two missing bits: the power-button and the HDMI audio.
With this two extra patches, I have been able to test the power button
and it worked fine.
The HDMI audio was not working before nor after, but, the TRM says that
i2s2 is the audio source for the HDMI port.

Regards, Vicente.

 arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts | 5 -----
 arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi          | 5 +++++
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts b/arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts
index b7bd88fb3ae3..6027846ffd3e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts
@@ -207,11 +207,6 @@
 	status = "okay";
 };
 
-&i2s2 {
-	#sound-dai-cells = <0>;
-	status = "okay";
-};
-
 &pinctrl {
 	buttons {
 		pwr_btn: pwr-btn {
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
index 0f873c897d0d..21b05601f04a 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
@@ -440,6 +440,11 @@
 	status = "okay";
 };
 
+&i2s2 {
+	#sound-dai-cells = <0>;
+	status = "okay";
+};
+
 &io_domains {
 	status = "okay";
 
-- 
2.16.2

  parent reply	other threads:[~2018-02-19 23:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAAMcf8CY1m+998+GpD2wOfAZb=oZNkL2GqYu_o5piGEh76uoYw@mail.gmail.com>
     [not found] ` <CAAMcf8CY1m+998+GpD2wOfAZb=oZNkL2GqYu_o5piGEh76uoYw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-19  8:15   ` [PATCH 1/2] arm64: dts: rockchip: move rk3399-sapphire sdio to excavator baseboard Heiko Stuebner
2018-02-19  8:15     ` Heiko Stuebner
2018-02-19  8:16     ` [PATCH 2/2] arm64: dts: rockchip: add a standalone version of the rk3399 sapphire Heiko Stuebner
2018-02-19  8:16       ` Heiko Stuebner
2018-02-19 20:42       ` Rob Herring
2018-02-19 20:42         ` Rob Herring
2018-02-19 23:11     ` Vicente Bergas [this message]
     [not found]       ` <20180219231102.9090-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-02-19 23:11         ` [PATCH 2/2] arm64: dts: rockchip: move rk3399-sapphire pwr_btn to daughterboard Vicente Bergas
2018-02-20  9:37         ` [PATCH 1/2] arm64: dts: rockchip: move rk3399-sapphire i2s2 " Heiko Stuebner
2018-02-26 18:57     ` [PATCH] arm64: dts: rockchip: move rk3399-sapphire PCIe to excavator baseboard Vicente Bergas
     [not found]       ` <20180226185721.2582-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-02-27  6:23         ` Shawn Lin
     [not found]           ` <86b701f0-899f-acf6-ad32-541dc888ddfe-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-02-27 18:28             ` [PATCH] arm64: dts: rockchip: remove PCIe assigned-clocks in " Vicente Bergas
     [not found]               ` <20180227182822.5048-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-02-28  1:47                 ` Shawn Lin
2018-02-28 13:18         ` [PATCH] arm64: dts: rockchip: move rk3399-sapphire PCIe to " Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180219231102.9090-1-vicencb@gmail.com \
    --to=vicencb-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.