From mboxrd@z Thu Jan 1 00:00:00 1970 From: vilhelm.gray@gmail.com (William Breathitt Gray) Date: Tue, 20 Feb 2018 07:49:55 -0500 Subject: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem In-Reply-To: <20180220104542.32286-1-marcus.folkesson@gmail.com> References: <20180220104542.32286-1-marcus.folkesson@gmail.com> Message-ID: <20180220124955.GA17814@sophia> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote: >- Add SPDX identifier >- Remove boiler plate license text >- If MODULE_LICENSE and boiler plate does not match, go for boiler plate > license > >Signed-off-by: Marcus Folkesson >Acked-by: Adam Thomson >Acked-by: Charles Keepax >Acked-by: Nicolas Ferre >Acked-by: Michal Simek >--- > >Notes: > v2: > - Put back removed copyright texts for meson_gxbb_wdt and coh901327_wdt > - Change to BSD-3-Clause for meson_gxbb_wdt > v1: Please have an extra look at meson_gxbb_wdt.c [...] >diff --git a/drivers/watchdog/ebc-c384_wdt.c b/drivers/watchdog/ebc-c384_wdt.c >index 2170b275ea01..c173b6f5c866 100644 >--- a/drivers/watchdog/ebc-c384_wdt.c >+++ b/drivers/watchdog/ebc-c384_wdt.c >@@ -1,15 +1,8 @@ >+// SPDX-License-Identifier: GPL-2.0 > /* > * Watchdog timer driver for the WinSystems EBC-C384 > * Copyright (C) 2016 William Breathitt Gray > * >- * This program is free software; you can redistribute it and/or modify >- * it under the terms of the GNU General Public License, version 2, as >- * published by the Free Software Foundation. >- * >- * This program is distributed in the hope that it will be useful, but >- * WITHOUT ANY WARRANTY; without even the implied warranty of >- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >- * General Public License for more details. > */ > #include > #include I have no problem with adding a SPDX line to the top of this file, but use "SPDX-License-Identifier: GPL-2.0-only" as I was very intentional with the selection of GPL version 2 only when I published this code. Furthermore, please do not remove the existing copyright text; although it's just boilerplate for some, I was careful with the selection of these words, and I worry the SPDX line only -- despite its useful conciseness -- may lead to misunderstandings about my intentioned license for this code. For the time being, I can't Ack this patch with the changes it makes currently: Nacked-by: William Breathitt Gray William Breathitt Gray From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 20 Feb 2018 13:50:20 +0100 (CET) Received: from mail-yb0-x243.google.com ([IPv6:2607:f8b0:4002:c09::243]:40550 "EHLO mail-yb0-x243.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23994684AbeBTMuKlfhP1 (ORCPT ); Tue, 20 Feb 2018 13:50:10 +0100 Received: by mail-yb0-x243.google.com with SMTP id i15-v6so3884403ybg.7 for ; Tue, 20 Feb 2018 04:50:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=byKJGfnbKvzJbMtIXntFX85ARosKvyaw6K0Z7kupIOw=; b=Wlz2tyHkAN5NzEQXJxrw67mC7k2DcnkqBE0GhPaD0bzzKWw69+hzpf5j5R8w4Pi5MK XDQBLTRars5G9DojsH7zWd0AtPGVjwIPDyx6n7d6AILf7vx7BMyLtBERQeLwgdi0i472 oDPyQWd8ekkLbOftCvrbsJXpdV5OxRU6e/3p/Rjb183g+BapeACCTdhgXz1I3+ula4RV E4dLpHJ4+oJ3K1j6HmqUL8S+UF6gIXO6z2VLgH7Egdcm4Fbbij18mrA7tZBEiar7e4vV Ozq253WvCyXIN1hqqpyzVu/YDwmnx6ZB6m769VFUKwDTB9jB1jIPiv9+MpKFkjQJlHyK Y7Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=byKJGfnbKvzJbMtIXntFX85ARosKvyaw6K0Z7kupIOw=; b=crZ1pLzHbvgrKa2raWZOLR/MwH9P0SmmgdmhUNxzUbRlYO+tOnNs5sd96D6vaCrjuM sv9hV3Ph2BqmU6etgeaUOoxhUx1dKUzFGOzQgyejjz1inL5YoWGB8PoHPcFGepYd0//I bBY/C3MFhsvzZ2ZIPJu8I84W9DR0RUfB8yJFvZXsGAv0ywtOxKnTxlvCnKBTPB0HMGdV p+lhn3Lk7lk+c17EnygbvUN//2RO2MVCNgWO5ugmpcmoaq9tlk8QzFmyPnL3WRkJOWcl wf/MkRqfN+ju0rxzqBcWALOHBtgvr1Moefv4p7Bd6cv2ocwuvge0fLXyO8TeeeCrHyxc Zo8g== X-Gm-Message-State: APf1xPCN+9W7FdFqWqKo0qDjhH390E3yaFAg4SQnloybsi7UuG385/XZ y1tY8WSZBoinGKHwGF8NKYw= X-Google-Smtp-Source: AH8x224mDgEi0DdQJXTFPsuPWY33qQvpyHGIwxfBe1gyHC/DMSyijV2IgzAJH7E3frSSyKGv9XQMSA== X-Received: by 10.37.200.194 with SMTP id y185mr12887689ybf.243.1519131004398; Tue, 20 Feb 2018 04:50:04 -0800 (PST) Received: from sophia ([72.188.97.40]) by smtp.gmail.com with ESMTPSA id m184sm9876557ywe.98.2018.02.20.04.50.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Feb 2018 04:50:03 -0800 (PST) Date: Tue, 20 Feb 2018 07:49:55 -0500 From: William Breathitt Gray To: Marcus Folkesson Cc: Wim Van Sebroeck , Guenter Roeck , Joel Stanley , Nicolas Ferre , Alexandre Belloni , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Eric Anholt , Stefan Wahren , Linus Walleij , Support Opensource , Baruch Siach , Jimmy Vance , Keguang Zhang , Joachim Eastwood , Tomas Winkler , Johannes Thumshirn , Andreas Werner , Carlo Caione , Kevin Hilman , Matthias Brugger , Wan ZongShun , Michal Simek , Vladimir Zapolskiy , Sylvain Lemieux , Kukjin Kim , Krzysztof Kozlowski , Zwane Mwaikambo , Jim Cromie , Barry Song , Patrice Chotard , Maxime Ripard , Chen-Yu Tsai , Marc Gonzalez , Mans Rullgard , Thierry Reding , Jonathan Hunter , Masahiro Yamada , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Jun Nie , Baoyou Xie , Shawn Guo , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, adi-buildroot-devel@lists.sourceforge.net, linux-mips@linux-mips.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, patches@opensource.cirrus.com Subject: Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem Message-ID: <20180220124955.GA17814@sophia> References: <20180220104542.32286-1-marcus.folkesson@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180220104542.32286-1-marcus.folkesson@gmail.com> User-Agent: Mutt/1.9.2 (2017-12-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 62647 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: vilhelm.gray@gmail.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote: >- Add SPDX identifier >- Remove boiler plate license text >- If MODULE_LICENSE and boiler plate does not match, go for boiler plate > license > >Signed-off-by: Marcus Folkesson >Acked-by: Adam Thomson >Acked-by: Charles Keepax >Acked-by: Nicolas Ferre >Acked-by: Michal Simek >--- > >Notes: > v2: > - Put back removed copyright texts for meson_gxbb_wdt and coh901327_wdt > - Change to BSD-3-Clause for meson_gxbb_wdt > v1: Please have an extra look at meson_gxbb_wdt.c [...] >diff --git a/drivers/watchdog/ebc-c384_wdt.c b/drivers/watchdog/ebc-c384_wdt.c >index 2170b275ea01..c173b6f5c866 100644 >--- a/drivers/watchdog/ebc-c384_wdt.c >+++ b/drivers/watchdog/ebc-c384_wdt.c >@@ -1,15 +1,8 @@ >+// SPDX-License-Identifier: GPL-2.0 > /* > * Watchdog timer driver for the WinSystems EBC-C384 > * Copyright (C) 2016 William Breathitt Gray > * >- * This program is free software; you can redistribute it and/or modify >- * it under the terms of the GNU General Public License, version 2, as >- * published by the Free Software Foundation. >- * >- * This program is distributed in the hope that it will be useful, but >- * WITHOUT ANY WARRANTY; without even the implied warranty of >- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >- * General Public License for more details. > */ > #include > #include I have no problem with adding a SPDX line to the top of this file, but use "SPDX-License-Identifier: GPL-2.0-only" as I was very intentional with the selection of GPL version 2 only when I published this code. Furthermore, please do not remove the existing copyright text; although it's just boilerplate for some, I was careful with the selection of these words, and I worry the SPDX line only -- despite its useful conciseness -- may lead to misunderstandings about my intentioned license for this code. For the time being, I can't Ack this patch with the changes it makes currently: Nacked-by: William Breathitt Gray William Breathitt Gray From mboxrd@z Thu Jan 1 00:00:00 1970 From: William Breathitt Gray Subject: Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem Date: Tue, 20 Feb 2018 07:49:55 -0500 Message-ID: <20180220124955.GA17814@sophia> References: <20180220104542.32286-1-marcus.folkesson@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180220104542.32286-1-marcus.folkesson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Marcus Folkesson Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, Baruch Siach , Mans Rullgard , Maxime Ripard , Benjamin Herrenschmidt , Linus Walleij , Patrice Chotard , Eric Anholt , Thierry Reding , Alexandre Belloni , Michael Ellerman , Baoyou Xie , Stefan Wahren , Florian Fainelli , Kevin Hilman , Michal Simek , Krzysztof Kozlowski , Jonathan Hunter , Chen-Yu Tsai , Kukjin Kim , bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, Joel Stanley , Sylvain Lemieux List-Id: linux-mediatek@lists.infradead.org On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote: >- Add SPDX identifier >- Remove boiler plate license text >- If MODULE_LICENSE and boiler plate does not match, go for boiler plate > license > >Signed-off-by: Marcus Folkesson >Acked-by: Adam Thomson >Acked-by: Charles Keepax >Acked-by: Nicolas Ferre >Acked-by: Michal Simek >--- > >Notes: > v2: > - Put back removed copyright texts for meson_gxbb_wdt and coh901327_wdt > - Change to BSD-3-Clause for meson_gxbb_wdt > v1: Please have an extra look at meson_gxbb_wdt.c [...] >diff --git a/drivers/watchdog/ebc-c384_wdt.c b/drivers/watchdog/ebc-c384_wdt.c >index 2170b275ea01..c173b6f5c866 100644 >--- a/drivers/watchdog/ebc-c384_wdt.c >+++ b/drivers/watchdog/ebc-c384_wdt.c >@@ -1,15 +1,8 @@ >+// SPDX-License-Identifier: GPL-2.0 > /* > * Watchdog timer driver for the WinSystems EBC-C384 > * Copyright (C) 2016 William Breathitt Gray > * >- * This program is free software; you can redistribute it and/or modify >- * it under the terms of the GNU General Public License, version 2, as >- * published by the Free Software Foundation. >- * >- * This program is distributed in the hope that it will be useful, but >- * WITHOUT ANY WARRANTY; without even the implied warranty of >- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >- * General Public License for more details. > */ > #include > #include I have no problem with adding a SPDX line to the top of this file, but use "SPDX-License-Identifier: GPL-2.0-only" as I was very intentional with the selection of GPL version 2 only when I published this code. Furthermore, please do not remove the existing copyright text; although it's just boilerplate for some, I was careful with the selection of these words, and I worry the SPDX line only -- despite its useful conciseness -- may lead to misunderstandings about my intentioned license for this code. For the time being, I can't Ack this patch with the changes it makes currently: Nacked-by: William Breathitt Gray William Breathitt Gray