From mboxrd@z Thu Jan 1 00:00:00 1970 From: marcus.folkesson@gmail.com (Marcus Folkesson) Date: Tue, 20 Feb 2018 14:21:03 +0100 Subject: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem In-Reply-To: <20180220124955.GA17814@sophia> References: <20180220104542.32286-1-marcus.folkesson@gmail.com> <20180220124955.GA17814@sophia> Message-ID: <20180220132103.GD24311@gmail.com> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org Hello William, On Tue, Feb 20, 2018 at 07:49:55AM -0500, William Breathitt Gray wrote: > On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote: > >- Add SPDX identifier > >- Remove boiler plate license text > >- If MODULE_LICENSE and boiler plate does not match, go for boiler plate > > license > > > >Signed-off-by: Marcus Folkesson > >Acked-by: Adam Thomson > >Acked-by: Charles Keepax > >Acked-by: Nicolas Ferre > >Acked-by: Michal Simek > >--- > > > >Notes: > > v2: > > - Put back removed copyright texts for meson_gxbb_wdt and coh901327_wdt > > - Change to BSD-3-Clause for meson_gxbb_wdt > > v1: Please have an extra look at meson_gxbb_wdt.c > > [...] > > >diff --git a/drivers/watchdog/ebc-c384_wdt.c b/drivers/watchdog/ebc-c384_wdt.c > >index 2170b275ea01..c173b6f5c866 100644 > >--- a/drivers/watchdog/ebc-c384_wdt.c > >+++ b/drivers/watchdog/ebc-c384_wdt.c > >@@ -1,15 +1,8 @@ > >+// SPDX-License-Identifier: GPL-2.0 > > /* > > * Watchdog timer driver for the WinSystems EBC-C384 > > * Copyright (C) 2016 William Breathitt Gray > > * > >- * This program is free software; you can redistribute it and/or modify > >- * it under the terms of the GNU General Public License, version 2, as > >- * published by the Free Software Foundation. > >- * > >- * This program is distributed in the hope that it will be useful, but > >- * WITHOUT ANY WARRANTY; without even the implied warranty of > >- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > >- * General Public License for more details. > > */ > > #include > > #include Thank you for your feedback! > > I have no problem with adding a SPDX line to the top of this file, but > use "SPDX-License-Identifier: GPL-2.0-only" as I was very intentional > with the selection of GPL version 2 only when I published this code. SPDX-License-Identifier: GPL-2.0 Is GPL-2.0 only [1], so it respects your choice of license. > > Furthermore, please do not remove the existing copyright text; although The copyright text: Copyright (C) 2016 William Breathitt Gray Is still in the file. > it's just boilerplate for some, I was careful with the selection of > these words, and I worry the SPDX line only -- despite its useful > conciseness -- may lead to misunderstandings about my intentioned > license for this code. I'm not sure I understand your concerns here, the SPDX identifier is a shorthand for the GPL 2.0 only license. See [1] - Linux kernel licensing rules. One of the biggest benefits with SPDX identifier is that it is hard to verify boiler plate licenses due to formatting, types, different formulations and so on. If still worrying, I think we could keep the license text as well. > > For the time being, I can't Ack this patch with the changes it makes > currently: > > Nacked-by: William Breathitt Gray > > William Breathitt Gray Please let me know if I got you wrong at some point. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst Best regards Marcus Folkesson -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 20 Feb 2018 14:21:24 +0100 (CET) Received: from mail-lf0-x241.google.com ([IPv6:2a00:1450:4010:c07::241]:39251 "EHLO mail-lf0-x241.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23994686AbeBTNVQURrC1 (ORCPT ); Tue, 20 Feb 2018 14:21:16 +0100 Received: by mail-lf0-x241.google.com with SMTP id h78so4132103lfg.6 for ; Tue, 20 Feb 2018 05:21:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vi5zczWEWi6koQgg1e50mnGe9xDiyeRRBUwPaQ5+9lc=; b=gsK+B3c2BlS9/pTPlGKwjWhTD6X8EaA0PSytVK2uoiDX+OcvDaT+HkbamYj1cvWlzD 4/pEGlGI4Kka+y2naVjL8NNfBbi0RmWZM2AMQw//vLK1yxHXXIc3faAHJJ5GunyiL2v0 17B8qk91TRGMnBQeRlmV9yZ5EU4eo3jxEUaxoSrTnOaqtQ9WUtSNHzlx/an6hYUVmEe8 IdkUfkY3TJJuBgEFIUOIXQrI1L4ULvkJLKvHSO3g+n0kZGI3yGP/HjAiHMeV/UamiuLH 5OORWQfiWk+5Xbekxh5z18a2nKF0BK4R/mna6WkdwpFzDuk+vZG4lFNEJjykELRdlfw7 ek3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vi5zczWEWi6koQgg1e50mnGe9xDiyeRRBUwPaQ5+9lc=; b=uhJWiU+WTJa/NJjcglkLSDIBjc2Hymqq/d54I5ynnPevz87my67yYbhVM0QhxMZEnT PanRqiUldCTlT6ZSR8SepJqH6r+N/SfhaXtZ/dSpN9iNOwzxZityyn2jTy4eOS5XhyOO MU44vy1UvnfQe9S+DS8tX2SPfWVWApuP/1Os0O1Yb1EfVr/dMe3AloPhJb5fe+8LHdBb UHbnllyswsVJV7eOvwjGs+bPI6cT+WS+snr3WtzxC5v7uGa0keRmWUrKJCNoKLRZIFph 2CIxps/Gxn+CEo2r1LjlcvC8SznrXY8cZ9kRd6PYRqmXgiE0I9FUJ9ndc1tHEAjwWahF uXWA== X-Gm-Message-State: APf1xPCGdremx5l96y7eq+n06hXCFYLDkoYHoW9/z2cMQu9qhLwYcY6T naAUD9OMPxBLYBTiHuOQygY= X-Google-Smtp-Source: AH8x225TJN76c2wZCrkGPQM8ewWm0peupuMMm1yi2h5LFwL8O5t6nRk2Bc+o5agxP0v90wCjiohdcw== X-Received: by 10.25.202.9 with SMTP id a9mr13122998lfg.144.1519132870545; Tue, 20 Feb 2018 05:21:10 -0800 (PST) Received: from gmail.com (c-2ec27091-74736162.cust.telenor.se. [46.194.112.145]) by smtp.gmail.com with ESMTPSA id d77sm5371221ljd.31.2018.02.20.05.21.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Feb 2018 05:21:09 -0800 (PST) Date: Tue, 20 Feb 2018 14:21:03 +0100 From: Marcus Folkesson To: William Breathitt Gray Cc: Wim Van Sebroeck , Guenter Roeck , Joel Stanley , Nicolas Ferre , Alexandre Belloni , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Eric Anholt , Stefan Wahren , Linus Walleij , Support Opensource , Baruch Siach , Jimmy Vance , Keguang Zhang , Joachim Eastwood , Tomas Winkler , Johannes Thumshirn , Andreas Werner , Carlo Caione , Kevin Hilman , Matthias Brugger , Wan ZongShun , Michal Simek , Vladimir Zapolskiy , Sylvain Lemieux , Kukjin Kim , Krzysztof Kozlowski , Zwane Mwaikambo , Jim Cromie , Barry Song , Patrice Chotard , Maxime Ripard , Chen-Yu Tsai , Marc Gonzalez , Mans Rullgard , Thierry Reding , Jonathan Hunter , Masahiro Yamada , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Jun Nie , Baoyou Xie , Shawn Guo , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, adi-buildroot-devel@lists.sourceforge.net, linux-mips@linux-mips.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, patches@opensource.cirrus.com Subject: Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem Message-ID: <20180220132103.GD24311@gmail.com> References: <20180220104542.32286-1-marcus.folkesson@gmail.com> <20180220124955.GA17814@sophia> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MZf7D3rAEoQgPanC" Content-Disposition: inline In-Reply-To: <20180220124955.GA17814@sophia> User-Agent: Mutt/1.9.1 (2017-09-22) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 62648 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: marcus.folkesson@gmail.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips --MZf7D3rAEoQgPanC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello William, On Tue, Feb 20, 2018 at 07:49:55AM -0500, William Breathitt Gray wrote: > On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote: > >- Add SPDX identifier > >- Remove boiler plate license text > >- If MODULE_LICENSE and boiler plate does not match, go for boiler plate > > license > > > >Signed-off-by: Marcus Folkesson > >Acked-by: Adam Thomson > >Acked-by: Charles Keepax > >Acked-by: Nicolas Ferre > >Acked-by: Michal Simek > >--- > > > >Notes: > > v2: > > - Put back removed copyright texts for meson_gxbb_wdt and coh901327= _wdt > > - Change to BSD-3-Clause for meson_gxbb_wdt > > v1: Please have an extra look at meson_gxbb_wdt.c >=20 > [...] >=20 > >diff --git a/drivers/watchdog/ebc-c384_wdt.c b/drivers/watchdog/ebc-c384= _wdt.c > >index 2170b275ea01..c173b6f5c866 100644 > >--- a/drivers/watchdog/ebc-c384_wdt.c > >+++ b/drivers/watchdog/ebc-c384_wdt.c > >@@ -1,15 +1,8 @@ > >+// SPDX-License-Identifier: GPL-2.0 > > /* > > * Watchdog timer driver for the WinSystems EBC-C384 > > * Copyright (C) 2016 William Breathitt Gray > > * > >- * This program is free software; you can redistribute it and/or modify > >- * it under the terms of the GNU General Public License, version 2, as > >- * published by the Free Software Foundation. > >- * > >- * This program is distributed in the hope that it will be useful, but > >- * WITHOUT ANY WARRANTY; without even the implied warranty of > >- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > >- * General Public License for more details. > > */ > > #include > > #include Thank you for your feedback! >=20 > I have no problem with adding a SPDX line to the top of this file, but > use "SPDX-License-Identifier: GPL-2.0-only" as I was very intentional > with the selection of GPL version 2 only when I published this code. SPDX-License-Identifier: GPL-2.0 Is GPL-2.0 only [1], so it respects your choice of license. >=20 > Furthermore, please do not remove the existing copyright text; although The copyright text: Copyright (C) 2016 William Breathitt Gray Is still in the file. > it's just boilerplate for some, I was careful with the selection of > these words, and I worry the SPDX line only -- despite its useful > conciseness -- may lead to misunderstandings about my intentioned > license for this code. I'm not sure I understand your concerns here, the SPDX identifier is a shorthand for the GPL 2.0 only license. See [1] - Linux kernel licensing = rules. One of the biggest benefits with SPDX identifier is that it is hard to veri= fy boiler plate licenses due to formatting, types, different formulations and = so on. If still worrying, I think we could keep the license text as well. >=20 > For the time being, I can't Ack this patch with the changes it makes > currently: >=20 > Nacked-by: William Breathitt Gray >=20 > William Breathitt Gray Please let me know if I got you wrong at some point. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree= /Documentation/process/license-rules.rst Best regards Marcus Folkesson --MZf7D3rAEoQgPanC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEBVGi6LZstU1kwSxliIBOb1ldUjIFAlqMILgACgkQiIBOb1ld UjK9Ag//RFYuvmLZSH6GnP5gGk0/GBMTVPPr95tPUKj2LxlQrPBqoWqCdFXnuHf1 da0hos+DEBo8xaRPtbvitCeWo3m3MgCG4RTCU/HKqTinyis52XV95y3YXGrMT6T9 kH/hukr9/oIIlKpz5bAIR9vfwo2hd2M1KkBsc5hYhloWY83jbuYTAEUcmogipLAu 5pPJIHWig0yHga6nTaUxwhyVShgX0qSiYfHihliemt+9reU5jtLDeDc3u5UrGiTg 6E2GeQYv9mA07s9xzWdHTAoyUx3sMCwAJ65F6u4E89uiQjVr7KFz7HvlMJswnehn xWqnN8L2fNNaUxxDrJ7aEwPy1dMbiVjxdOoIl9ivc4mDe+DpD6N0bxPEk6bj1hbR pMLtfoBZHQZok1lzvQk8B0EPvnfOEJsntjsb09R6io+28dU+z1KlZwFHZ7PJ4g0l lnb64yyNupUMsG7zRyAC8Hq5bJbFGf0aZMOHD/NuZul/2+k3cNuUJUVUqV2wndyk VduFlrBiDRk9mjFPnqlsnOgFVteAROyineIzMEeOPio05wMQ7/KJRKLxxL8TZNmw j6TtRSFPIZZTFmpR8Xu5Ezxm32qb/5umECl2WqPkauzEWL3erJxngioWLp2q7vTy 988Zz12kOcwGHl6N2F9FCbeoO4z8Bj9zSZMYezU/f3LR+SLaAy0= =96Xu -----END PGP SIGNATURE----- --MZf7D3rAEoQgPanC-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcus Folkesson Subject: Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem Date: Tue, 20 Feb 2018 14:21:03 +0100 Message-ID: <20180220132103.GD24311@gmail.com> References: <20180220104542.32286-1-marcus.folkesson@gmail.com> <20180220124955.GA17814@sophia> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3831320097026872127==" Return-path: In-Reply-To: <20180220124955.GA17814@sophia> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: William Breathitt Gray Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, Baruch Siach , Mans Rullgard , Maxime Ripard , Benjamin Herrenschmidt , Linus Walleij , Patrice Chotard , Eric Anholt , Thierry Reding , Alexandre Belloni , Michael Ellerman , Baoyou Xie , Stefan Wahren , Florian Fainelli , Kevin Hilman , Michal Simek , Krzysztof Kozlowski , Jonathan Hunter , Chen-Yu Tsai , Kukjin Kim , bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, Joel Stanley , Sylvain Lemieux List-Id: linux-mediatek@lists.infradead.org --===============3831320097026872127== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MZf7D3rAEoQgPanC" Content-Disposition: inline --MZf7D3rAEoQgPanC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello William, On Tue, Feb 20, 2018 at 07:49:55AM -0500, William Breathitt Gray wrote: > On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote: > >- Add SPDX identifier > >- Remove boiler plate license text > >- If MODULE_LICENSE and boiler plate does not match, go for boiler plate > > license > > > >Signed-off-by: Marcus Folkesson > >Acked-by: Adam Thomson > >Acked-by: Charles Keepax > >Acked-by: Nicolas Ferre > >Acked-by: Michal Simek > >--- > > > >Notes: > > v2: > > - Put back removed copyright texts for meson_gxbb_wdt and coh901327= _wdt > > - Change to BSD-3-Clause for meson_gxbb_wdt > > v1: Please have an extra look at meson_gxbb_wdt.c >=20 > [...] >=20 > >diff --git a/drivers/watchdog/ebc-c384_wdt.c b/drivers/watchdog/ebc-c384= _wdt.c > >index 2170b275ea01..c173b6f5c866 100644 > >--- a/drivers/watchdog/ebc-c384_wdt.c > >+++ b/drivers/watchdog/ebc-c384_wdt.c > >@@ -1,15 +1,8 @@ > >+// SPDX-License-Identifier: GPL-2.0 > > /* > > * Watchdog timer driver for the WinSystems EBC-C384 > > * Copyright (C) 2016 William Breathitt Gray > > * > >- * This program is free software; you can redistribute it and/or modify > >- * it under the terms of the GNU General Public License, version 2, as > >- * published by the Free Software Foundation. > >- * > >- * This program is distributed in the hope that it will be useful, but > >- * WITHOUT ANY WARRANTY; without even the implied warranty of > >- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > >- * General Public License for more details. > > */ > > #include > > #include Thank you for your feedback! >=20 > I have no problem with adding a SPDX line to the top of this file, but > use "SPDX-License-Identifier: GPL-2.0-only" as I was very intentional > with the selection of GPL version 2 only when I published this code. SPDX-License-Identifier: GPL-2.0 Is GPL-2.0 only [1], so it respects your choice of license. >=20 > Furthermore, please do not remove the existing copyright text; although The copyright text: Copyright (C) 2016 William Breathitt Gray Is still in the file. > it's just boilerplate for some, I was careful with the selection of > these words, and I worry the SPDX line only -- despite its useful > conciseness -- may lead to misunderstandings about my intentioned > license for this code. I'm not sure I understand your concerns here, the SPDX identifier is a shorthand for the GPL 2.0 only license. See [1] - Linux kernel licensing = rules. One of the biggest benefits with SPDX identifier is that it is hard to veri= fy boiler plate licenses due to formatting, types, different formulations and = so on. If still worrying, I think we could keep the license text as well. >=20 > For the time being, I can't Ack this patch with the changes it makes > currently: >=20 > Nacked-by: William Breathitt Gray >=20 > William Breathitt Gray Please let me know if I got you wrong at some point. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree= /Documentation/process/license-rules.rst Best regards Marcus Folkesson --MZf7D3rAEoQgPanC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEBVGi6LZstU1kwSxliIBOb1ldUjIFAlqMILgACgkQiIBOb1ld UjK9Ag//RFYuvmLZSH6GnP5gGk0/GBMTVPPr95tPUKj2LxlQrPBqoWqCdFXnuHf1 da0hos+DEBo8xaRPtbvitCeWo3m3MgCG4RTCU/HKqTinyis52XV95y3YXGrMT6T9 kH/hukr9/oIIlKpz5bAIR9vfwo2hd2M1KkBsc5hYhloWY83jbuYTAEUcmogipLAu 5pPJIHWig0yHga6nTaUxwhyVShgX0qSiYfHihliemt+9reU5jtLDeDc3u5UrGiTg 6E2GeQYv9mA07s9xzWdHTAoyUx3sMCwAJ65F6u4E89uiQjVr7KFz7HvlMJswnehn xWqnN8L2fNNaUxxDrJ7aEwPy1dMbiVjxdOoIl9ivc4mDe+DpD6N0bxPEk6bj1hbR pMLtfoBZHQZok1lzvQk8B0EPvnfOEJsntjsb09R6io+28dU+z1KlZwFHZ7PJ4g0l lnb64yyNupUMsG7zRyAC8Hq5bJbFGf0aZMOHD/NuZul/2+k3cNuUJUVUqV2wndyk VduFlrBiDRk9mjFPnqlsnOgFVteAROyineIzMEeOPio05wMQ7/KJRKLxxL8TZNmw j6TtRSFPIZZTFmpR8Xu5Ezxm32qb/5umECl2WqPkauzEWL3erJxngioWLp2q7vTy 988Zz12kOcwGHl6N2F9FCbeoO4z8Bj9zSZMYezU/f3LR+SLaAy0= =96Xu -----END PGP SIGNATURE----- --MZf7D3rAEoQgPanC-- --===============3831320097026872127== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-mediatek mailing list Linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org http://lists.infradead.org/mailman/listinfo/linux-mediatek --===============3831320097026872127==--