From: Lina Iyer <ilina@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: andy.gross@linaro.org, david.brown@linaro.org,
sboyd@codeaurora.org, rnayak@codeaurora.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Mahesh Sivasubramanian <msivasub@codeaurora.org>
Subject: Re: [PATCH v3 2/2] dt-bindings: introduce Command DB for QCOM SoCs
Date: Tue, 20 Feb 2018 15:42:05 +0000 [thread overview]
Message-ID: <20180220154205.GC28504@codeaurora.org> (raw)
In-Reply-To: <20180219203106.mfzmxy42biwo33qj@rob-hp-laptop>
On Mon, Feb 19 2018 at 20:31 +0000, Rob Herring wrote:
>On Fri, Feb 16, 2018 at 03:46:14PM -0700, Lina Iyer wrote:
>> From: Mahesh Sivasubramanian <msivasub@codeaurora.org>
>>
>> +The devicetree representation of the command DB driver should be:
>
>Need to state this is a child of /reserved-memory
Yes, ofcourse. Will fix.
>
>> +
>> +PROPERTIES:
>
>Why the yelling? :)
>
Oops.
>> +- compatible:
>> + Usage: required
>> + Value type: <string>
>> + Definition: Should be "qcom,cmd-db"
>
>reg?
>
Yes.
Thanks Rob for the reveiw.
-- Lina
prev parent reply other threads:[~2018-02-20 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 22:46 [PATCH v3 0/2] drivers/qcom: add Command DB support Lina Iyer
2018-02-16 22:46 ` [PATCH v3 1/2] drivers: qcom: add command DB driver Lina Iyer
2018-02-16 22:46 ` [PATCH v3 2/2] dt-bindings: introduce Command DB for QCOM SoCs Lina Iyer
2018-02-19 20:31 ` Rob Herring
2018-02-20 15:42 ` Lina Iyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220154205.GC28504@codeaurora.org \
--to=ilina@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=msivasub@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.