From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] fix double ;;s in code Date: Tue, 20 Feb 2018 15:47:15 -0800 Message-ID: <20180220154715.2a8ecd75a1c2cc698baefd26@linux-foundation.org> References: <20180217211955.GE9640@amd> <187435d4-5017-edb5-9b6a-b433a148bfcc@c-s.fr> <20180219154135.GV22199@phenom.ffwll.local> <20180219193312.GA3709@amd> <87o9kkcck3.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <87o9kkcck3.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jani Nikula Cc: daniel.lezcano@linaro.org, narmstrong@baylibre.com, airlied@linux.ie, catalin.marinas@arm.com, Alexey.Brodkin@synopsys.com, will.deacon@arm.com, fbarrat@linux.vnet.ibm.com, oleg@redhat.com, paulus@ozlabs.org, yamada.masahiro@socionext.com, mhocko@suse.com, viresh.kumar@linaro.org, Pavel Machek , hpa@zytor.com, JinHuiEric.Huang@amd.com, Rex.Zhu@amd.com, elfring@users.sourceforge.net, scott.bauer@intel.com, linux-arm-kernel@lists.infradead.org, mpe@ellerman.id.au, x86@kernel.org, Wenjing.Liu@amd.com, linux@armlinux.org.uk, amd-gfx@lists.freedesktop.org, Ding.Wang@amd.com, aik@ozlabs.ru, wens@csie.org, mingo@redhat.com, vbabka@suse.cz, airlied@redhat.com, ruscur@russell.cc, shli@kernel.org, dan.carpenter@oracle.com, andresx7@gmail.com, linux-arm-msm@vger.kernel.org, axboe@kernel.dk, linux-efi@vger.kernel.org, alistair@popple.id.au, linuxppc-dev@lists.ozlabs.org List-Id: amd-gfx.lists.freedesktop.org T24gVHVlLCAyMCBGZWIgMjAxOCAxMDowMzo1NiArMDIwMCBKYW5pIE5pa3VsYSA8amFuaS5uaWt1 bGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKCj4gT24gTW9uLCAxOSBGZWIgMjAxOCwgUGF2ZWwg TWFjaGVrIDxwYXZlbEB1Y3cuY3o+IHdyb3RlOgo+ID4gT24gTW9uIDIwMTgtMDItMTkgMTY6NDE6 MzUsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPj4gWWVhaCwgcGxzIHNwbGl0IHRoaXMgaW50byBv bmUgcGF0Y2ggcGVyIGFyZWEsIHdpdGggYSBzdWl0YWJsZSBwYXRjaAo+ID4+IHN1YmplY3QgcHJl Zml4LiBMb29rIGF0IGdpdCBsb2cgb2YgZWFjaCBmaWxlIHRvIGdldCBhIGZlZWxpbmcgZm9yIHdo YXQncwo+ID4+IHRoZSBzdGFuZGFyZCBpbiBlYWNoIGFyZWEuCj4gPgo+ID4gWWVhaCBJIGNhbiBz cGVuZCBob3VyIHNwbGl0aW5nIGl0LCBhbmQgdGhlbiBwZW9wbGUgd2lsbCBpZ25vcmUgaXQKPiA+ IGFueXdheS4KPiA+Cj4gPiBJZiB5b3UgY2FyZSBhYm91dCBvbmUgb2YgdGhlIGZpbGVzIGJlaW5n IG1vZGlmaWVkLCBwbGVhc2UgZml4IHRoZQo+ID4gYnVnLCAiOzsiIGlzIGEgY2xlYXIgYnVnLgo+ ID4KPiA+IElmIHlvdSBkb24ndCBjYXJlIC4uLiB3ZWxsIEkgZG9uJ3QgY2FyZSBlaXRoZXIuCj4g Cj4gTG9vaywgaWYgdGhpcyBjYXVzZXMganVzdCBvbmUgY29uZmxpY3QgZG93biB0aGUgbGluZSBi ZWNhdXNlIGl0IHRvdWNoZXMKPiB0aGUga2VybmVsIGFsbCBvdmVyIHRoZSBwbGFjZSwgdGhlbiBJ TU8gaXQgYWxyZWFkeSB3YXNuJ3Qgd29ydGgKPiBpdC4gTWVyZ2UgY29uZmxpY3RzIGFyZSBpbmV2 aXRhYmxlLCBidXQgdGhlcmUncyBubyByZWFzb24gdG8gbWFrZSBsaWZlCj4gaGFyZGVyIGp1c3Qg dG8gY2F0ZXIgZm9yIGEgY2xlYW51cCBwYXRjaC4gSXQncyBub3QgdGhhdCBpbXBvcnRhbnQuCj4g Cj4gSGFkIGl0IGJlZW4gc3BsaXQgdXAsIHRoZSBkcm0gcGFydHMgd291bGQndmUgYmVlbiBtZXJn ZWQgYWxyZWFkeS4KCkkganVzdCBzdGFnZSBwYXRjaGVzIGxpa2UgdGhpcyBiZWhpbmQgbGludXgt bmV4dC4gIFNvIGlmIHlvdXIgc3R1ZmYgaW4KaW4gLW5leHQsIHlvdSdsbCBuZXZlciBub3RpY2Ug YSB0aGluZy4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 20 Feb 2018 15:47:15 -0800 From: Andrew Morton To: Jani Nikula Cc: Pavel Machek , Christophe LEROY , elfring@users.sourceforge.net, kernel list , vgupta@synopsys.com, linux@armlinux.org.uk, oleg@redhat.com, catalin.marinas@arm.com, will.deacon@arm.com, paulus@ozlabs.org, benh@kernel.crashing.org, mpe@ellerman.id.au, ard.biesheuvel@linaro.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, scott.bauer@intel.com, jonathan.derrick@intel.com, axboe@kernel.dk, daniel.lezcano@linaro.org, maxime.ripard@free-electrons.com, wens@csie.org, alexander.deucher@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, airlied@linux.ie, robdclark@gmail.com, joro@8bytes.org, shli@kernel.org, shawnguo@kernel.org, kernel@pengutronix.de, fabio.estevam@nxp.com, Alexey.Brodkin@synopsys.com, mhocko@suse.com, vbabka@suse.cz, Vladislav.Zakharov@synopsys.com, noamca@mellanox.com, yamada.masahiro@socionext.com, sboyd@codeaurora.org, viresh.kumar@linaro.org, linus.walleij@linaro.org, heiko@sntech.de, aik@ozlabs.ru, ruscur@russell.cc, david@gibson.dropbear.id.au, fbarrat@linux.vnet.ibm.com, alistair@popple.id.au, robh@kernel.org, joe@perches.com, harry.wentland@amd.com, tony.cheng@amd.com, Wenjing.Liu@amd.com, airlied@redhat.com, Ding.Wang@amd.com, sylvia.tsai@amd.com, hersenxs.wu@amd.com, Rex.Zhu@amd.com, JinHuiEric.Huang@amd.com, dan.carpenter@oracle.com, architt@codeaurora.org, narmstrong@baylibre.com, ville.syrjala@linux.intel.com, jcrouse@codeaurora.org, aishpant@gmail.com, noralf@tronnes.org, andresx7@gmail.com, Monk.Liu@amd.com, nicolai.haehnle@amd.com, Andrey.Grodzovsky@amd.com, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-efi@vger.kernel.org, linux-block@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, iommu@lists.linux-foundation.org, linux-raid@vger.kernel.org Subject: Re: [PATCH] fix double ;;s in code Message-Id: <20180220154715.2a8ecd75a1c2cc698baefd26@linux-foundation.org> In-Reply-To: <87o9kkcck3.fsf@intel.com> References: <20180217211955.GE9640@amd> <187435d4-5017-edb5-9b6a-b433a148bfcc@c-s.fr> <20180219154135.GV22199@phenom.ffwll.local> <20180219193312.GA3709@amd> <87o9kkcck3.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII List-ID: On Tue, 20 Feb 2018 10:03:56 +0200 Jani Nikula wrote: > On Mon, 19 Feb 2018, Pavel Machek wrote: > > On Mon 2018-02-19 16:41:35, Daniel Vetter wrote: > >> Yeah, pls split this into one patch per area, with a suitable patch > >> subject prefix. Look at git log of each file to get a feeling for what's > >> the standard in each area. > > > > Yeah I can spend hour spliting it, and then people will ignore it > > anyway. > > > > If you care about one of the files being modified, please fix the > > bug, ";;" is a clear bug. > > > > If you don't care ... well I don't care either. > > Look, if this causes just one conflict down the line because it touches > the kernel all over the place, then IMO it already wasn't worth > it. Merge conflicts are inevitable, but there's no reason to make life > harder just to cater for a cleanup patch. It's not that important. > > Had it been split up, the drm parts would've been merged already. I just stage patches like this behind linux-next. So if your stuff in in -next, you'll never notice a thing. From mboxrd@z Thu Jan 1 00:00:00 1970 From: akpm@linux-foundation.org (Andrew Morton) Date: Tue, 20 Feb 2018 15:47:15 -0800 Subject: [PATCH] fix double ;;s in code In-Reply-To: <87o9kkcck3.fsf@intel.com> References: <20180217211955.GE9640@amd> <187435d4-5017-edb5-9b6a-b433a148bfcc@c-s.fr> <20180219154135.GV22199@phenom.ffwll.local> <20180219193312.GA3709@amd> <87o9kkcck3.fsf@intel.com> List-ID: Message-ID: <20180220154715.2a8ecd75a1c2cc698baefd26@linux-foundation.org> To: linux-snps-arc@lists.infradead.org On Tue, 20 Feb 2018 10:03:56 +0200 Jani Nikula wrote: > On Mon, 19 Feb 2018, Pavel Machek wrote: > > On Mon 2018-02-19 16:41:35, Daniel Vetter wrote: > >> Yeah, pls split this into one patch per area, with a suitable patch > >> subject prefix. Look at git log of each file to get a feeling for what's > >> the standard in each area. > > > > Yeah I can spend hour spliting it, and then people will ignore it > > anyway. > > > > If you care about one of the files being modified, please fix the > > bug, ";;" is a clear bug. > > > > If you don't care ... well I don't care either. > > Look, if this causes just one conflict down the line because it touches > the kernel all over the place, then IMO it already wasn't worth > it. Merge conflicts are inevitable, but there's no reason to make life > harder just to cater for a cleanup patch. It's not that important. > > Had it been split up, the drm parts would've been merged already. I just stage patches like this behind linux-next. So if your stuff in in -next, you'll never notice a thing.