From mboxrd@z Thu Jan 1 00:00:00 1970 From: marcus.folkesson@gmail.com (Marcus Folkesson) Date: Tue, 20 Feb 2018 19:45:22 +0100 Subject: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem In-Reply-To: <20180220181427.GA25467@sophia> References: <20180220104542.32286-1-marcus.folkesson@gmail.com> <20180220124955.GA17814@sophia> <20180220132103.GD24311@gmail.com> <48db897e-8a61-a5bc-5a61-56349cafaa10@roeck-us.net> <20180220153326.GE24311@gmail.com> <20180220181427.GA25467@sophia> Message-ID: <20180220184522.GF24311@gmail.com> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Tue, Feb 20, 2018 at 01:14:27PM -0500, William Breathitt Gray wrote: > On Tue, Feb 20, 2018 at 04:33:26PM +0100, Marcus Folkesson wrote: > >On Tue, Feb 20, 2018 at 07:13:43AM -0800, Guenter Roeck wrote: > >> On 02/20/2018 05:21 AM, Marcus Folkesson wrote: > >> > Hello William, > >> > > >> > On Tue, Feb 20, 2018 at 07:49:55AM -0500, William Breathitt Gray wrote: > >> > > On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote: > >> > > > - Add SPDX identifier > >> > > > - Remove boiler plate license text > >> > > > - If MODULE_LICENSE and boiler plate does not match, go for boiler plate > >> > > > license > >> > > > > >> > > > Signed-off-by: Marcus Folkesson > >> > > > Acked-by: Adam Thomson > >> > > > Acked-by: Charles Keepax > >> > > > Acked-by: Nicolas Ferre > >> > > > Acked-by: Michal Simek > >> > > > --- > >> > > > > >> > > > Notes: > >> > > > v2: > >> > > > - Put back removed copyright texts for meson_gxbb_wdt and coh901327_wdt > >> > > > - Change to BSD-3-Clause for meson_gxbb_wdt > >> > > > v1: Please have an extra look at meson_gxbb_wdt.c > >> > > > >> > > [...] > >> > > > >> > > > diff --git a/drivers/watchdog/ebc-c384_wdt.c b/drivers/watchdog/ebc-c384_wdt.c > >> > > > index 2170b275ea01..c173b6f5c866 100644 > >> > > > --- a/drivers/watchdog/ebc-c384_wdt.c > >> > > > +++ b/drivers/watchdog/ebc-c384_wdt.c > >> > > > @@ -1,15 +1,8 @@ > >> > > > +// SPDX-License-Identifier: GPL-2.0 > >> > > > /* > >> > > > * Watchdog timer driver for the WinSystems EBC-C384 > >> > > > * Copyright (C) 2016 William Breathitt Gray > >> > > > * > > > >The copyright is untouched? > > > >> > > > - * This program is free software; you can redistribute it and/or modify > >> > > > - * it under the terms of the GNU General Public License, version 2, as > >> > > > - * published by the Free Software Foundation. > >> > > > - * > >> > > > - * This program is distributed in the hope that it will be useful, but > >> > > > - * WITHOUT ANY WARRANTY; without even the implied warranty of > >> > > > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > >> > > > - * General Public License for more details. > >> > > > */ > >> > > > #include > >> > > > #include > >> > > >> > Thank you for your feedback! > >> > > > >> > > I have no problem with adding a SPDX line to the top of this file, but > >> > > use "SPDX-License-Identifier: GPL-2.0-only" as I was very intentional > >> > > with the selection of GPL version 2 only when I published this code. > >> > > >> > SPDX-License-Identifier: GPL-2.0 > >> > Is GPL-2.0 only [1], so it respects your choice of license. > > Ah, this should be fine then. :) > Good! > >> > > >> > > > >> > > Furthermore, please do not remove the existing copyright text; although > >> > > >> > >> It is not a matter if you CAN keep a copyright. You MUST NOT remove a copyright. > >> As long as you do, the series is > >> > >> Nacked-by: Guenter Roeck > >> > >> Guenter > > > >I'm sorry, I do not see where the copyright is removed unless you count > >the license text as part of the copyright. > > > >Can you please point it out? > > > >> > >> > The copyright text: > >> > > >> > Copyright (C) 2016 William Breathitt Gray > >> > > >> > Is still in the file. > > > >^^^ > > > >> > > >> > > >> > > it's just boilerplate for some, I was careful with the selection of > >> > > these words, and I worry the SPDX line only -- despite its useful > >> > > conciseness -- may lead to misunderstandings about my intentioned > >> > > license for this code. > >> > > >> > I'm not sure I understand your concerns here, the SPDX identifier is > >> > a shorthand for the GPL 2.0 only license. See [1] - Linux kernel licensing rules. > >> > > >> > One of the biggest benefits with SPDX identifier is that it is hard to verify > >> > boiler plate licenses due to formatting, types, different formulations and so on. > >> > > >> > If still worrying, I think we could keep the license text as > >> > well. > > I'm sorry for the confusion, I should have wrote "license text" rather > than "copyright text" in my previous message. I agree with the benefits No problem at all. > of utilizing the SPDX identifier, and I see the addition of the SPDX > line as useful, but I would prefer the original license text remain as > well. Of course, I will keep the the original license intact for v3. > > William Breathitt Gray > Best regards Marcus Folkesson -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 20 Feb 2018 19:45:44 +0100 (CET) Received: from mail-lf0-x241.google.com ([IPv6:2a00:1450:4010:c07::241]:36051 "EHLO mail-lf0-x241.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23994692AbeBTSpgXGRfK (ORCPT ); Tue, 20 Feb 2018 19:45:36 +0100 Received: by mail-lf0-x241.google.com with SMTP id t79so5644745lfe.3 for ; Tue, 20 Feb 2018 10:45:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/EJYfOtSu0t1Pq8JWDVMB6vqIvu2+ZNIDz5WASpxqKE=; b=dQKGx7h+Brn8GRqZVo2bHOXBMj8rhSd9UR7vd07cZrBRVDo7xj93xsaVZu1M5gUisI /Js0gQLP7znMx9GASVbcGLJI6wm4waPKqYnjn3jsDvAlX9j0DYqQrpttWe/T+S/li2zn eV077TB/yGyvU/+0I4PiWUMd5rRWNx8IQ0mSU4qR+9bs4u2fU6FJaqbZLCWE9AtHGjee 2QKCBmUBd1PSrbeIf80IO+NtItgzUOjIEUMsRkzOwOqFU9DF9IfpBDmbd41mloUfDavm ZwtwOSNVsOo8fyBOWhMzuvGrshN2Mp1DtOYnx/rB5mvrm1Bk+VF4SdbnQ8L0rQYJeeTT IYjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/EJYfOtSu0t1Pq8JWDVMB6vqIvu2+ZNIDz5WASpxqKE=; b=uOM43dBWlyphoVDJsutnyLQzCLB9RJwGa8jmpL3tzaSiu9KoFImf6SLZwFXH0SyPyA Z5v0G90f4jjXMuC48O0Yuw0MGj6X2s3+i/JIOc3fZOkhvnkJCKYvGXYgCFn2R2z9l5Jr 0Uokui4J9yvTk6UrfkCUjcyVaw92oSaSs40v77HC19iyiTkEt54Mud3ZVaKKtgPfrVaj PWlFFIOypdKQgPsCLBpAp+vi9e9jfdfkmHBrwE/BKxR/tuhKENGs4F7MF7M0fhMdVBG9 7yTugQZTRLT70+mC5ek6XmNzHU0R9GU+3enQuZJOnQoyRi0PoV8W2nZfnJv5FKD/2aB0 JujA== X-Gm-Message-State: APf1xPASHWRHmTyZHQ7eFScCHy1pfiYTL1+2rk5USxlBVzYyaBDpl1mW WHXk18KgbXCp79YIXKUtxPU= X-Google-Smtp-Source: AH8x225Ou+XfqrZoRYIPrCm9UpwiheiAfbk1LRLhf8riq9GnNpMwODul68jyGig7keIBSx9E8oMRGQ== X-Received: by 10.46.19.17 with SMTP id 17mr430659ljt.102.1519152329632; Tue, 20 Feb 2018 10:45:29 -0800 (PST) Received: from gmail.com (c-2ec27091-74736162.cust.telenor.se. [46.194.112.145]) by smtp.gmail.com with ESMTPSA id j69sm4453707lfk.16.2018.02.20.10.45.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Feb 2018 10:45:28 -0800 (PST) Date: Tue, 20 Feb 2018 19:45:22 +0100 From: Marcus Folkesson To: William Breathitt Gray Cc: Guenter Roeck , Wim Van Sebroeck , Joel Stanley , Nicolas Ferre , Alexandre Belloni , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Eric Anholt , Stefan Wahren , Linus Walleij , Support Opensource , Baruch Siach , Jimmy Vance , Keguang Zhang , Joachim Eastwood , Tomas Winkler , Johannes Thumshirn , Andreas Werner , Carlo Caione , Kevin Hilman , Matthias Brugger , Wan ZongShun , Michal Simek , Vladimir Zapolskiy , Sylvain Lemieux , Kukjin Kim , Krzysztof Kozlowski , Zwane Mwaikambo , Jim Cromie , Barry Song , Patrice Chotard , Maxime Ripard , Chen-Yu Tsai , Marc Gonzalez , Mans Rullgard , Thierry Reding , Jonathan Hunter , Masahiro Yamada , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Jun Nie , Baoyou Xie , Shawn Guo , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, adi-buildroot-devel@lists.sourceforge.net, linux-mips@linux-mips.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, patches@opensource.cirrus.com Subject: Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem Message-ID: <20180220184522.GF24311@gmail.com> References: <20180220104542.32286-1-marcus.folkesson@gmail.com> <20180220124955.GA17814@sophia> <20180220132103.GD24311@gmail.com> <48db897e-8a61-a5bc-5a61-56349cafaa10@roeck-us.net> <20180220153326.GE24311@gmail.com> <20180220181427.GA25467@sophia> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OgApRN/oydYDdnYz" Content-Disposition: inline In-Reply-To: <20180220181427.GA25467@sophia> User-Agent: Mutt/1.9.1 (2017-09-22) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 62656 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: marcus.folkesson@gmail.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips --OgApRN/oydYDdnYz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 20, 2018 at 01:14:27PM -0500, William Breathitt Gray wrote: > On Tue, Feb 20, 2018 at 04:33:26PM +0100, Marcus Folkesson wrote: > >On Tue, Feb 20, 2018 at 07:13:43AM -0800, Guenter Roeck wrote: > >> On 02/20/2018 05:21 AM, Marcus Folkesson wrote: > >> > Hello William, > >> >=20 > >> > On Tue, Feb 20, 2018 at 07:49:55AM -0500, William Breathitt Gray wro= te: > >> > > On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote: > >> > > > - Add SPDX identifier > >> > > > - Remove boiler plate license text > >> > > > - If MODULE_LICENSE and boiler plate does not match, go for boil= er plate > >> > > > license > >> > > >=20 > >> > > > Signed-off-by: Marcus Folkesson > >> > > > Acked-by: Adam Thomson > >> > > > Acked-by: Charles Keepax > >> > > > Acked-by: Nicolas Ferre > >> > > > Acked-by: Michal Simek > >> > > > --- > >> > > >=20 > >> > > > Notes: > >> > > > v2: > >> > > > - Put back removed copyright texts for meson_gxbb_wdt and c= oh901327_wdt > >> > > > - Change to BSD-3-Clause for meson_gxbb_wdt > >> > > > v1: Please have an extra look at meson_gxbb_wdt.c > >> > >=20 > >> > > [...] > >> > >=20 > >> > > > diff --git a/drivers/watchdog/ebc-c384_wdt.c b/drivers/watchdog/= ebc-c384_wdt.c > >> > > > index 2170b275ea01..c173b6f5c866 100644 > >> > > > --- a/drivers/watchdog/ebc-c384_wdt.c > >> > > > +++ b/drivers/watchdog/ebc-c384_wdt.c > >> > > > @@ -1,15 +1,8 @@ > >> > > > +// SPDX-License-Identifier: GPL-2.0 > >> > > > /* > >> > > > * Watchdog timer driver for the WinSystems EBC-C384 > >> > > > * Copyright (C) 2016 William Breathitt Gray > >> > > > * > > > >The copyright is untouched? > > > >> > > > - * This program is free software; you can redistribute it and/o= r modify > >> > > > - * it under the terms of the GNU General Public License, versio= n 2, as > >> > > > - * published by the Free Software Foundation. > >> > > > - * > >> > > > - * This program is distributed in the hope that it will be usef= ul, but > >> > > > - * WITHOUT ANY WARRANTY; without even the implied warranty of > >> > > > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See th= e GNU > >> > > > - * General Public License for more details. > >> > > > */ > >> > > > #include > >> > > > #include > >> >=20 > >> > Thank you for your feedback! > >> > >=20 > >> > > I have no problem with adding a SPDX line to the top of this file,= but > >> > > use "SPDX-License-Identifier: GPL-2.0-only" as I was very intentio= nal > >> > > with the selection of GPL version 2 only when I published this cod= e. > >> >=20 > >> > SPDX-License-Identifier: GPL-2.0 > >> > Is GPL-2.0 only [1], so it respects your choice of license. >=20 > Ah, this should be fine then. :) >=20 Good! > >> >=20 > >> > >=20 > >> > > Furthermore, please do not remove the existing copyright text; alt= hough > >> >=20 > >>=20 > >> It is not a matter if you CAN keep a copyright. You MUST NOT remove a = copyright. > >> As long as you do, the series is > >>=20 > >> Nacked-by: Guenter Roeck > >>=20 > >> Guenter > > > >I'm sorry, I do not see where the copyright is removed unless you count > >the license text as part of the copyright. > > > >Can you please point it out? > > > >>=20 > >> > The copyright text: > >> >=20 > >> > Copyright (C) 2016 William Breathitt Gray > >> >=20 > >> > Is still in the file. > > > >^^^ > > > >> >=20 > >> >=20 > >> > > it's just boilerplate for some, I was careful with the selection of > >> > > these words, and I worry the SPDX line only -- despite its useful > >> > > conciseness -- may lead to misunderstandings about my intentioned > >> > > license for this code. > >> >=20 > >> > I'm not sure I understand your concerns here, the SPDX identifier is > >> > a shorthand for the GPL 2.0 only license. See [1] - Linux kernel lic= ensing rules. > >> >=20 > >> > One of the biggest benefits with SPDX identifier is that it is hard = to verify > >> > boiler plate licenses due to formatting, types, different formulatio= ns and so on. > >> >=20 > >> > If still worrying, I think we could keep the license text as > >> > well. >=20 > I'm sorry for the confusion, I should have wrote "license text" rather > than "copyright text" in my previous message. I agree with the benefits No problem at all. > of utilizing the SPDX identifier, and I see the addition of the SPDX > line as useful, but I would prefer the original license text remain as > well. Of course, I will keep the the original license intact for v3. >=20 > William Breathitt Gray >=20 Best regards Marcus Folkesson --OgApRN/oydYDdnYz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEBVGi6LZstU1kwSxliIBOb1ldUjIFAlqMbL0ACgkQiIBOb1ld UjJFERAAhuwiBVxCWQs5NKL67h+hidriNHH3ALoXrhBhYQiVIzKyIiNPCHkpf/4C DmquQEuSbAWQoLN73scR5mBRF74ZTu2Oj+BFvu1KS/oj3xdMm0fWBSBkIhyPIFXp 9pjItNmj3OBhODRP472IRlUxDh9LRnNYL20cpwYpUAVQIrM8HHWDl6W6RH5SKXIf CcU1L4Y1i7M5Ir+wuc9bhGPBcHtZopQT7MQh2I/gImWdLVfrPObTsk8KpByaZoCe oWAeZSxJRldTPjL+2X8N7lyabRV/Xvrvg4mJUUFXUfjUY1guIae3xbEMI2Ko/Avu W0zsXNuBy+37KmW4PTZpIEoK0aaN8vipUBcGmwHYXtTDFHATKxjTugw6+VK2Wpj7 vjnLUXOVTcZFdt+wWJd7rpHaRfUGhG3aBu+fi73AoAzQSSQM8X9blHgk4yJ4VDiv dzS60EDoWoew3PprwJIo8ytO4SnMBIglBeuiaa+V9NORc5tczwkwUiH6aStr/KEa +L5OiKgiIVIUU1hAlClazpwF/O6I7KH2RHqIM8oSr7SXas0viPy4IXnwDmwr3wBD DPeBD79K+Txb+EnKC5D/Z9Wu769rwAZ2TYgMjTQWN8W5hgaXwkB6MJVcJKNmlaxQ 8TRf6C+lhOCazPIbV18ltcQFWBT35DnO2mGWa6lnArJrfBN2zVg= =N61S -----END PGP SIGNATURE----- --OgApRN/oydYDdnYz-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcus Folkesson Subject: Re: [PATCH v2] watchdog: add SPDX identifiers for watchdog subsystem Date: Tue, 20 Feb 2018 19:45:22 +0100 Message-ID: <20180220184522.GF24311@gmail.com> References: <20180220104542.32286-1-marcus.folkesson@gmail.com> <20180220124955.GA17814@sophia> <20180220132103.GD24311@gmail.com> <48db897e-8a61-a5bc-5a61-56349cafaa10@roeck-us.net> <20180220153326.GE24311@gmail.com> <20180220181427.GA25467@sophia> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5431834804691408854==" Return-path: In-Reply-To: <20180220181427.GA25467@sophia> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: William Breathitt Gray Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, Baruch Siach , Mans Rullgard , Maxime Ripard , Benjamin Herrenschmidt , Linus Walleij , Patrice Chotard , Eric Anholt , Thierry Reding , Alexandre Belloni , Michael Ellerman , Baoyou Xie , Stefan Wahren , Florian Fainelli , Kevin Hilman , Michal Simek , Krzysztof Kozlowski , Jonathan Hunter , Chen-Yu Tsai , Kukjin Kim , bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, Joel Stanley , Sylvain Lemieux List-Id: linux-mediatek@lists.infradead.org --===============5431834804691408854== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OgApRN/oydYDdnYz" Content-Disposition: inline --OgApRN/oydYDdnYz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 20, 2018 at 01:14:27PM -0500, William Breathitt Gray wrote: > On Tue, Feb 20, 2018 at 04:33:26PM +0100, Marcus Folkesson wrote: > >On Tue, Feb 20, 2018 at 07:13:43AM -0800, Guenter Roeck wrote: > >> On 02/20/2018 05:21 AM, Marcus Folkesson wrote: > >> > Hello William, > >> >=20 > >> > On Tue, Feb 20, 2018 at 07:49:55AM -0500, William Breathitt Gray wro= te: > >> > > On Tue, Feb 20, 2018 at 11:45:31AM +0100, Marcus Folkesson wrote: > >> > > > - Add SPDX identifier > >> > > > - Remove boiler plate license text > >> > > > - If MODULE_LICENSE and boiler plate does not match, go for boil= er plate > >> > > > license > >> > > >=20 > >> > > > Signed-off-by: Marcus Folkesson > >> > > > Acked-by: Adam Thomson > >> > > > Acked-by: Charles Keepax > >> > > > Acked-by: Nicolas Ferre > >> > > > Acked-by: Michal Simek > >> > > > --- > >> > > >=20 > >> > > > Notes: > >> > > > v2: > >> > > > - Put back removed copyright texts for meson_gxbb_wdt and c= oh901327_wdt > >> > > > - Change to BSD-3-Clause for meson_gxbb_wdt > >> > > > v1: Please have an extra look at meson_gxbb_wdt.c > >> > >=20 > >> > > [...] > >> > >=20 > >> > > > diff --git a/drivers/watchdog/ebc-c384_wdt.c b/drivers/watchdog/= ebc-c384_wdt.c > >> > > > index 2170b275ea01..c173b6f5c866 100644 > >> > > > --- a/drivers/watchdog/ebc-c384_wdt.c > >> > > > +++ b/drivers/watchdog/ebc-c384_wdt.c > >> > > > @@ -1,15 +1,8 @@ > >> > > > +// SPDX-License-Identifier: GPL-2.0 > >> > > > /* > >> > > > * Watchdog timer driver for the WinSystems EBC-C384 > >> > > > * Copyright (C) 2016 William Breathitt Gray > >> > > > * > > > >The copyright is untouched? > > > >> > > > - * This program is free software; you can redistribute it and/o= r modify > >> > > > - * it under the terms of the GNU General Public License, versio= n 2, as > >> > > > - * published by the Free Software Foundation. > >> > > > - * > >> > > > - * This program is distributed in the hope that it will be usef= ul, but > >> > > > - * WITHOUT ANY WARRANTY; without even the implied warranty of > >> > > > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See th= e GNU > >> > > > - * General Public License for more details. > >> > > > */ > >> > > > #include > >> > > > #include > >> >=20 > >> > Thank you for your feedback! > >> > >=20 > >> > > I have no problem with adding a SPDX line to the top of this file,= but > >> > > use "SPDX-License-Identifier: GPL-2.0-only" as I was very intentio= nal > >> > > with the selection of GPL version 2 only when I published this cod= e. > >> >=20 > >> > SPDX-License-Identifier: GPL-2.0 > >> > Is GPL-2.0 only [1], so it respects your choice of license. >=20 > Ah, this should be fine then. :) >=20 Good! > >> >=20 > >> > >=20 > >> > > Furthermore, please do not remove the existing copyright text; alt= hough > >> >=20 > >>=20 > >> It is not a matter if you CAN keep a copyright. You MUST NOT remove a = copyright. > >> As long as you do, the series is > >>=20 > >> Nacked-by: Guenter Roeck > >>=20 > >> Guenter > > > >I'm sorry, I do not see where the copyright is removed unless you count > >the license text as part of the copyright. > > > >Can you please point it out? > > > >>=20 > >> > The copyright text: > >> >=20 > >> > Copyright (C) 2016 William Breathitt Gray > >> >=20 > >> > Is still in the file. > > > >^^^ > > > >> >=20 > >> >=20 > >> > > it's just boilerplate for some, I was careful with the selection of > >> > > these words, and I worry the SPDX line only -- despite its useful > >> > > conciseness -- may lead to misunderstandings about my intentioned > >> > > license for this code. > >> >=20 > >> > I'm not sure I understand your concerns here, the SPDX identifier is > >> > a shorthand for the GPL 2.0 only license. See [1] - Linux kernel lic= ensing rules. > >> >=20 > >> > One of the biggest benefits with SPDX identifier is that it is hard = to verify > >> > boiler plate licenses due to formatting, types, different formulatio= ns and so on. > >> >=20 > >> > If still worrying, I think we could keep the license text as > >> > well. >=20 > I'm sorry for the confusion, I should have wrote "license text" rather > than "copyright text" in my previous message. I agree with the benefits No problem at all. > of utilizing the SPDX identifier, and I see the addition of the SPDX > line as useful, but I would prefer the original license text remain as > well. Of course, I will keep the the original license intact for v3. >=20 > William Breathitt Gray >=20 Best regards Marcus Folkesson --OgApRN/oydYDdnYz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEBVGi6LZstU1kwSxliIBOb1ldUjIFAlqMbL0ACgkQiIBOb1ld UjJFERAAhuwiBVxCWQs5NKL67h+hidriNHH3ALoXrhBhYQiVIzKyIiNPCHkpf/4C DmquQEuSbAWQoLN73scR5mBRF74ZTu2Oj+BFvu1KS/oj3xdMm0fWBSBkIhyPIFXp 9pjItNmj3OBhODRP472IRlUxDh9LRnNYL20cpwYpUAVQIrM8HHWDl6W6RH5SKXIf CcU1L4Y1i7M5Ir+wuc9bhGPBcHtZopQT7MQh2I/gImWdLVfrPObTsk8KpByaZoCe oWAeZSxJRldTPjL+2X8N7lyabRV/Xvrvg4mJUUFXUfjUY1guIae3xbEMI2Ko/Avu W0zsXNuBy+37KmW4PTZpIEoK0aaN8vipUBcGmwHYXtTDFHATKxjTugw6+VK2Wpj7 vjnLUXOVTcZFdt+wWJd7rpHaRfUGhG3aBu+fi73AoAzQSSQM8X9blHgk4yJ4VDiv dzS60EDoWoew3PprwJIo8ytO4SnMBIglBeuiaa+V9NORc5tczwkwUiH6aStr/KEa +L5OiKgiIVIUU1hAlClazpwF/O6I7KH2RHqIM8oSr7SXas0viPy4IXnwDmwr3wBD DPeBD79K+Txb+EnKC5D/Z9Wu769rwAZ2TYgMjTQWN8W5hgaXwkB6MJVcJKNmlaxQ 8TRf6C+lhOCazPIbV18ltcQFWBT35DnO2mGWa6lnArJrfBN2zVg= =N61S -----END PGP SIGNATURE----- --OgApRN/oydYDdnYz-- --===============5431834804691408854== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-mediatek mailing list Linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org http://lists.infradead.org/mailman/listinfo/linux-mediatek --===============5431834804691408854==--