From: Steve Dickson <steved@redhat.com>
To: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: [PATCH 3/7] Removed format-overflow=2 warnings
Date: Tue, 20 Feb 2018 13:50:30 -0500 [thread overview]
Message-ID: <20180220185034.26301-4-steved@redhat.com> (raw)
In-Reply-To: <20180220185034.26301-1-steved@redhat.com>
Added the -Werror=format-overflow=2 warning flag
and then cleaned up the mess
Signed-off-by: Steve Dickson <steved@redhat.com>
---
configure.ac | 1 +
support/nfs/cacheio.c | 2 +-
utils/idmapd/idmapd.c | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 31990c3..4f9d8c4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -550,6 +550,7 @@ my_am_cflags="\
-Werror=strict-prototypes \
-Werror=missing-prototypes \
-Werror=missing-declarations \
+ -Werror=format-overflow=2 \
"
AC_SUBST([AM_CFLAGS], ["$my_am_cflags"])
diff --git a/support/nfs/cacheio.c b/support/nfs/cacheio.c
index 9912afa..9dc4cf1 100644
--- a/support/nfs/cacheio.c
+++ b/support/nfs/cacheio.c
@@ -212,7 +212,7 @@ cache_flush(int force)
{
struct stat stb;
int c;
- char stime[20];
+ char stime[32];
char path[200];
time_t now;
/* Note: the order of these caches is important.
diff --git a/utils/idmapd/idmapd.c b/utils/idmapd/idmapd.c
index c7e75bd..67d115d 100644
--- a/utils/idmapd/idmapd.c
+++ b/utils/idmapd/idmapd.c
@@ -169,7 +169,7 @@ static int
flush_nfsd_cache(char *path, time_t now)
{
int fd;
- char stime[20];
+ char stime[32];
sprintf(stime, "%ld\n", now);
fd = open(path, O_RDWR);
--
2.14.3
next prev parent reply other threads:[~2018-02-20 18:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 18:50 [PATCH 0/7] nfs-utils: Use -Werror warning flags to clean up the code Steve Dickson
2018-02-20 18:50 ` [PATCH 1/7] configure.ac: clean up Steve Dickson
2018-02-20 18:50 ` [PATCH 2/7] Removed missing-prototypes warnings Steve Dickson
2018-02-20 18:50 ` Steve Dickson [this message]
2018-02-20 18:50 ` [PATCH 4/7] Removed format=2 warnings Steve Dickson
2018-02-20 18:50 ` [PATCH 5/7] Removed undef warnings Steve Dickson
2018-02-20 18:50 ` [PATCH 6/7] Removed missing-include-dirs warnings Steve Dickson
2018-02-20 18:50 ` [PATCH 7/7] Added more -Werror= warning flags Steve Dickson
2018-02-23 14:21 ` [PATCH 0/7] nfs-utils: Use -Werror warning flags to clean up the code Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220185034.26301-4-steved@redhat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.