From: Denys Dmytriyenko <denis@denix.org>
To: Khem Raj <raj.khem@gmail.com>
Cc: Denys Dmytriyenko <denys@ti.com>,
Otavio Salvador <otavio.salvador@ossystems.com.br>,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] kernel.bbclass: explicitly depend on bison-native for deterministic builds
Date: Tue, 20 Feb 2018 14:33:01 -0500 [thread overview]
Message-ID: <20180220193301.GB2786@denix.org> (raw)
In-Reply-To: <CAMKF1soq1h+EgCz0C4HeRpggTctGiL=0OqQwD9tK0eTZ7K=HQg@mail.gmail.com>
On Tue, Feb 20, 2018 at 10:28:47AM -0800, Khem Raj wrote:
> On Tue, Feb 20, 2018 at 8:17 AM, Denys Dmytriyenko <denis@denix.org> wrote:
> > On Tue, Feb 20, 2018 at 04:08:06PM +0000, Khem Raj wrote:
> >> On Tue, Feb 20, 2018 at 7:41 AM Martin Jansa <martin.jansa@gmail.com> wrote:
> >>
> >> > I'm OK with adding bison-native for all versions.
> >>
> >> As long we know that there are no side effects of this dep in kernel builds
> >
> > You do realize that when you build with oe-core toolchain, every package gets
> > bison-native dependency automatically? Regardless whether it was requested or
> > not. If there were side effects, we would have seen it long time ago...
>
> Yes I see it seems to be pulled in by toolchain regardless, so for this
> patch we might just be adding to determinism. but I think it raises question
> on why toolchain is adding this everywhere, I think we should remove it
> from toolchain default deps. It will make metadata more consistent
> across internal/external toolchains
There were several similar patches I submitted last month for different
components to add flex-native and/or bison-native. Most of them got accepted
and we had a follow up discussion with Richard in gcc thread:
http://lists.openembedded.org/pipermail/openembedded-core/2018-January/146295.html
He also submitted this patch to prevent indirect flex/bison-native
dependencies, but I don't believe it got merged yet:
http://lists.openembedded.org/pipermail/openembedded-core/2018-January/146324.html
Richard, do you have any comments?
--
Denys
prev parent reply other threads:[~2018-02-20 19:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 23:54 [PATCH] kernel.bbclass: explicitly depend on bison-native for deterministic builds Denys Dmytriyenko
2018-02-20 0:36 ` Otavio Salvador
2018-02-20 1:20 ` Denys Dmytriyenko
2018-02-20 10:10 ` Khem Raj
2018-02-20 14:53 ` Otavio Salvador
2018-02-20 15:41 ` Martin Jansa
2018-02-20 16:08 ` Khem Raj
2018-02-20 16:17 ` Denys Dmytriyenko
2018-02-20 18:28 ` Khem Raj
2018-02-20 19:33 ` Denys Dmytriyenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220193301.GB2786@denix.org \
--to=denis@denix.org \
--cc=denys@ti.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=otavio.salvador@ossystems.com.br \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.