From: Bandan Das <bsd@redhat.com>
To: qemu-devel@nongnu.org
Cc: kraxel@redhat.com, eblake@redhat.com, peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH v4 2/5] usb-mtp: print parent path in IN_IGNORED trace fn
Date: Tue, 20 Feb 2018 17:59:01 -0500 [thread overview]
Message-ID: <20180220225904.16129-3-bsd@redhat.com> (raw)
In-Reply-To: <20180220225904.16129-1-bsd@redhat.com>
Fix a possible null dereference when deleting a folder and
its contents. An ignored event might be received for its contents
after the parent folder is deleted which will return a null object.
Signed-off-by: Bandan Das <bsd@redhat.com>
---
hw/usb/dev-mtp.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index b55aa8205e..63f8f3b90b 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -540,9 +540,8 @@ static void inotify_watchfn(void *arg)
break;
case IN_IGNORED:
- o = usb_mtp_object_lookup_name(parent, event->name, event->len);
- trace_usb_mtp_inotify_event(s->dev.addr, o->path,
- event->mask, "Obj ignored");
+ trace_usb_mtp_inotify_event(s->dev.addr, parent->path,
+ event->mask, "Obj parent dir ignored");
break;
default:
--
2.14.3
next prev parent reply other threads:[~2018-02-20 22:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 22:58 [Qemu-devel] [PATCH v4 0/5] Initial write support for MTP objects Bandan Das
2018-02-20 22:59 ` [Qemu-devel] [PATCH v4 1/5] usb-mtp: Add one more argument when building results Bandan Das
2018-02-20 22:59 ` Bandan Das [this message]
2018-02-20 22:59 ` [Qemu-devel] [PATCH v4 3/5] usb-mtp: Support delete of mtp objects Bandan Das
2018-02-21 9:37 ` Daniel P. Berrangé
2018-02-20 22:59 ` [Qemu-devel] [PATCH v4 4/5] usb-mtp: Introduce write support for MTP objects Bandan Das
2018-02-21 9:35 ` Daniel P. Berrangé
2018-02-21 11:11 ` Gerd Hoffmann
2018-02-21 14:33 ` Daniel P. Berrangé
2018-02-21 16:41 ` Bandan Das
2018-02-20 22:59 ` [Qemu-devel] [PATCH v4 5/5] usb-mtp: Advertise SendObjectInfo for write support Bandan Das
2018-02-21 9:36 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220225904.16129-3-bsd@redhat.com \
--to=bsd@redhat.com \
--cc=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.