From: James Hogan <jhogan@kernel.org>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Linux MIPS <linux-mips@linux-mips.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2 1/8] MIPS: Loongson64: cleanup all cs5536 files to use SPDX Identifier
Date: Tue, 20 Feb 2018 23:06:16 +0000 [thread overview]
Message-ID: <20180220230615.GI6245@saruman> (raw)
In-Reply-To: <20171230182830.6496-2-jiaxun.yang@flygoat.com>
[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]
On Sun, Dec 31, 2017 at 02:28:24AM +0800, Jiaxun Yang wrote:
> diff --git a/arch/mips/loongson64/common/cs5536/cs5536_acc.c b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> index ab4d6cc57384..ba0474bb4a3d 100644
> --- a/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> +++ b/arch/mips/loongson64/common/cs5536/cs5536_acc.c
> @@ -1,3 +1,5 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
No other cases I've seen bother with the blank line. Please remove
throughout the series.
> /*
> * the ACC Virtual Support Module of AMD CS5536
> *
> @@ -7,10 +9,6 @@
> * Copyright (C) 2009 Lemote, Inc.
> * Author: Wu Zhangjin, wuzhangjin@gmail.com
> *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms of the GNU General Public License as published by the
> - * Free Software Foundation; either version 2 of the License, or (at your
> - * option) any later version.
or any later version implies it should be "GPL-2.0+"
Same throughout. Please check carefully you aren't changing the stated
license on any files.
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-20 23:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-26 13:23 Cleanup loongson64 mach to use SPDX copyright format Jiaxun Yang
2017-12-26 13:23 ` [PATCH 1/7] MIPS: Loongson64: cleanup all cs5536 files to use SPDX Identifier Jiaxun Yang
2017-12-29 12:40 ` Philippe Ombredanne
2017-12-26 13:23 ` [PATCH 2/7] MIPS: Loongson64: cleanup all loongson common " Jiaxun Yang
2017-12-26 13:23 ` [PATCH 3/7] MIPS: Loongson64: cleanup all fuloong-2e " Jiaxun Yang
2017-12-26 13:23 ` [PATCH 4/7] MIPS: Loongson64: cleanup all lemote-2f " Jiaxun Yang
2017-12-26 13:23 ` [PATCH 5/7] MIPS: Loongson64: cleanup all loongson-3 " Jiaxun Yang
2017-12-26 13:23 ` [PATCH 6/7] MIPS: Loongson64: cleanup all mach " Jiaxun Yang
2017-12-26 13:23 ` [PATCH 7/7] MIPS: Loongson64: cleanup all include " Jiaxun Yang
2017-12-30 18:28 ` Cleanup loongson64 mach to use SPDX copyright format v2 Jiaxun Yang
2017-12-30 18:28 ` [PATCHv2 1/8] MIPS: Loongson64: cleanup all cs5536 files to use SPDX Identifier Jiaxun Yang
2017-12-31 11:17 ` Philippe Ombredanne
2017-12-31 13:14 ` Jiaxun Yang
2017-12-31 13:54 ` Philippe Ombredanne
2018-01-02 2:32 ` Huacai Chen
2018-02-20 23:06 ` James Hogan [this message]
2017-12-30 18:28 ` [PATCHv2 2/8] MIPS: Loongson64: cleanup all loongson common " Jiaxun Yang
2017-12-30 18:28 ` [PATCHv2 3/8] MIPS: Loongson64: cleanup all fuloong-2e " Jiaxun Yang
2017-12-30 18:28 ` [PATCHv2 4/8] MIPS: Loongson64: cleanup all lemote-2f " Jiaxun Yang
2017-12-30 18:28 ` [PATCHv2 5/8] MIPS: Loongson64: cleanup all loongson-3 " Jiaxun Yang
2017-12-30 18:28 ` [PATCHv2 6/8] MIPS: Loongson64: cleanup all mach " Jiaxun Yang
2018-02-20 23:01 ` James Hogan
2017-12-30 18:28 ` [PATCHv2 7/8] MIPS: Loongson64: cleanup all include " Jiaxun Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220230615.GI6245@saruman \
--to=jhogan@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=pombredanne@nexb.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.