From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 21 Feb 2018 07:46:50 -0500 Subject: [U-Boot] [PATCH] config_whitelist: remove false-positive CONFIG options In-Reply-To: References: <1515176226-22173-1-git-send-email-yamada.masahiro@socionext.com> <20180221121956.GF4311@bill-the-cat> Message-ID: <20180221124650.GG4311@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Feb 21, 2018 at 09:41:10PM +0900, Masahiro Yamada wrote: > 2018-02-21 21:19 GMT+09:00 Tom Rini : > > On Wed, Feb 21, 2018 at 04:07:10PM +0900, Masahiro Yamada wrote: > >> 2018-01-06 3:17 GMT+09:00 Masahiro Yamada : > >> > U-Boot pulled in several core makefiles from Linux. The following > >> > are not used in U-Boot: > >> > > >> > - CONFIG_DEBUG_SECTION_MISMATCH > >> > - CONFIG_FTRACE_MCOUNT_RECORD > >> > - CONFIG_GCOV_KERNEL > >> > - CONFIG_GCOV_PROFILE_ALL > >> > - CONFIG_KASAN > >> > - CONFIG_MODVERSIONS > >> > > >> > We can remove the unused code if we like. (although it will get the > >> > scripts out of sync) > >> > > >> > CONFIG_BOOM and CONFIG_HIS_DRIVER are just mentioned in the comment > >> > block of scripts/basic/fixdep.c > >> > > >> > CONFIG_SHELL is not configuration, but a variable for internal-use. > >> > It is just a historical misnomer in Kbuild. > >> > > >> > Signed-off-by: Masahiro Yamada > >> > >> > >> Tom, > >> > >> Can you check this please? > > > > The problem is that it will get put back in by > > ./scripts/build-whitelist.sh yes? > > No. > > If you incrementally run build-whitelist.sh, > they will not get back. > > > If you delete config_whitelist.txt and > build it from scratch, yes, they will get back > with other options we had already deleted. > > For example, commit 8bb0f7c0c59e8c5b6f7a6869b802f593739c7ece > > But we do not want to do this. > > > > For detailed implementation, see below. > > https://github.com/u-boot/u-boot/blob/v2018.03-rc3/scripts/build-whitelist.sh#L50 Ah, ok, thanks. Yes, I'll grab this soon. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: