Re: [Outreachy kernel] [PATCH] staging: vt6655: remove additional blank line

[Santha Meena Ramamoorthy <santhameena13@gmail.com>]

On Tue, Feb 20, 2018 at 08:36:52AM +0530, Vaishali Thakkar wrote:
> On Mon, Feb 19, 2018 at 11:24 PM, Santha Meena Ramamoorthy
> <santhameena13@gmail.com> wrote:
> > On Mon, Feb 19, 2018 at 09:36:46AM +0530, Vaishali Thakkar wrote:
> >> On Mon, Feb 19, 2018 at 4:32 AM, Santha Meena Ramamoorthy
> >> <santhameena13@gmail.com> wrote:
> >> > Remove extra blank line inside a function to conform to Linux
> >> > kernel coding style. Problem detected using checkpatch.
> >>
> >> Hi Santha,
> >>
> >> Change looks fine to me but subject of this patch is bit confusing.
> >>
> >> Can you change it to 'Remove extra blank line'?
> >
> > Hi,
> > I just got an email saying that the patch has been added to the staging tree.
> > Now, I'm confused if I should submit v2 or leave it as is. Can you plese
> > help me?
> 
> Hi,
> 
> Please cc mailing list to keep everyone in the loop. And no, if Greg has
> added a patch in his tree then no need to resend teh patch. But you
> can just keep this point in mind. :)

Hi,
Thank you. I'll keep it in mind. And I'll also make sure that I include the
mailing list in all my messages. 

> 
> > Thanks,
> > Santha
> >>
> >> > Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>
> >> > ---
> >> >  drivers/staging/vt6655/rxtx.c | 1 -
> >> >  1 file changed, 1 deletion(-)
> >> >
> >> > diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> >> > index 9aa4d52..bea0b7f 100644
> >> > --- a/drivers/staging/vt6655/rxtx.c
> >> > +++ b/drivers/staging/vt6655/rxtx.c
> >> > @@ -1080,7 +1080,6 @@ s_cbFillTxBufHead(struct vnt_private *pDevice, unsigned char byPktType,
> >> >         else if (fifo_ctl & FIFOCTL_AUTO_FB_1)
> >> >                 byFBOption = AUTO_FB_1;
> >> >
> >> > -
> >> >         /* Set RrvTime/RTS/CTS Buffer */
> >> >         wTxBufSize = sizeof(struct vnt_tx_fifo_head);
> >> >         if (byPktType == PK_TYPE_11GB || byPktType == PK_TYPE_11GA) {/* 802.11g packet */
> >> > --
> >> > 2.7.4
> >> >
> >> > --
> >> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> >> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> >> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> >> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1518994920-4952-1-git-send-email-santhameena13%40gmail.com.
> >> > For more options, visit https://groups.google.com/d/optout.