From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Enforce BBM for huge IO/VMAP mappings
Date: Wed, 21 Feb 2018 17:47:19 +0000 [thread overview]
Message-ID: <20180221174718.GA3083@arm.com> (raw)
In-Reply-To: <20180221174423.tdqy43y64tcdzkmw@armageddon.cambridge.arm.com>
On Wed, Feb 21, 2018 at 05:44:24PM +0000, Catalin Marinas wrote:
> On Wed, Feb 21, 2018 at 12:59:27PM +0000, Will Deacon wrote:
> > ioremap_page_range doesn't honour break-before-make and attempts to put
> > down huge mappings (using p*d_set_huge) over the top of pre-existing
> > table entries. This leads to us leaking page table memory and also gives
> > rise to TLB conflicts and spurious aborts, which have been seen in
> > practice on Cortex-A75.
> >
> > Until this has been resolved, refuse to put block mappings when the
> > existing entry is found to be present.
> >
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Reported-by: Hanjun Guo <hanjun.guo@linaro.org>
> > Reported-by: Lei Li <lious.lilei@hisilicon.com>
> > Signed-off-by: Will Deacon <will.deacon@arm.com>
>
> Queued for 4.16. Shall we put a cc stable?
Yes, good idea:
Fixes: 324420bf91f60 ("arm64: add support for ioremap() block mappings")
Will
prev parent reply other threads:[~2018-02-21 17:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 12:59 [PATCH] arm64: Enforce BBM for huge IO/VMAP mappings Will Deacon
2018-02-21 13:12 ` Ard Biesheuvel
2018-02-21 17:44 ` Catalin Marinas
2018-02-21 17:47 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180221174718.GA3083@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.