From: Michael McCormick <michael.mccormick@enatel.net>
To: <a.zummo@towertech.it>
Cc: <alexandre.belloni@free-electrons.com>,
<linux-rtc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<michael.mccormick@enatel.net>
Subject: [PATCH] pcf85063 was not clearing bits correctly in pcf85063_start_clock
Date: Thu, 22 Feb 2018 11:29:24 +1300 [thread overview]
Message-ID: <20180221222924.GA11756@michael-virtual-machine> (raw)
Bit clear operation was missing ~
Signed-off-by: Michael McCormick <michael.mccormick@enatel.net>
---
drivers/rtc/rtc-pcf85063.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c
index a06dff9..67bc763 100644
--- a/drivers/rtc/rtc-pcf85063.c
+++ b/drivers/rtc/rtc-pcf85063.c
@@ -70,7 +70,7 @@ static int pcf85063_start_clock(struct i2c_client *client, u8 ctrl1)
s32 ret;
/* start the clock */
- ctrl1 &= PCF85063_REG_CTRL1_STOP;
+ ctrl1 &= ~PCF85063_REG_CTRL1_STOP;
ret = i2c_smbus_write_byte_data(client, PCF85063_REG_CTRL1, ctrl1);
if (ret < 0) {
--
2.7.4
next reply other threads:[~2018-02-21 22:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 22:29 Michael McCormick [this message]
2018-03-13 0:41 ` [PATCH] pcf85063 was not clearing bits correctly in pcf85063_start_clock Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180221222924.GA11756@michael-virtual-machine \
--to=michael.mccormick@enatel.net \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.