From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH-FOR-NEXT v1 6/6] qt5webengine: set ninja host pkg-config tool
Date: Wed, 21 Feb 2018 22:59:31 +0100 [thread overview]
Message-ID: <20180221225931.5996c857@windsurf.lan> (raw)
In-Reply-To: <20180221142801.28997-7-gael.portay@savoirfairelinux.com>
Hello,
On Wed, 21 Feb 2018 09:28:01 -0500, Ga?l PORTAY wrote:
> The WebEngine build system uses pkg-config to get package data for both
> host and target architectures.
>
> Using the same call to pkg-config for both target and host leads to
> build mismatches.
>
> In this situation, it tries to link a host-tool using target libraries.
>
> Qt is able to set host pkg-config for Ninja, using environment variable
> $GN_PKG_CONFIG_HOST[1].
>
> Fixes:
>
> FAILED: host/transport_security_state_generator
> /home/gportay/src/buildroot/output-qt5.10/host/bin/python2 "../../3rdparty/chromium/build/toolchain/gcc_link_wrapper.py" --output="host/transport_security_state_generator" -- /usr/bin/g++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--no-as-needed -lpthread -Wl,--as-needed -m64 -Wl,-O1 -Wl,--gc-sections -Wl,-rpath-link=host -Wl,--disable-new-dtags -L/home/gportay/src/buildroot/output-qt5.10/host/x86_64-buildroot-linux-gnu/sysroot/usr/lib -o "host/transport_security_state_generator" -Wl,--start-group @"host/transport_security_state_generator.rsp" -Wl,--end-group -ldl -lpthread -lrt -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4
> /usr/bin/ld: cannot find /lib64/libpthread.so.0
> /usr/bin/ld: cannot find /usr/lib64/libpthread_nonshared.a
> collect2: error: ld returned 1 exit status
> ninja: build stopped: subcommand failed.
> Makefile.gn_run:449: recipe for target 'run_ninja' failed
>
> [1]: https://github.com/qt/qtwebengine/blob/v5.10.1/src/core/config/linux.pri#L111-L125
>
> Signed-off-by: Ga?l PORTAY <gael.portay@savoirfairelinux.com>
Same comment for this one as for PATCH 5/6: what happens if we apply
your series up to PATCH 5/6, but excluding PATCH 6/6 ? qt5webengine
will fail to build, while it was building before, which is a
regression. So I assume this should be in the 5.10 bump as well, or
kept separate during the review, and squashed when applying. But it
should be mentioned.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2018-02-21 21:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 14:27 [Buildroot] [PATCH-FOR-NEXT v1 0/6] Qt5 bump latest version to 5.10.1 Gaël PORTAY
2018-02-21 14:27 ` [Buildroot] [PATCH-FOR-NEXT v1 1/6] package: add libnpsr host package Gaël PORTAY
2018-02-21 21:27 ` Thomas Petazzoni
2018-02-22 14:29 ` Gaël PORTAY
2018-02-22 16:38 ` Baruch Siach
2018-02-21 14:27 ` [Buildroot] [PATCH-FOR-NEXT v1 2/6] package: add libnss " Gaël PORTAY
2018-02-21 21:32 ` Thomas Petazzoni
2018-02-21 14:27 ` [Buildroot] [PATCH-FOR-NEXT v1 3/6] pkgconf: add host-pkg-config wrapper Gaël PORTAY
2018-02-21 21:50 ` Thomas Petazzoni
2018-02-22 9:27 ` Arnout Vandecappelle
2018-02-22 9:41 ` Thomas Petazzoni
2018-02-22 10:56 ` Arnout Vandecappelle
2018-02-25 20:38 ` Thomas De Schampheleire
2018-02-25 20:53 ` Yann E. MORIN
2018-02-25 21:56 ` Thomas De Schampheleire
2018-02-21 14:27 ` [Buildroot] [PATCH-FOR-NEXT v1 4/6] qt5: bump latest version to 5.10.1 Gaël PORTAY
2018-02-21 21:56 ` Thomas Petazzoni
2018-02-23 18:32 ` Peter Seiderer
2018-02-21 14:28 ` [Buildroot] [PATCH-FOR-NEXT v1 5/6] qt5webengine: satisfy new requirements for 5.10 Gaël PORTAY
2018-02-21 21:58 ` Thomas Petazzoni
2018-02-22 14:42 ` Gaël PORTAY
2018-02-21 14:28 ` [Buildroot] [PATCH-FOR-NEXT v1 6/6] qt5webengine: set ninja host pkg-config tool Gaël PORTAY
2018-02-21 21:59 ` Thomas Petazzoni [this message]
2018-02-22 14:44 ` Gaël PORTAY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180221225931.5996c857@windsurf.lan \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.