All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philip Li <philip.li@intel.com>
To: NeilBrown <neilb@suse.com>
Cc: kbuild test robot <lkp@intel.com>,
	linux-nfs@vger.kernel.org,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	kbuild-all@01.org, Anna Schumaker <anna.schumaker@netapp.com>
Subject: Re: [kbuild-all] [PATCH 19/23] NFS/NFSD/SUNRPC: replace generic creds with 'struct cred'.
Date: Thu, 22 Feb 2018 09:51:23 +0800	[thread overview]
Message-ID: <20180222015123.GA14244@intel.com> (raw)
In-Reply-To: <87woz8jz0g.fsf@notabene.neil.brown.name>

On Tue, Feb 20, 2018 at 11:17:03AM +1100, NeilBrown wrote:
> On Mon, Feb 19 2018, kbuild test robot wrote:
> 
> > Hi NeilBrown,
> >
> > Thank you for the patch! Perhaps something to improve:
> >
> > [auto build test WARNING on nfs/linux-next]
> > [also build test WARNING on v4.16-rc2 next-20180219]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> >
> > url:    https://github.com/0day-ci/linux/commits/NeilBrown/Remove-generic-rpc-credentials-and-associated-changed-V3/20180219-190836
> > base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
> > reproduce:
> >         # apt-get install sparse
> >         make ARCH=x86_64 allmodconfig
> >         make C=1 CF=-D__CHECK_ENDIAN__
> >
> >
> > sparse warnings: (new ones prefixed by >>)
> >
> >>> fs/nfs/flexfilelayout/flexfilelayout.c:517:40: sparse: incorrect type in initializer (different address spaces) @@ expected struct cred const @@ got cred const @@
> >    fs/nfs/flexfilelayout/flexfilelayout.c:517:40: expected struct cred const
> >    fs/nfs/flexfilelayout/flexfilelayout.c:517:40: got struct cred const Documentation Kbuild Kconfig Makefile certs drivers firmware fs include samples scripts sound tools cred
> 
> Hi Mr Robot :-)
>  It looks like you have some strange wild-card expansion happening here.
>  I think the above should be
> >    fs/nfs/flexfilelayout/flexfilelayout.c:517:40: got struct cred const * cred
thanks for pointing this out, we will fix it.

> 
> Even after correcting the that, I cannot see what the different address
> spaces are that might be a problem.
> Does anyone have any ideas?
> 
> Thanks,
> NeilBrown



> _______________________________________________
> kbuild-all mailing list
> kbuild-all@lists.01.org
> https://lists.01.org/mailman/listinfo/kbuild-all


  reply	other threads:[~2018-02-22  1:44 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-19  5:02 [PATCH 00/23] Remove generic rpc credentials, and associated changed - V3 NeilBrown
2018-02-19  5:02 ` [PATCH 03/23] cred: export get_task_cred() NeilBrown
2018-02-19  5:02 ` [PATCH 02/23] cred: add get_cred_rcu() NeilBrown
2018-02-19  5:02 ` [PATCH 01/23] cred: add cred_fscmp() for comparing creds NeilBrown
2018-02-19  5:02 ` [PATCH 06/23] SUNRPC: remove groupinfo from struct auth_cred NeilBrown
2018-02-19  5:02 ` [PATCH 04/23] cred: allow get_cred() and put_cred() to be given NULL NeilBrown
2018-02-19  5:02 ` [PATCH 05/23] SUNRPC: add 'struct cred *' to auth_cred and rpc_cred NeilBrown
2018-02-19  5:02 ` [PATCH 17/23] NFS: change access cache to use 'struct cred' NeilBrown
2018-02-19  5:02 ` [PATCH 22/23] SUNRPC: simplify auth_unix NeilBrown
2018-02-19  5:02 ` [PATCH 10/23] NFSv4: don't require lock for get_renew_cred or get_machine_cred NeilBrown
2018-02-19  5:02 ` [PATCH 14/23] SUNRPC: add side channel to use non-generic cred for rpc call NeilBrown
2018-02-19 16:39   ` [SUNRPC] e22c8d3cf4: BUG:KASAN:use-after-free_in_r kernel test robot
2018-02-20  0:09     ` NeilBrown
2018-02-20  0:09       ` NeilBrown
2018-02-20  0:10   ` [PATCH 14/23 - V2] SUNRPC: add side channel to use non-generic cred for rpc call NeilBrown
2018-02-19  5:02 ` [PATCH 21/23] SUNRPC: remove crbind rpc_cred operation NeilBrown
2018-02-19  5:02 ` [PATCH 13/23] SUNRPC: introduce RPC_TASK_NULLCREDS to request auth_none NeilBrown
2018-02-19  5:02 ` [PATCH 11/23] SUNRPC: discard RPC_DO_ROOTOVERRIDE() NeilBrown
2018-02-19  5:02 ` [PATCH 19/23] NFS/NFSD/SUNRPC: replace generic creds with 'struct cred' NeilBrown
2018-02-19 14:58   ` kbuild test robot
2018-02-20  0:17     ` NeilBrown
2018-02-22  1:51       ` Philip Li [this message]
2018-02-22  2:31         ` [kbuild-all] " Fengguang Wu
2018-02-19  5:02 ` [PATCH 07/23] SUNRPC: remove uid and gid from struct auth_cred NeilBrown
2018-02-19  5:02 ` [PATCH 20/23] SUNRPC: remove generic cred code NeilBrown
2018-02-19  5:02 ` [PATCH 08/23] SUNRPC: remove machine_cred field from struct auth_cred NeilBrown
2018-02-19  5:02 ` [PATCH 18/23] NFS: struct nfs_open_dir_context: convert rpc_cred pointer to cred NeilBrown
2018-02-19  5:02 ` [PATCH 09/23] NFSv4: add cl_root_cred for use when machine cred is not available NeilBrown
2018-02-19  5:02 ` [PATCH 23/23] SUNRPC: discard cr_uid from struct rpc_cred NeilBrown
2018-02-19  5:02 ` [PATCH 15/23] NFS: move credential expiry tracking out of SUNRPC into NFS NeilBrown
2018-02-19  5:02 ` [PATCH 16/23] SUNRPC: remove RPCAUTH_AUTH_NO_CRKEY_TIMEOUT NeilBrown
2018-02-19  5:02 ` [PATCH 12/23] NFS/SUNRPC: don't lookup machine credential until rpcauth_bindcred() NeilBrown
2018-02-19 14:41   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180222015123.GA14244@intel.com \
    --to=philip.li@intel.com \
    --cc=anna.schumaker@netapp.com \
    --cc=kbuild-all@01.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=neilb@suse.com \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.