From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH] fix double ;;s in code Date: Thu, 22 Feb 2018 17:09:33 +0800 Message-ID: <20180222090932.GJ3217@dragon> References: <20180217211955.GE9640@amd> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180217211955.GE9640@amd> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Pavel Machek Cc: daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, airlied-cv59FeDIM0c@public.gmane.org, benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org, linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Alexey.Brodkin-HKixBCOQz3hWk0Htik3J/w@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, fbarrat-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, kernel list , paulus-mnsaURCQ41sdnm+yROfE0A@public.gmane.org, yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org, mhocko-IBi9RG/b67k@public.gmane.org, viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, JinHuiEric.Huang-5C7GfCeVMHo@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, scott.bauer-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, David1.Zhou-5C7GfCeVMHo@public.gmane.org, architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org, joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Wenjing.Liu-5C7GfCeVMHo@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Ding.Wang-5C7GfCeVMHo@public.gmane.org, aik-sLpHqDYs0B2HXe+LvDLADg@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, vbabka-AlSwsSmVLrQ@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, airlied-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ruscur-3Su/lFKaw5ejKv3TNrM5DQ@public.gmane.org, shli-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.orga SGkgUGF2ZWwsCgpPbiBTYXQsIEZlYiAxNywgMjAxOCBhdCAxMDoxOTo1NVBNICswMTAwLCBQYXZl bCBNYWNoZWsgd3JvdGU6Ci4uLgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3NvYy9pbXgvZ3BjLmMg Yi9kcml2ZXJzL3NvYy9pbXgvZ3BjLmMKPiBpbmRleCA1M2Y3Mjc1Li5jZmI0MmY1IDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvc29jL2lteC9ncGMuYwo+ICsrKyBiL2RyaXZlcnMvc29jL2lteC9ncGMu Ywo+IEBAIC0zNDgsNyArMzQ4LDcgQEAgc3RhdGljIGludCBpbXhfZ3BjX29sZF9kdF9pbml0KHN0 cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IHJlZ21hcCAqcmVnbWFwLAo+ICAJCWlmIChpID09IDEp IHsKPiAgCQkJZG9tYWluLT5zdXBwbHkgPSBkZXZtX3JlZ3VsYXRvcl9nZXQoZGV2LCAicHUiKTsK PiAgCQkJaWYgKElTX0VSUihkb21haW4tPnN1cHBseSkpCj4gLQkJCQlyZXR1cm4gUFRSX0VSUihk b21haW4tPnN1cHBseSk7Owo+ICsJCQkJcmV0dXJuIFBUUl9FUlIoZG9tYWluLT5zdXBwbHkpOwo+ ICAKPiAgCQkJcmV0ID0gaW14X3BnY19nZXRfY2xvY2tzKGRldiwgZG9tYWluKTsKPiAgCQkJaWYg KHJldCkKPiAKCkNvbnNpZGVyaW5nIHRoZSBjb250cm92ZXJzeSBob3cgdGhlIGNoYW5nZXMgc2hv dWxkIGJlIG1lcmdlZCwgSSdtIGdvaW5nCnRvIHNlbmQgYSBzZXBhcmF0ZSBwYXRjaCBqdXN0IGZv ciBJTVggR1BDIGRyaXZlciB3aXRoIGEgcmVwb3J0ZWQtYnkteW91CnRhZy4gIFRoYW5rcyBmb3Ig Y2F0Y2hpbmcgdGhpcy4KClNoYXduCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1k LWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 22 Feb 2018 17:09:33 +0800 From: Shawn Guo To: Pavel Machek Cc: elfring@users.sourceforge.net, kernel list , vgupta@synopsys.com, linux@armlinux.org.uk, oleg@redhat.com, catalin.marinas@arm.com, will.deacon@arm.com, paulus@ozlabs.org, benh@kernel.crashing.org, mpe@ellerman.id.au, ard.biesheuvel@linaro.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, scott.bauer@intel.com, jonathan.derrick@intel.com, axboe@kernel.dk, daniel.lezcano@linaro.org, maxime.ripard@free-electrons.com, wens@csie.org, alexander.deucher@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, airlied@linux.ie, robdclark@gmail.com, joro@8bytes.org, shli@kernel.org, kernel@pengutronix.de, fabio.estevam@nxp.com, akpm@linux-foundation.org, Alexey.Brodkin@synopsys.com, mhocko@suse.com, vbabka@suse.cz, Vladislav.Zakharov@synopsys.com, noamca@mellanox.com, yamada.masahiro@socionext.com, sboyd@codeaurora.org, viresh.kumar@linaro.org, linus.walleij@linaro.org, heiko@sntech.de, aik@ozlabs.ru, ruscur@russell.cc, david@gibson.dropbear.id.au, fbarrat@linux.vnet.ibm.com, alistair@popple.id.au, robh@kernel.org, joe@perches.com, harry.wentland@amd.com, tony.cheng@amd.com, Wenjing.Liu@amd.com, airlied@redhat.com, Ding.Wang@amd.com, sylvia.tsai@amd.com, hersenxs.wu@amd.com, Rex.Zhu@amd.com, JinHuiEric.Huang@amd.com, dan.carpenter@oracle.com, architt@codeaurora.org, daniel.vetter@ffwll.ch, narmstrong@baylibre.com, ville.syrjala@linux.intel.com, jcrouse@codeaurora.org, aishpant@gmail.com, noralf@tronnes.org, andresx7@gmail.com, Monk.Liu@amd.com, nicolai.haehnle@amd.com, Andrey.Grodzovsky@amd.com, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-efi@vger.kernel.org, linux-block@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, iommu@lists.linux-foundation.org, linux-raid@vger.kernel.org Subject: Re: [PATCH] fix double ;;s in code Message-ID: <20180222090932.GJ3217@dragon> References: <20180217211955.GE9640@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180217211955.GE9640@amd> List-ID: Hi Pavel, On Sat, Feb 17, 2018 at 10:19:55PM +0100, Pavel Machek wrote: ... > diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c > index 53f7275..cfb42f5 100644 > --- a/drivers/soc/imx/gpc.c > +++ b/drivers/soc/imx/gpc.c > @@ -348,7 +348,7 @@ static int imx_gpc_old_dt_init(struct device *dev, struct regmap *regmap, > if (i == 1) { > domain->supply = devm_regulator_get(dev, "pu"); > if (IS_ERR(domain->supply)) > - return PTR_ERR(domain->supply);; > + return PTR_ERR(domain->supply); > > ret = imx_pgc_get_clocks(dev, domain); > if (ret) > Considering the controversy how the changes should be merged, I'm going to send a separate patch just for IMX GPC driver with a reported-by-you tag. Thanks for catching this. Shawn From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawnguo@kernel.org (Shawn Guo) Date: Thu, 22 Feb 2018 17:09:33 +0800 Subject: [PATCH] fix double ;;s in code In-Reply-To: <20180217211955.GE9640@amd> References: <20180217211955.GE9640@amd> List-ID: Message-ID: <20180222090932.GJ3217@dragon> To: linux-snps-arc@lists.infradead.org Hi Pavel, On Sat, Feb 17, 2018@10:19:55PM +0100, Pavel Machek wrote: ... > diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c > index 53f7275..cfb42f5 100644 > --- a/drivers/soc/imx/gpc.c > +++ b/drivers/soc/imx/gpc.c > @@ -348,7 +348,7 @@ static int imx_gpc_old_dt_init(struct device *dev, struct regmap *regmap, > if (i == 1) { > domain->supply = devm_regulator_get(dev, "pu"); > if (IS_ERR(domain->supply)) > - return PTR_ERR(domain->supply);; > + return PTR_ERR(domain->supply); > > ret = imx_pgc_get_clocks(dev, domain); > if (ret) > Considering the controversy how the changes should be merged, I'm going to send a separate patch just for IMX GPC driver with a reported-by-you tag. Thanks for catching this. Shawn