From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eomuN-0001Fl-OY for qemu-devel@nongnu.org; Thu, 22 Feb 2018 04:11:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eomuJ-0007Yr-F0 for qemu-devel@nongnu.org; Thu, 22 Feb 2018 04:11:19 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36524 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eomuJ-0007YK-AV for qemu-devel@nongnu.org; Thu, 22 Feb 2018 04:11:15 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 49E034084FEC for ; Thu, 22 Feb 2018 09:11:14 +0000 (UTC) Date: Thu, 22 Feb 2018 09:11:08 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180222091108.GB9323@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20180222070513.8740-1-kraxel@redhat.com> <20180222070513.8740-3-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180222070513.8740-3-kraxel@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 2/5] keymap: use glib hash for kbd_layout_t List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Thu, Feb 22, 2018 at 08:05:10AM +0100, Gerd Hoffmann wrote: > Drop home-grown lookup code, which is a strange mix of a lookup table > and a list. Use standard glib hash instead. >=20 > Signed-off-by: Gerd Hoffmann > --- > ui/keymaps.c | 73 ++++++++++++++++++++++++-------------------------= -------- > ui/trace-events | 2 +- > 2 files changed, 32 insertions(+), 43 deletions(-) Reviewed-by: Daniel P. Berrang=C3=A9 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|