From: Alan.Robinson@ts.fujitsu.com (Alan Robinson)
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
xen-devel@lists.xen.org,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] get_maintainers.pl: Avoid THE_REST when files are added or removed
Date: Thu, 22 Feb 2018 11:34:36 +0100 [thread overview]
Message-ID: <20180222103435.GA15983@ts.fujitsu.com> (raw)
In-Reply-To: <5A8E9F5C02000078001AA468@prv-mh.provo.novell.com>
Hi Jan,
On Thu, Feb 22, 2018 at 02:45:48AM -0700, Jan Beulich wrote:
> Oh, I see - it's the file name collection code you change, not the
> consuming side, I'm sorry for the noise. However, isn't
> omitting the leading / a potential problem then?
The leading / is stripped away several lines before this..
> While it's not
> very likely for us to gain ./dev/null, it's also not entirely impossible.
True and this change does mean that get_maintainer.pl would fail to
recognise such a patch as a patch..(just tried)
> Furthermore, shouldn't you move the setting of $lastfile into
> the conditional as well?
Let me send a second version....
Alan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-02-22 10:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 9:09 [PATCH] get_maintainers.pl: Avoid THE_REST when files are added or removed Alan Robinson
2018-02-22 9:16 ` Jan Beulich
2018-02-22 9:27 ` Alan Robinson
2018-02-22 9:45 ` Jan Beulich
2018-02-22 10:34 ` Alan Robinson [this message]
2018-02-22 11:38 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180222103435.GA15983@ts.fujitsu.com \
--to=alan.robinson@ts.fujitsu.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.