From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v3 3/6] drm/i915: Clean up fbc vs. plane checks Date: Thu, 22 Feb 2018 16:07:53 +0200 Message-ID: <20180222140753.GW5453@intel.com> References: <20180221160235.11134-4-ville.syrjala@linux.intel.com> <20180221173101.19385-1-ville.syrjala@linux.intel.com> <151925036770.11316.4219131821645278587@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6A63C6E057 for ; Thu, 22 Feb 2018 14:07:58 +0000 (UTC) Content-Disposition: inline In-Reply-To: <151925036770.11316.4219131821645278587@mail.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBGZWIgMjEsIDIwMTggYXQgMDk6NTk6MjdQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgVmlsbGUgU3lyamFsYSAoMjAxOC0wMi0yMSAxNzozMTowMSkKPiA+IEZy b206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAK PiA+IExldCdzIHJlY29yZCB0aGUgaW5mb3JtYXRpb24gd2hldGhlciBhIHBsYW5lIGNhbiBkbyBm YmMgb3Igbm90IHVuZGVyCj4gPiBzdHJ1Y3QgaW50ZV9wbGFuZS4KPiA+IAo+ID4gdjI6IFJlYmFz ZSBkdWUgdG8gaTl4eF9wbGFuZV9pZAo+ID4gICAgIEhhbmRsZSBCRFcvSFNXIGNvcnJlY3RseQo+ ID4gdjM6IE1vdmUgaW50ZV9mYmNfaW5pdCgpIGJhY2sgc2luY2Ugd2UgZGVwZW5kIG9uIGl0IGhh cHBlbmluZwo+ID4gICAgIGV2ZW4gd2l0aCBpOTE1LmRpc2FibGVfZGlzcGxheSwgYW5kIHBvcHVs YXRlCj4gPiAgICAgZmJjLT5wb3NzaWJsZV9mcmFtZWJ1ZmZlcl9iaXRzIGRpcmVjdGx5IGZyb20g dGhlCj4gPiAgICAgcGxhbmUgaW5pdCBjb2RlIGluc3RlYWQKPiA+IAo+ID4gQ2M6IENocmlzIFdp bHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUg U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDQxICsrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKwo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5o ICAgICB8ICAxICsKPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmMuYyAgICAgfCAy NiArKy0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gIDMgZmlsZXMgY2hhbmdlZCwgNDQgaW5zZXJ0 aW9ucygrKSwgMjQgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMKPiA+IGluZGV4IGQyYTY2NzA0ZTZmNS4uYzYwZDIyMTViMzc3IDEwMDY0NAo+ID4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IEBAIC0xMzIzOCw2ICsxMzIzOCwz MiBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9wbGFuZV9mdW5jcyBpbnRlbF9jdXJzb3JfcGxh bmVfZnVuY3MgPSB7Cj4gPiAgICAgICAgIC5mb3JtYXRfbW9kX3N1cHBvcnRlZCA9IGludGVsX2N1 cnNvcl9wbGFuZV9mb3JtYXRfbW9kX3N1cHBvcnRlZCwKPiA+ICB9Owo+ID4gIAo+ID4gK3N0YXRp YyBib29sIGk5eHhfcGxhbmVfaGFzX2ZiYyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZW51bSBpOXh4X3BsYW5lX2lk IGk5eHhfcGxhbmUpCj4gPiArewo+ID4gKyAgICAgICBpZiAoIUhBU19GQkMoZGV2X3ByaXYpKQo+ ID4gKyAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKPiAKPiA+IC1zdGF0aWMgaW5saW5lIGJv b2wgZmJjX29uX3BpcGVfYV9vbmx5KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikK PiA+IC17Cj4gPiAtICAgICAgIHJldHVybiBJU19IQVNXRUxMKGRldl9wcml2KSB8fCBJTlRFTF9H RU4oZGV2X3ByaXYpID49IDg7Cj4gPiAtfQo+ID4gLQo+ID4gLXN0YXRpYyBpbmxpbmUgYm9vbCBm YmNfb25fcGxhbmVfYV9vbmx5KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ IC17Cj4gPiAtICAgICAgIHJldHVybiBJTlRFTF9HRU4oZGV2X3ByaXYpIDwgNDsKPiA+IC19Cj4g Cj4gPiArCj4gPiArICAgICAgIGlmIChJU19CUk9BRFdFTEwoZGV2X3ByaXYpIHx8IElTX0hBU1dF TEwoZGV2X3ByaXYpKQo+ID4gKyAgICAgICAgICAgICAgIHJldHVybiBpOXh4X3BsYW5lID09IFBM QU5FX0E7Cj4gCj4gV2hlcmUgUExBTkVfQSBpcyB0aWVkIHRvIFBJUEVfQSBieSBjb25zdHJ1Y3Rp b24uIElzIHRoYXQgd29ydGggYSBxdWljawo+IGNvbW1lbnQ/CgpXb3VsZG4ndCBodXJ0IHRvIHNw ZWxsIGl0IG91dCBJIHN1cHBvc2UuCgo+IAo+ID4gKyAgICAgICBlbHNlIGlmIChJU19JVllCUklE R0UoZGV2X3ByaXYpKQo+ID4gKyAgICAgICAgICAgICAgIHJldHVybiBpOXh4X3BsYW5lID09IFBM QU5FX0EgfHwgaTl4eF9wbGFuZSA9PSBQTEFORV9CIHx8Cj4gPiArICAgICAgICAgICAgICAgICAg ICAgICBpOXh4X3BsYW5lID09IFBMQU5FX0M7Cj4gPiArICAgICAgIGVsc2UgaWYgKElOVEVMX0dF TihkZXZfcHJpdikgPj0gNCkKPiA+ICsgICAgICAgICAgICAgICByZXR1cm4gaTl4eF9wbGFuZSA9 PSBQTEFORV9BIHx8IGk5eHhfcGxhbmUgPT0gUExBTkVfQjsKPiA+ICsgICAgICAgZWxzZQo+ID4g KyAgICAgICAgICAgICAgIHJldHVybiBpOXh4X3BsYW5lID09IFBMQU5FX0E7Cj4gCj4gT2ssIGxv b2tzIGEgYml0IG1vcmUgY29tcGxldGUgdGhhbiBiZWZvcmUuCj4gCj4gPiArfQo+ID4gKwo+ID4g K3N0YXRpYyBib29sIHNrbF9wbGFuZV9oYXNfZmJjKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGVudW0gcGlwZSBwaXBl LCBlbnVtIHBsYW5lX2lkIHBsYW5lX2lkKQo+ID4gK3sKPiA+ICsgICAgICAgaWYgKCFIQVNfRkJD KGRldl9wcml2KSkKPiA+ICsgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Cj4gPiArCj4gPiAr ICAgICAgIHJldHVybiBwaXBlID09IFBJUEVfQSAmJiBwbGFuZV9pZCA9PSBQTEFORV9QUklNQVJZ Owo+ID4gK30KPiA+ICsKPiA+ICBzdGF0aWMgc3RydWN0IGludGVsX3BsYW5lICoKPiA+ICBpbnRl bF9wcmltYXJ5X3BsYW5lX2NyZWF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs IGVudW0gcGlwZSBwaXBlKQo+ID4gIHsKPiA+IEBAIC0xMzI4MCw2ICsxMzMwNiwyMSBAQCBpbnRl bF9wcmltYXJ5X3BsYW5lX2NyZWF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs IGVudW0gcGlwZSBwaXBlKQo+ID4gICAgICAgICAgICAgICAgIHByaW1hcnktPmk5eHhfcGxhbmUg PSAoZW51bSBpOXh4X3BsYW5lX2lkKSBwaXBlOwo+ID4gICAgICAgICBwcmltYXJ5LT5pZCA9IFBM QU5FX1BSSU1BUlk7Cj4gPiAgICAgICAgIHByaW1hcnktPmZyb250YnVmZmVyX2JpdCA9IElOVEVM X0ZST05UQlVGRkVSKHBpcGUsIHByaW1hcnktPmlkKTsKPiA+ICsKPiA+ICsgICAgICAgaWYgKElO VEVMX0dFTihkZXZfcHJpdikgPj0gOSkKPiA+ICsgICAgICAgICAgICAgICBwcmltYXJ5LT5oYXNf ZmJjID0gc2tsX3BsYW5lX2hhc19mYmMoZGV2X3ByaXYsCj4gPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHByaW1hcnktPnBpcGUsCj4gPiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHByaW1hcnkt PmlkKTsKPiA+ICsgICAgICAgZWxzZQo+ID4gKyAgICAgICAgICAgICAgIHByaW1hcnktPmhhc19m YmMgPSBpOXh4X3BsYW5lX2hhc19mYmMoZGV2X3ByaXYsCj4gPiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwcmltYXJ5LT5pOXh4X3BsYW5lKTsK PiA+ICsKPiA+ICsgICAgICAgaWYgKHByaW1hcnktPmhhc19mYmMpIHsKPiA+ICsgICAgICAgICAg ICAgICBzdHJ1Y3QgaW50ZWxfZmJjICpmYmMgPSAmZGV2X3ByaXYtPmZiYzsKPiA+ICsKPiA+ICsg ICAgICAgICAgICAgICBmYmMtPnBvc3NpYmxlX2ZyYW1lYnVmZmVyX2JpdHMgfD0gcHJpbWFyeS0+ ZnJvbnRidWZmZXJfYml0Owo+ID4gKyAgICAgICB9Cj4gCj4gU28gYW4gZXF1aXZhbGVudCBpbml0 IGxvb3AgdG8KPiAKPiA+IC0gICAgICAgZm9yX2VhY2hfcGlwZShkZXZfcHJpdiwgcGlwZSkgewo+ ID4gLSAgICAgICAgICAgICAgIGZiYy0+cG9zc2libGVfZnJhbWVidWZmZXJfYml0cyB8PQo+ID4g LSAgICAgICAgICAgICAgICAgICAgICAgSU5URUxfRlJPTlRCVUZGRVIocGlwZSwgUExBTkVfUFJJ TUFSWSk7Cj4gPiAtCj4gPiAtICAgICAgICAgICAgICAgaWYgKGZiY19vbl9waXBlX2Ffb25seShk ZXZfcHJpdikpCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKPiA+IC0gICAgICAg fQo+IAo+IFJldmlld2VkLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51 az4KPiAtQ2hyaXMKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=