From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Disseldorp Date: Thu, 22 Feb 2018 13:36:24 +0000 Subject: Re: [PATCH 0/8] target-iSCSI: Adjustments for several function implementations Message-Id: <20180222143624.7c7241a1@suse.de> List-Id: References: <6163538d-a406-2f60-11a2-88b4694e9975@users.sourceforge.net> In-Reply-To: <6163538d-a406-2f60-11a2-88b4694e9975@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1254" Content-Transfer-Encoding: base64 To: target-devel@vger.kernel.org W2NjIGxpc3QgdHJpbW1lZF0KCk9uIFdlZCwgMjEgRmViIDIwMTggMTc6NDU6MzUgKzAxMDAsIFNG IE1hcmt1cyBFbGZyaW5nIHdyb3RlOgoKLi4uCj4gT25lIG9mIHRoZXNlIHVwZGF0ZSBzdWdnZXN0 aW9ucyByZXN1bHRlZCBpbiB0aGUgY29tbWl0IOKAnHRhcmdldDogYXZvaWQgTlVMTAo+IGRlcmVm ZXJlbmNlIGluIENIQVAgYXV0aCBlcnJvciBwYXRo4oCdIHdoaWNoIGlzIGNvbnNpZGVyZWQgZm9y IGludGVncmF0aW9uCj4gaW50byBMaW51eCBzdGFibGUgdmVyc2lvbnMgbm93Lgo+IGh0dHBzOi8v cGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gvMTAxMTA0NTkvCj4gaHR0cHM6Ly9sa21sLmtlcm5l bC5vcmcvci88MjAxNzEyMTMxNzIyMzAuMTI3NjctMS1kZGlzc0BzdXNlLmRlPgo+IGh0dHBzOi8v Z2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRzL2xpbnV4Lmdp dC9jb21taXQvZHJpdmVycy90YXJnZXQvaXNjc2kvaXNjc2lfdGFyZ2V0X2F1dGguYz9pZM41MTJk NzlkMDQ2NmE2MDQ3OTNhZGRiNmI3NjlkMTJlZTMyNjgyMgoKWW91J3JlIDEvOCBwYXRjaCBoYWQg YW4gYWN0dWFsIGJ1ZyBmaXggaGlkZGVuIGFtb25nc3QgdGhlIHN0eWxlIGNodXJuLgpJIGRvbid0 IHNlZSBhbnkgc3VjaCBmaXhlcyBpbiB0aGUgb3RoZXIgcGF0Y2hlcy4KCj4gTm93IEkgYW0gY3Vy aW91cyBpZiBtb3JlIHJlbWFpbmluZyBjaGFuZ2UgcG9zc2liaWxpdGllcyBjYW4gYmUgcGlja2Vk IHVwCj4gZnJvbSB0aGlzIHBhdGNoIHNlcmllcy4KPiAKPiAqIFdvdWxkIHlvdSBsaWtlIHRvIGlt cHJvdmUgYW55IG1vcmUgaW1wbGVtZW50YXRpb24gZGV0YWlscz8KPiAKPiAqIERvIHlvdSBuZWVk IGFkZGl0aW9uYWwgZXhwbGFuYXRpb25zIGZvciBmdXJ0aGVyIGJlbmVmaXRzPwoKTXkgb3Bpbmlv biBmcm9tIGh0dHBzOi8vd3d3LnNwaW5pY3MubmV0L2xpc3RzL3RhcmdldC1kZXZlbC9tc2cxNjM0 Mi5odG1sCmhhc24ndCBjaGFuZ2VkLiBGV0lXLCBJJ2QgcHJlZmVyIHRvIHNlZSBMSU8gYWRvcHQg YSBwb2xpY3kgc2ltaWxhciB0bzoKaHR0cHM6Ly9idHJmcy53aWtpLmtlcm5lbC5vcmcvaW5kZXgu cGhwL0RldmVsb3BlciUyN3NfRkFRI0hvd19ub3RfdG9fc3RhcnQKCkNoZWVycywgRGF2aWQKLS0K VG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJl IGtlcm5lbC1qYW5pdG9ycyIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2 Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVs Lm9yZy9tYWpvcmRvbW8taW5mby5odG1s From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Disseldorp Date: Thu, 22 Feb 2018 13:36:24 +0000 Subject: Re: [PATCH 0/8] target-iSCSI: Adjustments for several function implementations Message-Id: <20180222143624.7c7241a1@suse.de> List-Id: References: <6163538d-a406-2f60-11a2-88b4694e9975@users.sourceforge.net> In-Reply-To: <6163538d-a406-2f60-11a2-88b4694e9975@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: target-devel@vger.kernel.org [cc list trimmed] On Wed, 21 Feb 2018 17:45:35 +0100, SF Markus Elfring wrote: ... > One of these update suggestions resulted in the commit “target: avoid NULL > dereference in CHAP auth error path” which is considered for integration > into Linux stable versions now. > https://patchwork.kernel.org/patch/10110459/ > https://lkml.kernel.org/r/<20171213172230.12767-1-ddiss@suse.de> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/target/iscsi/iscsi_target_auth.c?id�512d79d0466a604793addb6b769d12ee326822 You're 1/8 patch had an actual bug fix hidden amongst the style churn. I don't see any such fixes in the other patches. > Now I am curious if more remaining change possibilities can be picked up > from this patch series. > > * Would you like to improve any more implementation details? > > * Do you need additional explanations for further benefits? My opinion from https://www.spinics.net/lists/target-devel/msg16342.html hasn't changed. FWIW, I'd prefer to see LIO adopt a policy similar to: https://btrfs.wiki.kernel.org/index.php/Developer%27s_FAQ#How_not_to_start Cheers, David