Re: [tpm2] Some issues with tpm2-tss, tpm2-tools regarding packaging

[Philip Tricca <philip.b.tricca at intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1356 bytes --]

Hi Matthias,

On Thu, Feb 22, 2018 at 03:46:27PM +0100, Matthias Gerstner wrote:
> > > - The distribution tarballs of tpm2-tss and tpm2-tools try to determine
> > >   the package version via `git describe [...]` in configure.ac. This
> > >   doesn't work, because there is no git repository any more. This caused
> > >   e.g. the pkgconfig files like sapi.pc to contain an empty version
> > >   number, which in turn caused tpm2-tools to fail to build, because the
> > >   version check failed.
> > > 
> > 
> > This shouldn't be an issue if the released tarball (as generated by make dist)
> > is used, only when using the source tarball. With the former, there's no need
> > to call bootstrap since a configure script with a PACKAGE_VERSION is shipped.
> 
> this is true. I can't use the 1.3.0 release tarball at the moment,
> because of the missing README, LICENSE and CHANGELOG files. It should
> work with the next release tarball then.

We've been queuing up changes in the 1.x branch for another release and
these fixes are among them. Now that the new AC commands are in and tested
we're ready for another minor release. I've got time blocked off to get
the first RC out tomorrow. I'll be sure to get a message out to the list
to announce the new RC when it's up on github.

Thanks again for the valuable feedback,
Philip