From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] common/xfs: Initialise OPTIND for getopts calls
Date: Fri, 23 Feb 2018 15:56:25 +1100 [thread overview]
Message-ID: <20180223045625.GA30854@dastard> (raw)
In-Reply-To: <20180223042928.GV18267@eguan.usersys.redhat.com>
On Fri, Feb 23, 2018 at 12:29:28PM +0800, Eryu Guan wrote:
> On Fri, Feb 23, 2018 at 02:54:54PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > According to the bash man page:
> >
> > OPTIND is initialized to 1 each time the shell or a shell
> > script is invoked.
> >
> > This doesn't appear to be true - in tests scripts with no other
> > getopts calls, I'm seeing the getopts loop in _xfs_check to fail
> > to parse input parameters correctly. Tracing shows the parameters
> > are being passed to _xfs_check correctly, but on occassion getopts
> > simply doesn't see the,
>
> Hmm, unfinished sentence here?
Typo. "simply doesn't see them."
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2018-02-23 4:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 3:54 [PATCH] common/xfs: Initialise OPTIND for getopts calls Dave Chinner
2018-02-23 4:29 ` Eryu Guan
2018-02-23 4:56 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223045625.GA30854@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.