From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec Date: Fri, 23 Feb 2018 09:07:14 +0100 Message-ID: <20180223080714.GC1584@amd> References: <20180214220741.28306-1-sebastian.reichel@collabora.co.uk> <20180214220741.28306-3-sebastian.reichel@collabora.co.uk> <20180216113901.GC5886@sirena.org.uk> <20180216135113.akicejkodhbjpp2w@earth.universe> <20180216142716.GJ5886@sirena.org.uk> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6877952755298681874==" Return-path: Received: from atrey.karlin.mff.cuni.cz (atrey.karlin.mff.cuni.cz [195.113.26.193]) by alsa0.perex.cz (Postfix) with ESMTP id 2E55F267872 for ; Fri, 23 Feb 2018 09:07:27 +0100 (CET) In-Reply-To: <20180216142716.GJ5886@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, Tony Lindgren , linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Rob Herring , Sebastian Reichel List-Id: alsa-devel@alsa-project.org --===============6877952755298681874== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HG+GLK89HZ1zG0kk" Content-Disposition: inline --HG+GLK89HZ1zG0kk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri 2018-02-16 14:27:16, Mark Brown wrote: > On Fri, Feb 16, 2018 at 02:51:13PM +0100, Sebastian Reichel wrote: > > On Fri, Feb 16, 2018 at 11:39:01AM +0000, Mark Brown wrote: >=20 > > > We don't have default lines like this for other MFDs... >=20 > > Is there a reason not to add them? It looks very useful to me: >=20 > Consistency. It's a lot easier to apply a single rule to everything > than it is to have to individually think through and discuss the > decisions on every individual driver, especially when there will > inevitably be some cases where there are conflicting requirements from > different users. As you said in the rest of your mail hand configuring > kernels is already a very specialist thing at the best of times. Yes, so please don't make it any harder than it needs to be. Having to enable (by hand) more than one option per chip is annoying and error-prone. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --HG+GLK89HZ1zG0kk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlqPy7IACgkQMOfwapXb+vKrRACfSPOLbfTzlyi3wGezRGoMK7VH /XIAnj7ERmB7Ow0NtqtO7NdiHNvCrnwh =4tK+ -----END PGP SIGNATURE----- --HG+GLK89HZ1zG0kk-- --===============6877952755298681874== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============6877952755298681874==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751447AbeBWIHa (ORCPT ); Fri, 23 Feb 2018 03:07:30 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:33547 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751329AbeBWIH2 (ORCPT ); Fri, 23 Feb 2018 03:07:28 -0500 Date: Fri, 23 Feb 2018 09:07:14 +0100 From: Pavel Machek To: Mark Brown Cc: Sebastian Reichel , Liam Girdwood , Rob Herring , Tony Lindgren , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec Message-ID: <20180223080714.GC1584@amd> References: <20180214220741.28306-1-sebastian.reichel@collabora.co.uk> <20180214220741.28306-3-sebastian.reichel@collabora.co.uk> <20180216113901.GC5886@sirena.org.uk> <20180216135113.akicejkodhbjpp2w@earth.universe> <20180216142716.GJ5886@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HG+GLK89HZ1zG0kk" Content-Disposition: inline In-Reply-To: <20180216142716.GJ5886@sirena.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --HG+GLK89HZ1zG0kk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri 2018-02-16 14:27:16, Mark Brown wrote: > On Fri, Feb 16, 2018 at 02:51:13PM +0100, Sebastian Reichel wrote: > > On Fri, Feb 16, 2018 at 11:39:01AM +0000, Mark Brown wrote: >=20 > > > We don't have default lines like this for other MFDs... >=20 > > Is there a reason not to add them? It looks very useful to me: >=20 > Consistency. It's a lot easier to apply a single rule to everything > than it is to have to individually think through and discuss the > decisions on every individual driver, especially when there will > inevitably be some cases where there are conflicting requirements from > different users. As you said in the rest of your mail hand configuring > kernels is already a very specialist thing at the best of times. Yes, so please don't make it any harder than it needs to be. Having to enable (by hand) more than one option per chip is annoying and error-prone. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --HG+GLK89HZ1zG0kk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlqPy7IACgkQMOfwapXb+vKrRACfSPOLbfTzlyi3wGezRGoMK7VH /XIAnj7ERmB7Ow0NtqtO7NdiHNvCrnwh =4tK+ -----END PGP SIGNATURE----- --HG+GLK89HZ1zG0kk--