From: Stephen Hemminger <stephen@networkplumber.org>
To: Masatake YAMATO <yamato@redhat.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2] ss: prepare rth when killing inet sock
Date: Fri, 23 Feb 2018 08:33:23 -0800 [thread overview]
Message-ID: <20180223083323.6c6db1bf@xeon-e3> (raw)
In-Reply-To: <20180215191120.16176-1-yamato@redhat.com>
On Fri, 16 Feb 2018 04:11:20 +0900
Masatake YAMATO <yamato@redhat.com> wrote:
> kill_inet_sock() expects rhn_handle instance is passed
> via inet_diag_arg argument. However on the following calling path:
>
> generic_show_sock
> => show_one_inet_sock
> => kill_inet_sock
>
> rth field of inet_diag_arg is not filled with the address of
> rhn_handle instance. As the result ss crashes.
>
> This commit fills the field with newly created rhn_handle
> instance.
>
> Changes in v2:
> Instead of creating rtn_handle instances for each socket, create
> one in upper layer and reuse it.
>
> Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Applied.
Thanks for following through.
prev parent reply other threads:[~2018-02-23 16:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 19:11 [PATCH v2] ss: prepare rth when killing inet sock Masatake YAMATO
2018-02-23 16:33 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223083323.6c6db1bf@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=yamato@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.