From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay3-d.mail.gandi.net ([217.70.183.195]:42244 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750798AbeBWKGO (ORCPT ); Fri, 23 Feb 2018 05:06:14 -0500 Date: Fri, 23 Feb 2018 11:06:07 +0100 From: jacopo mondi To: Geert Uytterhoeven Cc: Jacopo Mondi , Arnd Bergmann , Simon Horman , Magnus Damm , Rob Herring , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , Linux-Renesas , Linux Kernel Mailing List Subject: Re: [PATCH 6/6] arm64: dts: renesas: r8a77965: Add #interrupt-cells property Message-ID: <20180223100607.GO7203@w540> References: <1519326370-15805-1-git-send-email-jacopo+renesas@jmondi.org> <1519326370-15805-7-git-send-email-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Geert, On Fri, Feb 23, 2018 at 10:27:16AM +0100, Geert Uytterhoeven wrote: > On Thu, Feb 22, 2018 at 8:06 PM, Jacopo Mondi wrote: > > Add "#interrupt-cells" property and "interrupt-controller" label to > > "interrupt-controller@e61c0000" device node. > > > > This silences the following DTC compiler warnings: > > Warning (interrupts_property): Missing interrupt-controller or > > interrupt-map property in /soc/interrupt-controller@e61c0000 > > Warning (interrupts_property): Missing #interrupt-cells in > > interrupt-parent /soc/interrupt-controller@e61c000 > > > > Signed-off-by: Jacopo Mondi > > Reviewed-by: Geert Uytterhoeven > > > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > @@ -316,6 +316,8 @@ > > }; > > > > intc_ex: interrupt-controller@e61c0000 { > > + #interrupt-cells = <2>; > > + interrupt-controller; > > reg = <0 0xe61c0000 0 0x200>; > > /* placeholder */ > > (bikeshedding) Should the placeholder be at the top of the node? I would like it more too, but in M3-W dtsi: pciec0: pcie@fe000000 { reg = <0 0xfe000000 0 0x80000>; /* placeholder */ }; So I kept using the same style everywhere here. I can change it everywhere in this series to have placeholder at the beginning of the node definition if you agree with that! Thanks j > > > }; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: jacopo@jmondi.org (jacopo mondi) Date: Fri, 23 Feb 2018 11:06:07 +0100 Subject: [PATCH 6/6] arm64: dts: renesas: r8a77965: Add #interrupt-cells property In-Reply-To: References: <1519326370-15805-1-git-send-email-jacopo+renesas@jmondi.org> <1519326370-15805-7-git-send-email-jacopo+renesas@jmondi.org> Message-ID: <20180223100607.GO7203@w540> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Geert, On Fri, Feb 23, 2018 at 10:27:16AM +0100, Geert Uytterhoeven wrote: > On Thu, Feb 22, 2018 at 8:06 PM, Jacopo Mondi wrote: > > Add "#interrupt-cells" property and "interrupt-controller" label to > > "interrupt-controller at e61c0000" device node. > > > > This silences the following DTC compiler warnings: > > Warning (interrupts_property): Missing interrupt-controller or > > interrupt-map property in /soc/interrupt-controller at e61c0000 > > Warning (interrupts_property): Missing #interrupt-cells in > > interrupt-parent /soc/interrupt-controller at e61c000 > > > > Signed-off-by: Jacopo Mondi > > Reviewed-by: Geert Uytterhoeven > > > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > @@ -316,6 +316,8 @@ > > }; > > > > intc_ex: interrupt-controller at e61c0000 { > > + #interrupt-cells = <2>; > > + interrupt-controller; > > reg = <0 0xe61c0000 0 0x200>; > > /* placeholder */ > > (bikeshedding) Should the placeholder be at the top of the node? I would like it more too, but in M3-W dtsi: pciec0: pcie at fe000000 { reg = <0 0xfe000000 0 0x80000>; /* placeholder */ }; So I kept using the same style everywhere here. I can change it everywhere in this series to have placeholder at the beginning of the node definition if you agree with that! Thanks j > > > }; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 From: jacopo mondi Subject: Re: [PATCH 6/6] arm64: dts: renesas: r8a77965: Add #interrupt-cells property Date: Fri, 23 Feb 2018 11:06:07 +0100 Message-ID: <20180223100607.GO7203@w540> References: <1519326370-15805-1-git-send-email-jacopo+renesas@jmondi.org> <1519326370-15805-7-git-send-email-jacopo+renesas@jmondi.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Geert Uytterhoeven Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Arnd Bergmann , Magnus Damm , Linux Kernel Mailing List , Rob Herring , Linux-Renesas , Simon Horman , Jacopo Mondi , Linux ARM List-Id: devicetree@vger.kernel.org Hi Geert, On Fri, Feb 23, 2018 at 10:27:16AM +0100, Geert Uytterhoeven wrote: > On Thu, Feb 22, 2018 at 8:06 PM, Jacopo Mondi wrote: > > Add "#interrupt-cells" property and "interrupt-controller" label to > > "interrupt-controller@e61c0000" device node. > > > > This silences the following DTC compiler warnings: > > Warning (interrupts_property): Missing interrupt-controller or > > interrupt-map property in /soc/interrupt-controller@e61c0000 > > Warning (interrupts_property): Missing #interrupt-cells in > > interrupt-parent /soc/interrupt-controller@e61c000 > > > > Signed-off-by: Jacopo Mondi > > Reviewed-by: Geert Uytterhoeven > > > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > @@ -316,6 +316,8 @@ > > }; > > > > intc_ex: interrupt-controller@e61c0000 { > > + #interrupt-cells = <2>; > > + interrupt-controller; > > reg = <0 0xe61c0000 0 0x200>; > > /* placeholder */ > > (bikeshedding) Should the placeholder be at the top of the node? I would like it more too, but in M3-W dtsi: pciec0: pcie@fe000000 { reg = <0 0xfe000000 0 0x80000>; /* placeholder */ }; So I kept using the same style everywhere here. I can change it everywhere in this series to have placeholder at the beginning of the node definition if you agree with that! Thanks j > > > }; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds